On 17/10/2024 08:43, Miklos Vajna wrote:
Hi Regina, On Wed, Oct 16, 2024 at 05:52:31PM +0200, Regina Henschel <rb.henschel@xxxxxxxxxxx> wrote:Problem: Method test::BootstrapFixture::validate() validates against a fixed version, currently against 'OpenDocument-v1.4+libreoffice'. That means, that some tests, that currently use a construct like SetODFDefaultVersion(SvtSaveOptions::ODFVER_013_EXTENDED); save(...) or saveAndReload(...) will fail, because ODF 1.3 is written but test is against ODF 1.4. We can modify such tests so that the validation is skipped by using skipValidation(true). But this is unsatisfactory because it weakens the tests.Would it be an acceptable compromise to have tests for the strict odf 1.3, 1.4 and 1.4+libreoffice cases? I believe we have data under schema/ to do such testing if the validator cmdline gets adapted.
it should just need some variable in the test base class so a test can set which version it wants to validate against.
1.3+libreoffice sounds more complicated as our extended schema is only on top of 1.4.
one could just copy the 1.3+libreoffice schema from a previous git commit to a different directory and use that.
