New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
50 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1633173:  Error handling issues  (CHECKED_RETURN)
/sc/source/ui/miscdlgs/optsolver.cxx: 1241 in ScOptSolverDlg::CallSolver()()


________________________________________________________________________________________________________
*** CID 1633173:  Error handling issues  (CHECKED_RETURN)
/sc/source/ui/miscdlgs/optsolver.cxx: 1241 in ScOptSolverDlg::CallSolver()()
1235                 }
1236     
1237                 // Insert new sheet to the document and start writing the report
1238                 ScDocFunc &rFunc = mpDocShell->GetDocFunc();
1239                 rFunc.InsertTable(mnCurTab + 1, sNewTabName, false, false);
1240                 SCTAB nReportTab;
>>>     CID 1633173:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "GetTable" without checking return value (as is done elsewhere 54 out of 56 times).
1241                 mrDoc.GetTable(sNewTabName, nReportTab);
1242     
1243                 // Used to input data in the new sheet
1244                 ScAddress aOutputAddress(0, 0, nReportTab);
1245                 ScAddress::Details mAddressDetails(mrDoc, aOutputAddress);
1246                 AddressWalkerWriter aOutput(aOutputAddress, mpDocShell, mrDoc,

** CID 1633172:  Concurrent data access violations  (MISSING_LOCK)
/i18npool/source/search/textsearch.cxx: 1097 in TextSearch::ApproxSrchFrwrd(std::unique_lock<std::mutex> &, const rtl::OUString &, int, int)()


________________________________________________________________________________________________________
*** CID 1633172:  Concurrent data access violations  (MISSING_LOCK)
/i18npool/source/search/textsearch.cxx: 1097 in TextSearch::ApproxSrchFrwrd(std::unique_lock<std::mutex> &, const rtl::OUString &, int, int)()
1091         {
1092             if( aWBnd.startPos >= endPos )
1093                 break;
1094             nStt = aWBnd.startPos < startPos ? startPos : aWBnd.startPos;
1095             nEnd = std::min(aWBnd.endPos, endPos);
1096     
>>>     CID 1633172:  Concurrent data access violations  (MISSING_LOCK)
>>>     Accessing "this->pWLD" without holding lock "TextSearch.m_aMutex". Elsewhere, "TextSearch.pWLD" is written to with "TextSearch.m_aMutex" held 2 out of 2 times.
1097             if( nStt < nEnd &&
1098                     pWLD->WLD( searchStr.getStr() + nStt, nEnd - nStt ) <= nLimit )
1099             {
1100                 aRet.subRegExpressions = 1;
1101                 aRet.startOffset = { nStt };
1102                 aRet.endOffset = { nEnd };

** CID 1633171:  Concurrent data access violations  (MISSING_LOCK)
/i18npool/source/search/textsearch.cxx: 1139 in TextSearch::ApproxSrchBkwrd(std::unique_lock<std::mutex> &, const rtl::OUString &, int, int)()


________________________________________________________________________________________________________
*** CID 1633171:  Concurrent data access violations  (MISSING_LOCK)
/i18npool/source/search/textsearch.cxx: 1139 in TextSearch::ApproxSrchBkwrd(std::unique_lock<std::mutex> &, const rtl::OUString &, int, int)()
1133         {
1134             if( aWBnd.endPos <= endPos )
1135                 break;
1136             nStt = aWBnd.startPos < endPos ? endPos : aWBnd.startPos;
1137             nEnd = std::min(aWBnd.endPos, startPos);
1138     
>>>     CID 1633171:  Concurrent data access violations  (MISSING_LOCK)
>>>     Accessing "this->pWLD" without holding lock "TextSearch.m_aMutex". Elsewhere, "TextSearch.pWLD" is written to with "TextSearch.m_aMutex" held 2 out of 2 times.
1139             if( nStt < nEnd &&
1140                     pWLD->WLD( searchStr.getStr() + nStt, nEnd - nStt ) <= nLimit )
1141             {
1142                 aRet.subRegExpressions = 1;
1143                 aRet.startOffset = { nEnd };
1144                 aRet.endOffset = { nStt };


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DuioO_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtk17QsmiJiwR5SMPjHmR5lepz-2FKxmsuNMAmA6qPxbn5BzSL4duVBn-2FIdeucDIRcXjyw6dSAM6d4YU-2BtkSB6Md9UBGkqlAgS6NrRX9iwIddY33V8dJ-2FfkypqCUCcp7EL-2BlHwPGT5b-2F194OvymFVEAks9F3kB2I1aHtANds-2FSbyjyg-3D