New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

5 new defect(s) introduced to LibreOffice found with Coverity Scan.
6 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1620560:  Null pointer dereferences  (REVERSE_INULL)
/sc/source/ui/condformat/condformatdlgentry.cxx: 1289 in ScIconSetFrmtDataEntry::ScIconSetFrmtDataEntry(weld::Container *, ScIconSetType, const ScDocument *, int, const ScColorScaleEntry *)()


________________________________________________________________________________________________________
*** CID 1620560:  Null pointer dereferences  (REVERSE_INULL)
/sc/source/ui/condformat/condformatdlgentry.cxx: 1289 in ScIconSetFrmtDataEntry::ScIconSetFrmtDataEntry(weld::Container *, ScIconSetType, const ScDocument *, int, const ScColorScaleEntry *)()
1283     {
1284         // tdf#162948: Use ">" instead of ">=". Add some spaces to keep the alignment
1285         if (!pEntry->GetGreaterThanOrEqual())
1286             mxFtEntry->set_label(" >   ");
1287     
1288         mxImgIcon->set_from_icon_name(ScIconSetFormat::getIconName(eType, i));
>>>     CID 1620560:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "pEntry" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
1289         if(pEntry)
1290         {
1291             switch(pEntry->GetType())
1292             {
1293                 case COLORSCALE_VALUE:
1294                     mxLbEntryType->set_active(0);

** CID 1620559:  API usage errors  (INVALIDATE_ITERATOR)
/sd/source/ui/unoidl/unomodel.cxx: 614 in <unnamed>::AnimationsExporter::exportNodeImpl(const com::sun::star::uno::Reference<com::sun::star::animations::XAnimationNode> &)()


________________________________________________________________________________________________________
*** CID 1620559:  API usage errors  (INVALIDATE_ITERATOR)
/sd/source/ui/unoidl/unomodel.cxx: 614 in <unnamed>::AnimationsExporter::exportNodeImpl(const com::sun::star::uno::Reference<com::sun::star::animations::XAnimationNode> &)()
608     void AnimationsExporter::exportNodeImpl(const Reference<XAnimationNode>& xNode)
609     {
610         try
611         {
612             sal_Int16 nNodeType = xNode->getType();
613             auto iterator = constAnimationNodeTypeToString.find(nNodeType);
>>>     CID 1620559:  API usage errors  (INVALIDATE_ITERATOR)
>>>     Dereferencing iterator "iterator" though it is already past the end of its container.
614             mrWriter.put("nodeName", iterator->second);
615     
616             // common properties
617             OStringBuffer sTmp;
618             Any aTemp;
619             double fTemp = 0;

** CID 1620558:  Uninitialized members  (UNINIT_CTOR)
/sc/source/ui/view/tabvwshb.cxx: 519 in ScTabViewShell::ExecDrawIns(SfxRequest &)::[lambda(int) (instance 3)]::lambda(const [lambda(int) (instance 3)]&)()


________________________________________________________________________________________________________
*** CID 1620558:  Uninitialized members  (UNINIT_CTOR)
/sc/source/ui/view/tabvwshb.cxx: 519 in ScTabViewShell::ExecDrawIns(SfxRequest &)::[lambda(int) (instance 3)]::lambda(const [lambda(int) (instance 3)]&)()
513                     }
514     
515                     VclPtr<SfxAbstractLinksDialog> pDlg(pFact->CreateLinksDialog(pWin->GetFrameWeld(), rDoc.GetLinkManager()));
516                     auto xRequest = std::make_shared<SfxRequest>(rReq);
517                     rReq.Ignore(); // the 'old' request is not relevant any more
518                     pDlg->StartExecuteAsync(
>>>     CID 1620558:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "this" is not initialized in this constructor nor in any functions that it calls.
519                         [this, pDlg, xRequest=std::move(xRequest)] (sal_Int32 /*nResult*/)->void
520                         {
521                             GetViewFrame().GetBindings().Invalidate( SID_LINKS );
522                             SfxGetpApp()->Broadcast( SfxHint( SfxHintId::ScAreaLinksChanged ) );     // Navigator
523                             pDlg->disposeOnce();
524                             xRequest->Done();

** CID 1620557:  Uninitialized members  (UNINIT_CTOR)
/sc/source/ui/view/tabvwshb.cxx: 519 in ScTabViewShell::ExecDrawIns(SfxRequest &)::[lambda(int) (instance 3)]::lambda([lambda(int) (instance 3)]&&)()


________________________________________________________________________________________________________
*** CID 1620557:  Uninitialized members  (UNINIT_CTOR)
/sc/source/ui/view/tabvwshb.cxx: 519 in ScTabViewShell::ExecDrawIns(SfxRequest &)::[lambda(int) (instance 3)]::lambda([lambda(int) (instance 3)]&&)()
513                     }
514     
515                     VclPtr<SfxAbstractLinksDialog> pDlg(pFact->CreateLinksDialog(pWin->GetFrameWeld(), rDoc.GetLinkManager()));
516                     auto xRequest = std::make_shared<SfxRequest>(rReq);
517                     rReq.Ignore(); // the 'old' request is not relevant any more
518                     pDlg->StartExecuteAsync(
>>>     CID 1620557:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "this" is not initialized in this constructor nor in any functions that it calls.
519                         [this, pDlg, xRequest=std::move(xRequest)] (sal_Int32 /*nResult*/)->void
520                         {
521                             GetViewFrame().GetBindings().Invalidate( SID_LINKS );
522                             SfxGetpApp()->Broadcast( SfxHint( SfxHintId::ScAreaLinksChanged ) );     // Navigator
523                             pDlg->disposeOnce();
524                             xRequest->Done();

** CID 1620556:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/edit/textview.cxx: 158 in TextView::TextView(ExtTextEngine *, vcl::Window *)()


________________________________________________________________________________________________________
*** CID 1620556:  Uninitialized members  (UNINIT_CTOR)
/vcl/source/edit/textview.cxx: 158 in TextView::TextView(ExtTextEngine *, vcl::Window *)()
152     
153             pWindow->GetDragGestureRecognizer()->addDragGestureListener(mxDnDListener);
154             pWindow->GetDropTarget()->addDropTargetListener(mxDnDListener);
155             pWindow->GetDropTarget()->setActive( true );
156             pWindow->GetDropTarget()->setDefaultActions( css::datatransfer::dnd::DNDConstants::ACTION_COPY_OR_MOVE );
157         }
>>>     CID 1620556:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mbCursorAtEndOfLine" is not initialized in this constructor nor in any functions that it calls.
158     }
159     
160     TextView::~TextView()
161     {
162         mpSelEngine.reset();
163         mpSelFuncSet.reset();


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3D2qK5_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtg2L72eKOu4KOiVhx8Ln-2FXG10jCbHAICZP-2Bu152MSdHEewZx4iMUNWbS9VvgAtQZ-2BmQwWO7kCtBPrX9AWaX54cMD2UXQlku-2F-2FUC4R9S1DYTwC7whdFMBntxbz0NJgbRigJ-2FvSv387PRyaCbEqcN2MMWLnWbOGWDWI4iJJVS62hxg-3D