New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

5 new defect(s) introduced to LibreOffice found with Coverity Scan.
44 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1620500:  Uninitialized members  (UNINIT_CTOR)
/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx: 503 in DigitalSignaturesDialog::AddButtonHdlImpl()::[lambda(int) (instance 1)]::lambda([lambda(int) (instance 1)]&&)()


________________________________________________________________________________________________________
*** CID 1620500:  Uninitialized members  (UNINIT_CTOR)
/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx: 503 in DigitalSignaturesDialog::AddButtonHdlImpl()::[lambda(int) (instance 1)]::lambda([lambda(int) (instance 1)]&&)()
497         // Gpg signing is only possible with ODF >= 1.2 documents
498         if (DocumentSignatureHelper::CanSignWithGPG(maSignatureManager.getStore(), m_sODFVersion))
499             xSecContexts.push_back(maSignatureManager.getGpgSecurityContext());
500     
501         std::shared_ptr<CertificateChooser> aChooser = CertificateChooser::getInstance(m_xDialog.get(), m_pViewShell, std::move(xSecContexts), CertificateChooserUserAction::Sign);
502         aChooser->BeforeRun();
>>>     CID 1620500:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "this" is not initialized in this constructor nor in any functions that it calls.
503         weld::DialogController::runAsync(aChooser, [this, aChooser](sal_Int32 nRet) {
504             if (nRet != RET_OK)
505             {
506                 return;
507             }
508     

** CID 1620499:  Memory - illegal accesses  (UNINIT)


________________________________________________________________________________________________________
*** CID 1620499:  Memory - illegal accesses  (UNINIT)
/ucb/source/ucp/tdoc/tdoc_datasupplier.cxx: 284 in tdoc_ucp::ResultSetDataSupplier::totalCount(std::unique_lock<std::mutex> &)()
278         m_bCountFinal = true;
279     
280         rtl::Reference< ::ucbhelper::ResultSet > xResultSet = getResultSet();
281         if ( xResultSet.is() )
282         {
283             // Callbacks follow!
>>>     CID 1620499:  Memory - illegal accesses  (UNINIT)
>>>     Using uninitialized value "aGuard._M_owns" when calling "unlock".
284             aGuard.unlock();
285     
286             if ( nOldCount < m_aResults.size() )
287                 xResultSet->rowCountChanged( rResultSetGuard, nOldCount, m_aResults.size() );
288     
289             xResultSet->rowCountFinal(rResultSetGuard);

** CID 1620498:  Memory - illegal accesses  (UNINIT)


________________________________________________________________________________________________________
*** CID 1620498:  Memory - illegal accesses  (UNINIT)
/ucb/source/ucp/hierarchy/hierarchydatasupplier.cxx: 255 in hierarchy_ucp::HierarchyResultSetDataSupplier::totalCount(std::unique_lock<std::mutex> &)()
249         m_bCountFinal = true;
250     
251         rtl::Reference< ::ucbhelper::ResultSet > xResultSet = getResultSet();
252         if ( xResultSet.is() )
253         {
254             // Callbacks follow!
>>>     CID 1620498:  Memory - illegal accesses  (UNINIT)
>>>     Using uninitialized value "aGuard._M_owns" when calling "unlock".
255             aGuard.unlock();
256     
257             if ( nOldCount < m_aResults.size() )
258                 xResultSet->rowCountChanged(rResultSetGuard,
259                                         nOldCount, m_aResults.size() );
260     

** CID 1620497:  Memory - illegal accesses  (UNINIT)


________________________________________________________________________________________________________
*** CID 1620497:  Memory - illegal accesses  (UNINIT)
/ucb/source/ucp/package/pkgdatasupplier.cxx: 312 in package_ucp::DataSupplier::totalCount(std::unique_lock<std::mutex> &)()
306         m_bCountFinal = true;
307     
308         rtl::Reference< ::ucbhelper::ResultSet > xResultSet = getResultSet();
309         if ( xResultSet.is() )
310         {
311             // Callbacks follow!
>>>     CID 1620497:  Memory - illegal accesses  (UNINIT)
>>>     Using uninitialized value "aGuard._M_owns" when calling "unlock".
312             aGuard.unlock();
313     
314             if ( nOldCount < m_aResults.size() )
315                 xResultSet->rowCountChanged(rResultSetGuard,
316                                         nOldCount, m_aResults.size() );
317     

** CID 1620496:  Uninitialized members  (UNINIT_CTOR)
/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx: 503 in DigitalSignaturesDialog::AddButtonHdlImpl()::[lambda(int) (instance 1)]::lambda(const [lambda(int) (instance 1)]&)()


________________________________________________________________________________________________________
*** CID 1620496:  Uninitialized members  (UNINIT_CTOR)
/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx: 503 in DigitalSignaturesDialog::AddButtonHdlImpl()::[lambda(int) (instance 1)]::lambda(const [lambda(int) (instance 1)]&)()
497         // Gpg signing is only possible with ODF >= 1.2 documents
498         if (DocumentSignatureHelper::CanSignWithGPG(maSignatureManager.getStore(), m_sODFVersion))
499             xSecContexts.push_back(maSignatureManager.getGpgSecurityContext());
500     
501         std::shared_ptr<CertificateChooser> aChooser = CertificateChooser::getInstance(m_xDialog.get(), m_pViewShell, std::move(xSecContexts), CertificateChooserUserAction::Sign);
502         aChooser->BeforeRun();
>>>     CID 1620496:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "this" is not initialized in this constructor nor in any functions that it calls.
503         weld::DialogController::runAsync(aChooser, [this, aChooser](sal_Int32 nRet) {
504             if (nRet != RET_OK)
505             {
506                 return;
507             }
508     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3D0aaA_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGt3DsD1lJfwIAfpfwzq8vwTtg9DcrDqm1poUdKwLG1uairUsLUmFQV9CbY-2BPCUaDKzIyjbZKZK9ll5D4MFGk805vr882UkylapnQ-2BymNoVV9ld4Zl3eyKqrGSETUPT4GHzhdzzG59iJlKNU-2FjiRBh4DvliVmIvUvTgxZWdFt93wbA-3D