New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
56 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1618667:  Uninitialized members  (UNINIT_CTOR)
/package/source/zipapi/Inflater.cxx: 162 in ZipUtils::InflaterBytes::InflaterBytes(bool)()


________________________________________________________________________________________________________
*** CID 1618667:  Uninitialized members  (UNINIT_CTOR)
/package/source/zipapi/Inflater.cxx: 162 in ZipUtils::InflaterBytes::InflaterBytes(bool)()
156             case Z_STREAM_ERROR:
157                 pStream.reset();
158                 break;
159             default:
160                 break;
161         }
>>>     CID 1618667:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "sInBuffer" is not initialized in this constructor nor in any functions that it calls.
162     }
163     
164     InflaterBytes::~InflaterBytes()
165     {
166         end();
167     }

** CID 1618666:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/sw/inc/contentindex.hxx: 47 in ()


________________________________________________________________________________________________________
*** CID 1618666:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/sw/inc/contentindex.hxx: 47 in ()
41     public:
42         virtual ~ISwContentIndexOwner();
43         virtual SwContentIndexOwnerType GetOwnerType() const = 0;
44     };
45     
46     /// Marks a character position inside a document model content node (SwContentNode)
>>>     CID 1618666:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "SwContentIndex" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalues, where a move assignment may be faster.
47     class SAL_WARN_UNUSED SW_DLLPUBLIC SwContentIndex
48     {
49     private:
50         friend class SwContentIndexReg;
51     
52         sal_Int32 m_nIndex;

** CID 1618665:  Memory - illegal accesses  (UNINIT)


________________________________________________________________________________________________________
*** CID 1618665:  Memory - illegal accesses  (UNINIT)
/sfx2/source/control/thumbnailviewacc.cxx: 518 in ThumbnailViewAcc::FireAccessibleEvent(short, const com::sun::star::uno::Any &, const com::sun::star::uno::Any &)()
512     {
513         if( !nEventId )
514             return;
515     
516         std::unique_lock aGuard(m_aMutex);
517         ::std::vector< uno::Reference< accessibility::XAccessibleEventListener > > aTmpListeners( mxEventListeners );
>>>     CID 1618665:  Memory - illegal accesses  (UNINIT)
>>>     Using uninitialized value "aGuard._M_owns" when calling "unlock".
518         aGuard.unlock();
519         accessibility::AccessibleEventObject aEvtObject;
520     
521         aEvtObject.EventId = nEventId;
522         aEvtObject.Source = getXWeak();
523         aEvtObject.NewValue = rNewValue;

** CID 1618664:  Incorrect expression  (NO_EFFECT)
/package/source/zipapi/ZipFile.cxx: 1622 in ZipFile::HandlePK34(std::span<const signed char, (unsigned long)-1>, long, long)()


________________________________________________________________________________________________________
*** CID 1618664:  Incorrect expression  (NO_EFFECT)
/package/source/zipapi/ZipFile.cxx: 1622 in ZipFile::HandlePK34(std::span<const signed char, (unsigned long)-1>, long, long)()
1616         {
1617             std::vector<sal_Int8> aFileName(aEntry.nPathLen);
1618             aGrabber.seek(dataOffset + 30);
1619             aGrabber.readBytes(aFileName.data(), aEntry.nPathLen);
1620             aEntry.sPath = OUString(reinterpret_cast<const char*>(aFileName.data()),
1621                                     aEntry.nPathLen, RTL_TEXTENCODING_UTF8);
>>>     CID 1618664:  Incorrect expression  (NO_EFFECT)
>>>     Assigning "aEntry.nPathLen" to itself has no effect.
1622             aEntry.nPathLen = aEntry.nPathLen;
1623         }
1624         aEntry.sPath = aEntry.sPath.replace('\\', '/');
1625     
1626         // read 64bit header
1627         if (aEntry.nExtraLen > 0)


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DbhbR_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtPbme9l4-2FPCi-2BNJjZgRSZiN8yXvcR1CWZOotVP5v2aIMwvZrVQFny8g4SHK-2BOuUKqGCjJMKpMT4B7AkI4UpFDyYjkUUE991mLlHXJ1-2FfFGpOorVShaRffkx3pHbtkibGTNbISbXvL4cRxsGGt206-2BpvsDtJ-2BBjy8oskB5L11NBl8-3D