New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
48 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1616525:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sd/source/ui/func/fuoaprms.cxx: 451 in sd::FuObjectAnimationParameters::DoExecute(SfxRequest &)()


________________________________________________________________________________________________________
*** CID 1616525:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sd/source/ui/func/fuoaprms.cxx: 451 in sd::FuObjectAnimationParameters::DoExecute(SfxRequest &)()
445             std::shared_ptr<SfxRequest> xRequest = std::make_shared<SfxRequest>(rReq);
446             rReq.Ignore(); // the 'old' request is not relevant any more
447     
448             SdAbstractDialogFactory* pFact = SdAbstractDialogFactory::Create();
449             VclPtr<SfxAbstractDialog> pDlg( pFact->CreatSdActionDialog(mpViewShell->GetFrameWeld(), &*aSet, mpView) );
450             rtl::Reference<FuObjectAnimationParameters> xThis( this ); // avoid destruction within async processing
>>>     CID 1616525:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "xRequest" is copied in call to copy constructor "std::shared_ptr<SfxRequest>", when it could be moved instead.
451             pDlg->StartExecuteAsync([pDlg, xThis, xRequest, aSet](sal_Int32 nResult){
452                 if (nResult == RET_OK) {
453                     xThis->Finish(xRequest, pDlg);
454                 }
455                 pDlg->disposeOnce();
456             });

** CID 1616524:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sd/source/ui/func/fuoaprms.cxx: 451 in sd::FuObjectAnimationParameters::DoExecute(SfxRequest &)()


________________________________________________________________________________________________________
*** CID 1616524:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/sd/source/ui/func/fuoaprms.cxx: 451 in sd::FuObjectAnimationParameters::DoExecute(SfxRequest &)()
445             std::shared_ptr<SfxRequest> xRequest = std::make_shared<SfxRequest>(rReq);
446             rReq.Ignore(); // the 'old' request is not relevant any more
447     
448             SdAbstractDialogFactory* pFact = SdAbstractDialogFactory::Create();
449             VclPtr<SfxAbstractDialog> pDlg( pFact->CreatSdActionDialog(mpViewShell->GetFrameWeld(), &*aSet, mpView) );
450             rtl::Reference<FuObjectAnimationParameters> xThis( this ); // avoid destruction within async processing
>>>     CID 1616524:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "aSet" is copied in call to copy constructor "std::shared_ptr<SfxItemSet>", when it could be moved instead.
451             pDlg->StartExecuteAsync([pDlg, xThis, xRequest, aSet](sal_Int32 nResult){
452                 if (nResult == RET_OK) {
453                     xThis->Finish(xRequest, pDlg);
454                 }
455                 pDlg->disposeOnce();
456             });


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DhTOZ_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtnqWXxPXlLn3YNI6iNrL3K7kAeNm13n8RFXsarRkF86pJM0s6aEnlRNwVifqz5yyT-2BK5Ull2I1gbCLA3pxB-2FU3czg7-2FgoR8F5gJZreU18fXo2bJp89U-2BbVP8xZyjJlwDijOhfhg9LF7-2F-2FBxKcm-2BH8mT5SOBxy3rcw5LjdfkshJko-3D