On Sat, 2024-08-17 at 00:57 -0400, Al Schapira wrote: > On Sat, 2024-08-17 at 00:24 +0000, Dr. David Alan Gilbert wrote: > > * Al Schapira (a_schapira@xxxxxxxxxxx) wrote: > > > On Fri, 2024-08-16 at 21:53 +0500, Mike Kaganski wrote: > > > > On 16.08.2024 21:52, Al wrote: > > > > > On Mon, 2024-08-12 at 16:18 -0400, Al Schapira wrote: > > > > > > With reference to libreoffice bug 162342 ("RTF input fails > > > > > > to > > > > > > honor > > > > > > \marg[lrtb]N commands when a \page command is added") > > > > > > On Tue, 2024-08-13 at 10:44 +0500, Mike Kaganski wrote: > > > > > > Regarding import, you may start at the heart of RTF keyword > > > > > > dispatch > > > > > > method, RTFTokenizer::dispatchKeyword: > > > > > > https://opengrok.libreoffice.org/xref/core/sw/source/writerfilter/rtftok/rtftokenizer.cxx?r=246ef0b8#261 > > > > > > > > > > > Thanks for the pointer, Mike. I think this is way too deep > > > > > to > > > > > be > > > > > relevant to the afore mentioned bug. The problem rtf file > > > > > renders > > > > > correctly in libreoffice 7.3.7.2 under windows 10.0, but > > > > > fails > > > > > to > > > > > render margins correctly in LibreOffice 7.6.7.2 60(Build:2) > > > > > in > > > > > fedora > > > > > 39 & 40. > > > > > > > > > > So what in rtf import code might differ between these > > > > > environments? > > > > > Where should I look for OS dependencies that might affect rtf > > > > > import? > > > > > > > > > > > > https://bibisect.libreoffice.org/ > > > > > > > I'm flying blind wrt bibisect (and git). However I did > > > clone git clone > > > https://bibisect.libreoffice.org/linux-64-7.4.git > > > and got a version of soffice that renders rtf margins properly!! > > > > > > ads@ADS4:~/Downloads/libreoffice/linux-64-7.4/instdir/program > > > $ ./soffice --version > > > LibreOfficeDev 7.4.8.0.0 f8ba7c6f77497e2dc7bfef8378511e2074ce01f9 > > > works! > > > > > > But my LO 7.6.7.2 fails. Is this info of use > > > > Yes, add it to the bug. > > > > > to the assignee? > > > > Note there isn't an assignee yet! So you're the only person > > looking > > at this so far. > > > > > > > > Now what? > > > > You know 7.6.7.2 is bad, and 7.4.8 is good. > > > > How about 7.5 ? > > > > Ideally with bibisect you can get down to just a few versions and > > then we can go and hunt back to if there were any interesting > > RTF changes in there. > > > > Dave > > > > > Thanks. > > > > > > --Al > > > > > > > Progress: 7.5.10.0.0 works fine too. > > ads@ADS4:~/Downloads/libreoffice/linux-64-7.5/instdir/program$ > ./soffice --version > LibreOfficeDev 7.5.10.0.0 fb2e54db5d3278d53cdef1e44646967467964704 > > Now what? > > Thanks. > > --Al > I took the leap and cloned 7.6 and it has the rtf margin bug!! ads@ADS4:~/Downloads/libreoffice/linux-64-7.6/instdir/program$ ./soffice --version LibreOfficeDev 7.6.8.0.0 3a0801282a0aabc64a15f9afc3aedeac6226a979 So the bug was introduced between 7.5.10.0.0 and 7.6.8.0.0. (released version 7.6.7.2 fails too.) Now I hope someone more knowledgeable than me can pinpoint the failure and fix it. Thanks. --Al