ESC meeting minutes: 2024-08-15

[Miklos Vajna <vmiklos@xxxxxxxxxxxxx>]

* Present:
    + Hossein, Jonathan, Stephan, Ilmari, Heiko, Caolan, Olivier, Michael S, Eike, Miklos

* Completed Action Items:

* Pending Action Items:
  + perf.libreoffice.org: switch the default to the new data (Cloph)

* Release Engineering update (Cloph)
  + 24.8.0 to be announced as final next week
  + 24.8.1 rc1 next week
  + 24.2.6 rc1 tagging/creating the branch tomorrow

* Documentation (Olivier)
    + Helpcontents
       + Updates, fixes and improvements (ohallot, Pierre F, erack, D. Maddern, Ilmari)
    + Guides
       + Work in progress

    + Bugzilla Documentation statistics
        235(235) bugs open
    + Updates:
        BZ changes   1 week    1 month   3 months   12 months
           created     23(-4)    58(13)    102(7)     237(8)
         commented     36(9)     97(22)    263(17)    869(22)
          resolved      8(-12)   33(6)      66(3)     152(8)
    + top 10 contributors:
          Pierre F made 66 changes in 1 month, and 102 changes in 1 year
          Olivier Hallot made 52 changes in 1 month, and 300 changes in 1 year
          Dione Maddern made 46 changes in 1 month, and 57 changes in 1 year
          Henschel, Regina made 8 changes in 1 month, and 20 changes in 1 year
          Ilmari Lauhakangas made 6 changes in 1 month, and 98 changes in 1 year
          Kaganski, Mike made 6 changes in 1 month, and 81 changes in 1 year
          Roman Kuznetsov made 5 changes in 1 month, and 10 changes in 1 year
          Cor Nouws made 5 changes in 1 month, and 15 changes in 1 year
          Weghorn, Michael made 5 changes in 1 month, and 13 changes in 1 year
          Alain Romedenne made 4 changes in 1 month, and 16 changes in 1 year

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        233(233) (topicUI) bugs open, 29(29) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
             added      6(2)      8(1)      9(1)       17(1)
         commented     51(13)   152(3)    424(-9)    1762(16)
           removed      0(0)      0(0)      2(0)       10(0)
          resolved      6(-5)    33(3)     77(-2)     288(0)
    + top 10 contributors:
          Heiko Tietze made 76 changes in 1 month, and 974 changes in 1 year
          Eyal Rozenberg made 55 changes in 1 month, and 193 changes in 1 year
          Stéphane Guillou made 31 changes in 1 month, and 587 changes in 1 year
          Vernon, Stuart Foote made 25 changes in 1 month, and 340 changes in 1 year
          Roman Kuznetsov made 16 changes in 1 month, and 36 changes in 1 year
          Rafael Lima made 14 changes in 1 month, and 73 changes in 1 year
          Justin Luth made 10 changes in 1 month, and 70 changes in 1 year
          Henschel, Regina made 9 changes in 1 month, and 42 changes in 1 year
          kolAflash made 8 changes in 1 month, and 12 changes in 1 year
          m.a.riosv made 8 changes in 1 month, and 46 changes in 1 year
    + [Bug 162475] Allow adding condition for format in manage dialog
    + [Bug 162450] Hide sidebar tabs
 => + [Bug 162424] Ability to assign comments to a different author
 => + [Bug 162423] Ability to assign tracked change to different author
    + [Bug 162417] PIVOTTABLE: Warning does not show range when overwriting
           destination range contents
    + [Bug 162420] Add deck with choice of slide layouts to the sidebar
    + [Bug 162394] Writer: Dark Mode: better colors for canvas / document,
           background and comment column

* Crash Testing (Caolan)
    + 16(-42) import failure, 13(-2) export failures
    + 722 coverity issues
    + 4 ossfuzz: ?? fuzzers active now

* Crash Reporting (Xisco)
    + 24.2.2.2    19775(+402)
    + 24.2.3.2    17526(+553)
    + 24.2.4.2    13120(+726)
    + 24.2.5.2    8002(+2461)

* Mentoring (Hossein)
 + Reviewed
 + Finalized and published a blog post on dev blog
   Extending the UNO API
   https://dev.blog.documentfoundation.org/2024/08/15/extending-uno-api/
 + Added a new Wiki page for
   + WSL, building Linux binaries and running on Windows
     + build/debug is straightforward, VSCode IDE is usable for debugging
     https://wiki.documentfoundation.org/Development/BuildingOnWSL
   + We need a manual for the WSL for building Windows version
   + MinGW as a helper might be possible
     https://gerrit.libreoffice.org/c/core/+/171880
   + latest cygwin has issues for our use-case, so alternatives are important (be it mingw or wsl)
          committer...   1 week     1 month      3 months    12 months
                  open      81(-8)     170(-11)     173(-10)     173(-10)
               reviews     456(6)     1528(-64)    3832(60)    13210(46)
                merged     222(-10)   1106(-116)   3467(-82)   12945(-13)
             abandoned      17(-8)      89(-1)      230(2)       777(6)
           own commits     177(24)     796(-49)    2354(-62)    9463(25)
        review commits      46(-18)    226(-5)      763(10)     3097(8)
        contributor...   1 week     1 month      3 months     12 months
                  open      52(4)      111(2)       114(3)        114(3)
               reviews     758(-18)   3022(-190)   8016(-122)   29992(0)
                merged      24(-3)      98(11)      282(7)       1515(13)
             abandoned       9(5)       40(-1)       93(9)        745(7)
           own commits      21(-15)    106(-1)      338(8)       1256(14)
        review commits       0(0)        0(0)         0(0)          0(0)
    + easyHack statistics:
       needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 327(327)
       total 412(412)   assigned 24(24)   open 353(353)
    + top 10 contributors:
          Pierre F made 30 patches in 1 month, and 62 patches in 1 year
            made 18 patches in 1 month, and 28 patches in 1 year
          Dione Maddern made 7 patches in 1 month, and 74 patches in 1 year
          Ritobroto Mukherjee made 5 patches in 1 month, and 27 patches in 1 year
          Bogdan B made 4 patches in 1 month, and 88 patches in 1 year
          Adam Seskunas made 4 patches in 1 month, and 20 patches in 1 year
          Weblate made 3 patches in 1 month, and 36 patches in 1 year
          Kira Tubo made 3 patches in 1 month, and 20 patches in 1 year
          vivek javiya made 2 patches in 1 month, and 11 patches in 1 year
          Devansh Varshney made 2 patches in 1 month, and 7 patches in 1 year
    + top 10 reviewers:
          Thorsten Behrens made 174 review comments in 1 month, and 740 in 1 year
          Adolfo Jayme Barrientos made 162 review comments in 1 month, and 748 in 1 year
          Caolán McNamara made 126 review comments in 1 month, and 1448 in 1 year
          Vajna, Miklos made 100 review comments in 1 month, and 1178 in 1 year
          Michael Stahl made 90 review comments in 1 month, and 842 in 1 year
          Christian Lohmaier made 66 review comments in 1 month, and 496 in 1 year
          Kaganski, Mike made 62 review comments in 1 month, and 490 in 1 year
          Nabet, Julien made 62 review comments in 1 month, and 940 in 1 year
          Hossein made 58 review comments in 1 month, and 330 in 1 year
          Heiko Tietze made 54 review comments in 1 month, and 276 in 1 year
    + Patches automatically abandoned:
        tdf#143123 Port MessageBox Java SDK example to Python ( Toe Arkar )
            -> Not complete
            - https://gerrit.libreoffice.org/#/c/162584
        tdf#132007 improve password message locked document ( Devansh Varshney )
            -> Has issues, needs work from the author
            - https://gerrit.libreoffice.org/#/c/163924
        Improvement to conditional formatting naming ( Caolán McNamara )
            - https://gerrit.libreoffice.org/#/c/168445
        Use less SdOptionsMisc->IsStartWithTemplate/SetStartWithTemplate ( Gabor Kelemen )
            - https://gerrit.libreoffice.org/#/c/168459
        JunitTest_framework_complex: re-enable some tests ( Xisco Fauli )
            - https://gerrit.libreoffice.org/#/c/168691
        JunitTest_framework_complex: re-enable some more tests ( Xisco Fauli )
            - https://gerrit.libreoffice.org/#/c/168692
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Panagiotis Evaggelou

* GSoC (Ilmari)
  + 26 August is the deadline for final code submissions in non-extended projects
    + period starts next week

* LiboCon (Cloph)
  + CfP is open: https://events.documentfoundation.org/libreoffice-conference-2024/cfp
    + 2024-08-30 11:52 (UTC) is the deadline

* Commit Access
  + Vivek Javiya (vivek.javiya@xxxxxxxxxxxxx) - sponsored by Tomaž Vajngerl
    + Collabora still plans to review his changes, this is more about cherry-picking between branches (Miklos)
    + some 11 commits so far (older ones under codewithvk)
AI: Cloph to enable the commit bit
AI: Miklos to send the new committer mail

* Developer Certification (Stephan/Miklos/László/Gabriel)
  + resting since: 15 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
gerrit_android_aarch64     jobs: 182 ok: 171 ko:   7 fail ratio: 3.85% mean_ok:  10 ( 18) median_ok:   8 ( 13)
gerrit_android_arm         jobs: 183 ok: 172 ko:   7 fail ratio: 3.83% mean_ok:  11 ( 17) median_ok:   9 ( 12)
gerrit_android_x86         jobs: 184 ok: 172 ko:   8 fail ratio: 4.35% mean_ok:  11 ( 18) median_ok:   7 ( 12)
gerrit_android_x86_64      jobs: 184 ok: 176 ko:   5 fail ratio: 2.72% mean_ok:  11 ( 17) median_ok:   8 ( 11)
gerrit_linux_clang_dbgutil jobs: 376 ok: 301 ko:  63 fail ratio: 16.76% mean_ok:  51 ( 56) median_ok:  49 ( 51)
gerrit_linux_gcc_release   jobs: 454 ok: 355 ko:  70 fail ratio: 15.42% mean_ok:  25 ( 30) median_ok:  19 ( 22)
gerrit_mac                 jobs: 369 ok: 332 ko:  23 fail ratio: 6.23% mean_ok:  55 ( 58) median_ok:  48 ( 49)
gerrit_windows             jobs: 405 ok: 279 ko: 110 fail ratio: 27.16% mean_ok:  67 ( 76) median_ok:  64 ( 68)
gerrit_master_ml           jobs: 496 ok: 240 ko: 217 fail ratio: 43.75% mean_ok: 106 (106) median_ok: 101 (102)
gerrit_master              jobs:  49 ok:  20 ko:  16 fail ratio: 32.65% mean_ok:  77 ( 77) median_ok:  73 ( 73)
gerrit_master_seq          jobs: 449 ok: 221 ko: 202 fail ratio: 44.99% mean_ok: 107 (108) median_ok: 103 (103)
   + tests that failed more than twice in last seven days
      3 CppunitTest_sw_layoutwriter2                gerrit_windows
      3 CppunitTest_sw_rtfexport3                gerrit_linux_gcc_release
      3 JunitTest_sd_unoapi                gerrit_linux_clang_dbgutil
      3 JunitTest_toolkit_unoapi_4                gerrit_linux_clang_dbgutil
      4 CppunitTest_sd_tiledrendering                gerrit_linux_gcc_release
      4 CppunitTest_services                gerrit_linux_gcc_release
      9 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
     11 CppunitTest_sw_ww8export4                gerrit_linux_gcc_release
     19 CppunitTest_sd_png_export_tests                gerrit_windows (newly introduced test repeatedly fails on a single/specifc bot)
     + specific to a single builder
     42 aborted by jenkins job timeout                gerrit_windows (if a bot fails, it fails repeatedly)
   + overall windows builds seem "wonkier" - more cases of cygwin failing to create processes / more need for manual intervention clicking away the dialogs, also more likely to run into (and stay) in some broken state where builds don't fail but instead time out - cause unclear

* What’s cooking (Miklos)
   + A11y update (Michael W)
   + RTL/CTL/CJK update (Jonathan)
      + tdf#36709: First line indent using Ch should change for font size
         + https://bugs.documentfoundation.org/show_bug.cgi?id=36709
         + Referred to ODF TC for comments
      + tdf#156211: sw: Spurious kashida after undo/redo
         + https://bugs.documentfoundation.org/show_bug.cgi?id=156211
         + Fixed
      + tdf#141466: sw: Asian Phonetic Guide dialog produces incorrect base text
         + https://bugs.documentfoundation.org/show_bug.cgi?id=141466
         + In progress
   + Cairo SDPR: more progress last week, see the "CairoSDPR" commits (Armin)

* QA update (Xisco)
    + UNCONFIRMED: 1245 (+18)
        + enhancements: 289  (+1)
        + needsUXEval: 7 (+0)
        + haveBackTrace: 9 (+0)
        + needsDevAdvice: 46 (-1)
        + documentation:  6 (+2)
        + android:  0 (+0)
        + iOS:  0 (+0)
        + Online:  9 (+0)



    + Most pressing bugs:
     New:
     Old:
     Fixed:


    + New high severity bugs of the week:
        + Add UI Configuration Option To Disable Showing Hidden Filter Elements As Inactive In Autofilter
            + https://bugs.documentfoundation.org/show_bug.cgi?id=158733
            + not tagged as a regression

* gerrit notifications (Caolan)
  + when cherry-picking from master to a branch, we spam former reviewers, that's not wanted
  + git push logerrit HEAD:refs/for/branchname%notify=OWNER (Michael S)
    + there's no way to prevent gerrit from adding everyone as reviewer or cc unfortunately
  + git-review has a similar option: git review --notify OWNER (Miklos)

* QA stats (Xisco)
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +79  +23 (-91) overall)
      many thanks to the top bug squashers:
       QA Administrators       10
       Buovjaga                7
       Mike Kaganski           7
       Heiko Tietze            6
       Gabor Kelemen (allotropia) 5
       V Stuart Foote          5
       Dione Maddern           4
       Olivier Hallot          4
       Caolán McNamara         3
       Eyal Rozenberg          3

    + top 10 bugs reporters:
       Eyal Rozenberg          7
       Mike Kaganski           3
       fpy                     3
       Bogaboga Man            2
       Heiko Tietze            2
       Michael Weghorn         2
       Rafael Lima             2
       nobu                    2
       Callegar                1
       DM                      1

    + top 10 bugs fixers:
       Kelemen, Gabor          4
       Olivier Hallot          4
       Caolán McNamara         3
       Dione Maddern           3
       Kaganski, Mike          3
       Heiko Tietze            2
       Jim Raykowski           2
       Jonathan Clark          2
       Patrick Luby            2
       Weghorn, Michael        2

    + top 10 bugs confirmers:
       Heiko Tietze            4
       Ady                     3
       Dieter                  3
       m.a.riosv               3
       Aron Budea              2
       Bogdan B                2
       Ilmari Lauhakangas      2
       Kaganski, Mike          2
       Nabet, Julien           2
       Olivier Hallot          2


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Ilmari Lauhakangas    12
        Steve271               1
        Weghorn, Michael       1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Ilmari Lauhakangas    17
        Steve271               1
        Kelemen, Gabor         1
        Weghorn, Michael       1


* all bugs tagged with 'regression'
   + 1208(-12) bugs open of 13539(+3) total 24(+2) high prio.

     done by:
        Ilmari Lauhakangas     3
        Ady                    1
        Kelemen, Gabor         1
        Lars Jødal             1
        Weghorn, Michael       1
        m.a.riosv              1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 11(+1)
     Calc          - 6(+1)
     Impress       - 2(+0)
     LibreOffice   - 2(+0)
     UI            - 2(+0)

   by OS:
     All           - 15(+2)
     Linux         - 6(+0)
     Mac OS X      - 0(+0)
     Windows       - 3(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 387(-12)
     Calc                     - 240(+4)
     Impress                  - 126(+0)
     LibreOffice              - 52(+0)
     Draw                     - 48(+1)
     Crashes                  - 46(+1)
     Writer: docx filter      - 45(+0)
     Base                     - 39(-1)
     UI                       - 37(-1)
     Borders                  - 34(+0)
     Writer: perf             - 34(-2)
     Writer: other filter     - 32(+0)
     Printing and PDF export  - 26(-1)
     Chart                    - 24(+0)
     RTL                      - 23(+0)
     BASIC                    - 20(+0)
     filters and storage      - 20(-1)
     Writer: doc filter       - 17(+0)
     graphics stack           - 12(+0)
     Formula Editor           - 10(+0)
     framework                - 3(+0)
     Extensions               - 2(+0)
     sdk                      - 2(+0)
     Linguistic               - 1(+0)