New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
126 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1615139:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1615139:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/core/txtnode/fntcache.cxx: 2297 in SwDrawTextInfo::ApplyAutoColor(vcl::Font *)()
2291                     else
2292                         // we take the font color from the appearance page
2293                         nNewColor = pViewOption->GetFontColor();
2294                 }
2295     
2296                 // change painting color depending of dark/bright background
>>>     CID 1615139:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "pVSh" to "GetWin", which dereferences it.
2297                 if (!pVSh->GetWin() || // ie. IsPrinting, see SwViewShell::GetWin()
2298                     svtools::ColorConfig().GetColorValue(svtools::FONTCOLOR, false).nColor == COL_AUTO) // GetFontColor() uses the smart flag
2299                 {
2300                     if ( pCol->IsDark() )
2301                         nNewColor = COL_WHITE;
2302                     else

** CID 1615138:  Performance inefficiencies  (AUTO_CAUSES_COPY)
/sw/source/uibase/utlui/content.cxx: 6933 in SwContentTree::BringEntryToAttention(const weld::TreeIter &)()


________________________________________________________________________________________________________
*** CID 1615138:  Performance inefficiencies  (AUTO_CAUSES_COPY)
/sw/source/uibase/utlui/content.cxx: 6933 in SwContentTree::BringEntryToAttention(const weld::TreeIter &)()
6927                 {
6928                     std::vector<const SwTextAttr*> aTextAttrArr;
6929                     ItemSurrogates aSurrogates;
6930                     m_pActiveShell->GetAttrPool().GetItemSurrogates(aSurrogates, RES_TXTATR_REFMARK);
6931                     for (const SfxPoolItem* pItem : aSurrogates)
6932                     {
>>>     CID 1615138:  Performance inefficiencies  (AUTO_CAUSES_COPY)
>>>     Using the "auto" keyword without an "&" causes the copy of an object of type "SwFormatRefMark".
6933                         const auto rRefMark = static_cast<const SwFormatRefMark&>(*pItem);
6934                         const SwTextRefMark* pTextRef = rRefMark.GetTextRefMark();
6935                         if (pTextRef && &pTextRef->GetTextNode().GetNodes() ==
6936                                 &m_pActiveShell->GetNodes())
6937                             aTextAttrArr.push_back(pTextRef);
6938                     }

** CID 1615137:  API usage errors  (LOCK)


________________________________________________________________________________________________________
*** CID 1615137:  API usage errors  (LOCK)
/chart2/source/tools/HistogramDataSequence.cxx: 46 in chart::HistogramDataSequence::~HistogramDataSequence()()
40     {
41         registerProperty(u"Role"_ustr, PROP_PROPOSED_ROLE,
42                          0, // PropertyAttributes
43                          &m_sRole, cppu::UnoType<decltype(m_sRole)>::get());
44     }
45     
>>>     CID 1615137:  API usage errors  (LOCK)
>>>     "~OPropertyContainer2" uses "this->m_aMutex" in an uninitialized state.
46     HistogramDataSequence::~HistogramDataSequence() {}
47     
48     IMPLEMENT_FORWARD_XINTERFACE2(HistogramDataSequence, HistogramDataSequence_Base,
49                                   comphelper::OPropertyContainer2)
50     
51     IMPLEMENT_FORWARD_XTYPEPROVIDER2(HistogramDataSequence, HistogramDataSequence_Base,

** CID 1615136:  Uninitialized members  (UNINIT_CTOR)
/sfx2/source/doc/guisaveas.cxx: 361 in ModelData_Impl::ModelData_Impl(SfxStoringHelper &, com::sun::star::uno::Reference<com::sun::star::frame::XModel>, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> &)()


________________________________________________________________________________________________________
*** CID 1615136:  Uninitialized members  (UNINIT_CTOR)
/sfx2/source/doc/guisaveas.cxx: 361 in ModelData_Impl::ModelData_Impl(SfxStoringHelper &, com::sun::star::uno::Reference<com::sun::star::frame::XModel>, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> &)()
355     : m_pOwner( &aOwner )
356     , m_xModel(std::move( xModel ))
357     , m_aMediaDescrHM( aMediaDescr )
358     , m_bRecommendReadOnly( false )
359     {
360         CheckInteractionHandler();
>>>     CID 1615136:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_bSignWithDefaultSignature" is not initialized in this constructor nor in any functions that it calls.
361     }
362     
363     
364     ModelData_Impl::~ModelData_Impl()
365     {
366         FreeDocumentProps();


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu6VvXBlQRUbS683tC8265rGNPXqJ1ffcoLZCnTuJFQbNcTEkb4XaEQkzovKhJ5DB3c-3DjDzD_A9M4dSy7guk8NP6DcfgslOyvJRzavztVIKj6nRqYjYpWom7SJFyX0y710bz0kUGtX8wVS0n63mr4zxUIH8yWPqxHQXKM3JX0G5N29AFsbOyfIQPcec00TAieMTPhnkLgwCASSpZZVBSGm7TtnXnp8BukAfZ7KYSxlP61491TIsXh0NM-2FZKm3dUEaVhujSY97lO7ap6LOA-2FSfwaN-2FgarSFLlrWfKqm8arJ5gKXZubmyU-3D