ESC meeting minutes: 2024-06-20

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Present:
    + Olivier, Cloph, Hossein, Ilmari, Jonathan, Michael W, Michael S, Regina, Stephan, Heiko, Thorsten, Miklos, Xisco

* Completed Action Items:

* Pending Action Items:

* Release Engineering update (Cloph)
    + 24.2: 24.2.5 RC1 in 1 week
    + 24.8:
        + beta2 this week, if needed -> so far no requests, so will be skipped
        + string / UI freeze in 2 weeks
        + late features?
          + late addition to the notes page in Impress in the works (Thorsten)
    + feedback on Windows 7 vs Python 3.newer (Cloph)
      + rest of the office works nicely, except actual Python functionality
      + fails gracefull, so no need to take any action at this moment

* Documentation (Olivier)
    + New Help
       + Links to documentation in Help pages (ohallot)
    + Helpcontents2
       + Updates and fixes (ohallot, D. Maddern)
    + Guides
       + Published Impress guide + post
    + Bugzilla Documentation statistics
        252(252) bugs open
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
           created     10(3)    43(-5)    101(-2)    234(1)
         commented     22(10)   91(-9)    237(4)     896(-2)
          resolved      3(1)    23(-3)     63(1)     134(0)
    + top 10 contributors:
          Dione Maddern made 56 changes in 1 month, and 100 changes in 1 year
          Olivier Hallot made 44 changes in 1 month, and 269 changes in 1 year
          Vernon, Stuart Foote made 15 changes in 1 month, and 121 changes in 1 year
          Ilmari Lauhakangas made 12 changes in 1 month, and 81 changes in 1 year
          Heiko Tietze made 11 changes in 1 month, and 83 changes in 1 year
          Stéphane Guillou made 9 changes in 1 month, and 223 changes in 1 year
          Kaganski, Mike made 8 changes in 1 month, and 79 changes in 1 year
          Justin Luth made 6 changes in 1 month, and 8 changes in 1 year
          Timur made 6 changes in 1 month, and 8 changes in 1 year
          Bogdan B made 4 changes in 1 month, and 13 changes in 1 year

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        239(239) (topicUI) bugs open, 38(38) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
             added      5(2)     12(1)     16(0)       24(1)
         commented     37(-4)   189(-5)   504(-10)   1756(25)
           removed      2(2)      2(2)      7(2)       12(2)
          resolved      6(3)     28(0)     80(1)      285(-4)
    + top 10 contributors:
          Heiko Tietze made 128 changes in 1 month, and 964 changes in 1 year
          Stéphane Guillou made 104 changes in 1 month, and 659 changes in 1 year
          Eyal Rozenberg made 25 changes in 1 month, and 156 changes in 1 year
          Dieter made 23 changes in 1 month, and 149 changes in 1 year
          Vernon, Stuart Foote made 22 changes in 1 month, and 310 changes in 1 year
          Telesto made 12 changes in 1 month, and 35 changes in 1 year
          Ilmari Lauhakangas made 10 changes in 1 month, and 131 changes in 1 year
          *UNKNOWN* made 9 changes in 1 month, and 12 changes in 1 year
          Henschel, Regina made 9 changes in 1 month, and 41 changes in 1 year
          Kaganski, Mike made 6 changes in 1 month, and 80 changes in 1 year
 -> + [Bug 161641] CTRL+A should select only the closest range of cells filled
           with data
           + https://gerrit.libreoffice.org/c/core/+/169276
           + if it's too controversial, may need to add a setting to keep the unchanged behavior as well
    + [Bug 157684] Add option to set default Wrap for inserted pictures
 -> + [Bug 158520] Writer: Index-tagged headings not considered headings
           cross-reference-wise
    + [Bug 161344] Changing the language for Selected text clutters up language lists
    + [Bug 161574] Name index-related context menu items based on the type of index
           that was right-clicked
 -> + [Bug 161555] Missing shape algebra operation: Fragment
    + [Bug 161061] [UI] improve Calc grid lines options wording (was: "Grid lines are
           visible on all cells when option 'Show on colored cells' is chosen")

* Vertical tabpages state (Samuel/Thorsten)
    + maybe a safe move would be to revert on 24-8 and keep working on master (Xisco)
      + perhaps prepare the revert and discuss on gerrit

    - https://gerrit.libreoffice.org/c/core/+/169207

    - https://gerrit.libreoffice.org/c/core/+/169231

    - these two reverts look enough

    - looked into this a bit (Heiko)

      - tried, but it's too complex

      - Rafael is looking at pulling up the gen backend to gtk3 level

    - currently a master fix do not exist for 161492, 161491, 161351 (Regina)

      - agree with the revert on the branch

      - sounds like a good & positive way fwd (Thorsten)

=> CC Samuel/Thorsten on the gerrit reverts, push on the branch after a timeout (all)

* Crash Testing (Caolan)
    + Missing Caolan
    + https://wiki.documentfoundation.org/Development/Crashtesting
    + 24(+3) import failure, 19(+1) export failures
    + ??? coverity issues
    + Google / ossfuzz: ?? fuzzers active now

* Crash Reporting (Xisco)
    + 24.2.1.2    17451(+523)
    + 24.2.2.2    15373(+693)
    + 24.2.3.2    11334(+1533)
    + 24.2.4.2    1642(+1141)

    - Fixed in 24.2.4.2

        - https://crashreport.libreoffice.org/stats/signature/xmlreader::XmlReader::handleSkippedText(xmlreader::Span%20*,int%20*)


* Mentoring (Hossein)
  + Fixed a previous unwanted code behaviour change from mentee's refactoring
  + .NET progress (thanks to Ritobroto)
   'netmaker', which generates C# stubs from IDL specs
    + Merged:
      .NET Bindings: Add netmaker (.NET codemaker)
      https://gerrit.libreoffice.org/c/core/+/168710
   + Will be merged soon:
      .NET Bindings: disable switch for old windows CLI bindings
      https://gerrit.libreoffice.org/c/core/+/168751
   + CI .NET installation?
     + would prefer first just the native platform, Windows 64bit (Cloph)
     + for macOS, a single Intel bot is left
     + for Windows arm64, we always cross-build (Cloph)

          committer...   1 week     1 month     3 months    12 months
                  open     135(36)     249(60)     250(59)      250(59)
               reviews     464(68)    1296(74)    3216(-46)   12594(56)
                merged     363(151)   1075(78)    3279(145)   12698(41)
             abandoned      17(-18)     74(4)      179(1)       691(3)
           own commits     204(56)     722(-10)   2339(65)     9286(8)
        review commits      61(21)     234(9)      716(-5)     3005(10)
        contributor...   1 week     1 month     3 months    12 months
                  open      31(-6)      85(-2)      87(0)        87(0)
               reviews     964(220)   2810(160)   7560(292)   29506(56)
                merged      16(7)       63(-3)     290(-5)     1533(-7)
             abandoned       8(-7)      36(3)      108(0)       719(2)
           own commits      24(11)      95(5)      344(2)      1144(10)
        review commits       0(0)        0(0)        0(0)         0(0)
    + easyHack statistics:
       needsDevEval 9(9)   needsUXEval 1(1)   cleanup_comments 327(327)
       total 412(412)   assigned 26(26)   open 351(351)
    + top 10 contributors:
          Dione Maddern made 25 patches in 1 month, and 65 patches in 1 year
          Bogdan B made 8 patches in 1 month, and 25 patches in 1 year
          Weblate made 7 patches in 1 month, and 32 patches in 1 year
          Stéphane Guillou made 4 patches in 1 month, and 62 patches in 1 year
          LeSasse made 4 patches in 1 month, and 23 patches in 1 year
          Ritobroto Mukherjee made 3 patches in 1 month, and 18 patches in 1 year
          Hakim Ottey made 3 patches in 1 month, and 4 patches in 1 year
          Srebotnjak, Martin made 2 patches in 1 month, and 17 patches in 1 year
          Adam Seskunas made 2 patches in 1 month, and 14 patches in 1 year
          Darshan Upadhyay made 2 patches in 1 month, and 11 patches in 1 year
    + top 10 reviewers:
          Vajna, Miklos made 140 review comments in 1 month, and 1126 in 1 year
          Caolán McNamara made 128 review comments in 1 month, and 1542 in 1 year
          Nabet, Julien made 82 review comments in 1 month, and 850 in 1 year
          Thorsten Behrens made 78 review comments in 1 month, and 640 in 1 year
          Ilmari Lauhakangas made 76 review comments in 1 month, and 556 in 1 year
          Adolfo Jayme Barrientos made 70 review comments in 1 month, and 580 in 1 year
          Heiko Tietze made 62 review comments in 1 month, and 264 in 1 year
          Xisco Fauli made 62 review comments in 1 month, and 690 in 1 year
          Michael Stahl made 60 review comments in 1 month, and 892 in 1 year
          Hossein made 58 review comments in 1 month, and 310 in 1 year
    + Patches automatically abandoned:
        tdf#149256 Ship LibreOfficeKit headers in packages ( Hossein )
          -> Restored
            - https://gerrit.libreoffice.org/#/c/134863
        [WIP] Create new data structure for Primitive2DContainer ( Noel Grandin )
            - https://gerrit.libreoffice.org/#/c/135319
        WIP enable supports32Bitmap everywhere ( Noel Grandin )
            - https://gerrit.libreoffice.org/#/c/155713
        WIP JsonWriterStruct ( Noel Grandin )
            - https://gerrit.libreoffice.org/#/c/164293
        tdf#158803 remove unused imports ( Leo Sa )
          -> OK, changed solenv/gdb, which was not intended
            - https://gerrit.libreoffice.org/#/c/165387
        Add NaN payload check at startup ( Xuan Chen )
          -> Restored
            - https://gerrit.libreoffice.org/#/c/165391
        tdf#114441 sal_uLong to better integer types ( Aaron Bourdeaux )
          -> OK, no reply from the author
            - https://gerrit.libreoffice.org/#/c/165805
        WIP Simplify *SalBitmap::Create methods ( Noel Grandin )
            - https://gerrit.libreoffice.org/#/c/165923
        restore clear of cache on rw-access to ItemSet ( Caolán McNamara )
            - https://gerrit.libreoffice.org/#/c/166066
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Richard Trimble
          Yuki Joou

* GSoC (Ilmari)
  + Midterm evaluations deadline 12 July

* Commit Access

* Developer Certification (Stephan/Miklos/László/Gabriel)
  + resting since: 9 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
gerrit_android_aarch64     jobs: 188 ok: 182 ko:   4 fail ratio: 2.13% mean_ok:  11 ( 21) median_ok:   8 ( 12)
gerrit_android_arm         jobs: 187 ok: 181 ko:   4 fail ratio: 2.14% mean_ok:   9 ( 18) median_ok:   7 ( 11)
gerrit_android_x86         jobs: 188 ok: 181 ko:   5 fail ratio: 2.66% mean_ok:  10 ( 20) median_ok:   8 ( 13)
gerrit_android_x86_64      jobs: 188 ok: 184 ko:   3 fail ratio: 1.60% mean_ok:  10 ( 19) median_ok:   8 ( 12)
gerrit_linux_clang_dbgutil jobs: 378 ok: 312 ko:  58 fail ratio: 15.34% mean_ok:  46 ( 57) median_ok:  45 ( 52)
gerrit_linux_gcc_release   jobs: 436 ok: 363 ko:  51 fail ratio: 11.70% mean_ok:  19 ( 27) median_ok:  15 ( 20)
gerrit_mac                 jobs: 382 ok: 341 ko:  24 fail ratio: 6.28% mean_ok:  51 ( 60) median_ok:  48 ( 52)
gerrit_windows             jobs: 405 ok: 299 ko:  84 fail ratio: 20.74% mean_ok:  68 ( 89) median_ok:  64 ( 73)
gerrit_master_ml           jobs: 458 ok: 263 ko: 148 fail ratio: 32.31% mean_ok: 115 (115) median_ok:  99 ( 99)
gerrit_master              jobs:  48 ok:  25 ko:  19 fail ratio: 39.58% mean_ok:  79 ( 83) median_ok:  60 ( 63)
gerrit_master_seq          jobs: 415 ok: 243 ko: 129 fail ratio: 31.08% mean_ok: 116 (118) median_ok: 101 (102)
   + tests that failed more than twice in last seven days
      3 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
      3 CppunitTest_chart2_xshape                gerrit_linux_gcc_release
      3 CppunitTest_sc_subsequent_export_test3                gerrit_windows
      4 CppunitTest_chart2_export2                gerrit_linux_gcc_release
      5 CppunitTest_sw_layoutwriter2                gerrit_windows
      8 aborted by jenkins job timeout                gerrit_windows
     15 CppunitTest_sw_a11y                gerrit_windows
     + looks good wrt overall performance / failure rates (Cloph)
     + update Jenkins, java 17 is required by clients
       + affects lots/wollmux
       + related: no lode.git mirror on GitHub (Miklos)
         + just mail hostmaster@ if there is a need (Cloph)

* What’s cooking (Miklos)
    + A11y update (Michael W)
       + tdf#158914: Patrick's change to reduce memory usage and add missing a11y
        events in Calc merged now: https://gerrit.libreoffice.org/c/core/+/167961

         + Orca announces accessible descriptions in LO now (as does NVDA):

           https://listarchives.libreoffice.org/global/accessibility/msg01171.html

    + LO currently uses a11y descriptions for extended tips as well

    + might make sense to decouple that at some point

    + tdf#161648 "Border styles in Calc's sidebar not announced by screen reader"

    + RTL/CTL/CJK update (Jonathan)
        + tdf#92091: RTL/LTR script containing LTR/RTL footnotes laid out incorrectly
            + https://bugs.documentfoundation.org/show_bug.cgi?id=92091
            + Fixed
        + tdf#107209: Last vertical paragraph after fly laid out incorrectly
            + https://bugs.documentfoundation.org/show_bug.cgi?id=107209
            + Investigating
        + was testing the fixes, thanks! (Hossein)
          + There are some text rendering issues fixed in Writer, but they are still visible in editeng
          + would be interesting to also have these fixes in editeng
          + Writer and editeng serves different purposes (Jonathan)
            + haven't dived into editeng too much so far

* QA update (Xisco)
    + UNCONFIRMED: 1168 (+1)
        + enhancements: 268  (-4)
        + needsUXEval: 10 (+0)
        + haveBackTrace: 9 (-1)
        + needsDevAdvice: 47 (+1)
        + documentation:  6 (+1)
        + android:  0 (+0)
        + iOS:  0 (+0)
        + Online:  9 (+0)



    + Most pressing bugs:
     New:

    None


    + New high severity bugs of the week:
        + Crash in: Edit::ImplSetText(rtl::OUString const &,Selection const *) when opening Bullets and Numbering dialog in Impress (Skia)
            + https://bugs.documentfoundation.org/show_bug.cgi?id=160525
              + regression from “Update skia to m111”
              + https://skia.googlesource.com/skia/+/refs/heads/main/RELEASE_NOTES.md says upstream is at m127 (Miklos)
              + interested in trying an update at least (Hossein)
                + if you're stuck, you can ask Noel if he has ideas (Xisco)

        + Crash on second copy after pasting using Enter in Calc on macOS
            + https://bugs.documentfoundation.org/show_bug.cgi?id=161461
            + Patrick will look at it

        + MATCH() fails to AutoCalculate
            + https://bugs.documentfoundation.org/show_bug.cgi?id=161592
            + needs bisecting ... bisecting it now

* QA stats (Stéphane)
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +122  -22 (-135) overall)
      many thanks to the top bug squashers:
       Stéphane Guillou (stragu) 22
       Mike Kaganski           14
       QA Administrators       14
       László Németh           9
       Buovjaga                8
       Jonathan Clark          7
       m_a_riosv               7
       Caolán McNamara         4
       Julien Nabet            4
       Michael Stahl (allotropia) 3

    + top 10 bugs reporters:
       László Németh           5
       Ahmed Hamed             4
       Gabor Kelemen (allotropia) 3
       Regina Henschel         3
       Xisco Faulí             3
       Albert Acer             2
       Ash                     2
       Attila Szűcs            2
       Eyal Rozenberg          2
       Joanmarie Diggs         2

    + top 10 bugs fixers:
       Kaganski, Mike          7
       Németh, László          6
       Caolán McNamara         4
       Michael Stahl           4
       Patrick Luby            3
       Balland-Poirier, Laurent 2
       Heiko Tietze            2
       Ilmari Lauhakangas      2
       Rafael Lima             2
       Vajna, Miklos           2

    + top 10 bugs confirmers:
       Stéphane Guillou        15
       Nabet, Julien           8
       Xisco Fauli             5
       m.a.riosv               5
       Ahmed Hamed             4
       Dieter                  4
       Heiko Tietze            4
       Ilmari Lauhakangas      4
       Kaganski, Mike          4
       Robert Großkopf         4


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Ilmari Lauhakangas     4
        Stéphane Guillou       2
        Xisco Fauli            2
        Raal                   1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Ilmari Lauhakangas     4
        Stéphane Guillou       3
        Xisco Fauli            2
        Raal                   1


* all bugs tagged with 'regression'
   + 1228(-6) bugs open of 13431(+13) total 25(+1) high prio.

     done by:
        Stéphane Guillou       4
        Ilmari Lauhakangas     3
        Robert Großkopf        2
        Telesto                2
        Xisco Fauli            2
        m.a.riosv              1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 14(+0)
     Calc          - 4(+1)
     Impress       - 2(+0)
     LibreOffice   - 2(+0)
     UI            - 2(+0)

   by OS:
     All           - 16(-1)
     Linux         - 5(+0)
     Mac OS X      - 0(+0)
     Windows       - 3(+1)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 423(+1)
     Calc                     - 231(+0)
     Impress                  - 122(-3)
     LibreOffice              - 51(-2)
     Draw                     - 48(-3)
     Writer: docx filter      - 44(-1)
     Crashes                  - 43(+1)
     Base                     - 41(+2)
     UI                       - 39(+0)
     Borders                  - 34(+0)
     Writer: perf             - 34(-1)
     Writer: other filter     - 32(+0)
     Printing and PDF export  - 27(+1)
     Chart                    - 24(+0)
     RTL                      - 23(+0)
     filters and storage      - 21(+0)
     BASIC                    - 19(+0)
     Writer: doc filter       - 16(+0)
     graphics stack           - 13(+0)
     Formula Editor           - 8(+1)
     framework                - 3(+0)
     Extensions               - 2(+0)
     sdk                      - 2(+0)
     Linguistic               - 1(+0)



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux