ESC meeting minutes: 2024-05-23

[Miklos Vajna <vmiklos@xxxxxxxxxxxxx>]

* Present:
    + sockseight, Heiko, Michael W, Ilmari, Jonathan, Caolan, Hossein, Eike, Moritz, Cloph, Xisco, Miklos

* Completed Action Items:

* Pending Action Items:
    + MAR update: include OS info in the user agent or file a bug to do it (Cloph)

* Release Engineering update (Cloph)
    + 24.2: 24.2.4 RC1 was tagged this week, 24.2.4 RC2 next week
    + 24.8:
        + feature freeze (beta1) in 2 weeks
        + string / UI freeze 3 weeks after that

* Documentation (Olivier)
    + Missing Olivier
    + Bugzilla Documentation statistics
        255(255) bugs open
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
           created     16(4)    44(-2)    112(5)     221(1)
         commented     37(25)   91(21)    276(31)    868(31)
          resolved      7(1)    27(-1)     62(5)     124(1)
    + top 10 contributors:
          Olivier Hallot made 46 changes in 1 month, and 243 changes in 1 year
          Dione Maddern made 28 changes in 1 month, and 59 changes in 1 year
          Stéphane Guillou made 24 changes in 1 month, and 247 changes in 1 year
          Vernon, Stuart Foote made 23 changes in 1 month, and 107 changes in 1 year
          Dieter made 13 changes in 1 month, and 18 changes in 1 year
          Heiko Tietze made 10 changes in 1 month, and 77 changes in 1 year
          Ilmari Lauhakangas made 10 changes in 1 month, and 69 changes in 1 year
          Óvári made 10 changes in 1 month, and 13 changes in 1 year
          Kaganski, Mike made 7 changes in 1 month, and 74 changes in 1 year
          Cor Nouws made 6 changes in 1 month, and 9 changes in 1 year

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        240(240) (topicUI) bugs open, 37(37) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week    1 month    3 months   12 months
             added      3(-4)     10(-3)     14(-4)      22(-3)
         commented     29(-31)   159(-47)   512(-48)   1710(-47)
           removed      0(0)       3(-1)      5(0)       11(0)
          resolved      5(-3)     28(-4)     79(-1)     290(-7)
    + top 10 contributors:
          Heiko Tietze made 94 changes in 1 month, and 956 changes in 1 year
          Vernon, Stuart Foote made 65 changes in 1 month, and 312 changes in 1 year
          Eyal Rozenberg made 58 changes in 1 month, and 171 changes in 1 year
          Stéphane Guillou made 48 changes in 1 month, and 624 changes in 1 year
          Dieter made 16 changes in 1 month, and 124 changes in 1 year
          Weghorn, Michael made 8 changes in 1 month, and 23 changes in 1 year
          Olivier Hallot made 8 changes in 1 month, and 22 changes in 1 year
          Jakub Kościelak made 6 changes in 1 month, and 6 changes in 1 year
          Henschel, Regina made 6 changes in 1 month, and 33 changes in 1 year
          Roman Kuznetsov made 5 changes in 1 month, and 41 changes in 1 year
    + [Bug 161234] Issues with the new cell outline in Calc 24.8
    + [Bug 161223] basic HTML cell render
    + [Bug 161218] Inconsistent and confusing Text Flow | Break options in
           Table Properties
    + [Bug 161204] UI - dashed outline for active cell border
    + [Bug 161205] Font selection dialog doesn't persist choice of RTL-CTL +
           auto-chooses CJK
    + [Bug 161203] When applying a style by double-clicking it in sidebar style list,
           keep list scroll position
    + [Bug 160896] Allow referencing Column & Row with Base 1 instead of 0 in Basic
    + [Bug 161149] Cancel all ability to apply direct formatting, and only allow
           formatting via styles
    + [Bug 160881] Forms: Checkboxes and Radiobuttons couldn't set readonly, only
           could set disabled
    + [Bug 160874] Calc fails to suggest correction for formula cell without equal sign

* Vertical tabpages state (Samuel)
  + review the state in 1 week
  + no news (Heiko)

* Crash Testing (Caolan)
    + 23(-2) import failure, 18(-1) export failures
      - https://wiki.documentfoundation.org/Development/Crashtesting

          - https://bugs.documentfoundation.org/show_bug.cgi?id=161232

          - https://bugs.documentfoundation.org/show_bug.cgi?id=160862

    + 0 coverity issues
    + Google / ossfuzz: ?? fuzzers active now

* Crash Reporting (Xisco)
    + 7.6.6.3    6050(+937)
    + 7.6.7.2    457(+354)
    + 24.2.0.3    18611(+663)
    + 24.2.1.2    15171(+694)
    + 24.2.2.2    11690(+1291)
    + 24.2.3.2    2976(+1539)

    + new in 24.2:
        https://crashreport.libreoffice.org/stats/signature/SfxItemPool::unregisterSfxPoolItem(SfxPoolItem%20const%20&)

* Mentoring (Hossein)
 + Reviewed submissions from newcomers
 + New EasyHack around QueryWizard
   tdf#161144 - Query wizard confuses columns with the same name in different tables
   https://bugs.documentfoundation.org/show_bug.cgi?id=161144
 => Will create a project on VolunteerMatch for porting it to Python (hopefully after GSoC)
          committer...   1 week     1 month     3 months    12 months
                  open      56(-33)    146(-14)    147(-13)     147(-13)
               reviews     362(44)    1322(72)    3538(-56)   12486(28)
                merged     254(-56)   1304(60)    3385(-38)   12718(4)
             abandoned      10(-5)      53(-8)     175(1)       659(-2)
           own commits     177(-50)    946(33)    2400(20)     9273(-1)
        review commits      72(34)     233(15)     820(-19)    3005(11)
        contributor...   1 week      1 month    3 months     12 months
                  open      36(-19)      95(-8)     96(-7)        96(-7)
               reviews     730(-164)   3132(82)   7826(-104)   29550(-24)
                merged      25(10)       90(4)     366(-11)     1589(6)
             abandoned       7(7)        28(-5)    280(1)        704(5)
           own commits      35(21)      107(10)    413(-16)     1137(23)
        review commits       0(0)         0(0)       0(0)          0(0)
    + easyHack statistics:
       needsDevEval 9(9)   needsUXEval 1(1)   cleanup_comments 326(326)
       total 410(410)   assigned 27(27)   open 348(348)
    + top 10 contributors:
          Dione Maddern made 11 patches in 1 month, and 45 patches in 1 year
          Jakub Kościelak made 7 patches in 1 month, and 7 patches in 1 year
          Stéphane Guillou made 5 patches in 1 month, and 60 patches in 1 year
          Weblate made 4 patches in 1 month, and 25 patches in 1 year
            made 4 patches in 1 month, and 7 patches in 1 year
          LeSasse made 4 patches in 1 month, and 23 patches in 1 year
          Hubert Figuière made 3 patches in 1 month, and 8 patches in 1 year
          Printf Debugging made 3 patches in 1 month, and 4 patches in 1 year
          Marco Pinto made 2 patches in 1 month, and 6 patches in 1 year
          Bayram Çiçek made 2 patches in 1 month, and 3 patches in 1 year
    + top 10 reviewers:
          Caolán McNamara made 138 review comments in 1 month, and 1506 in 1 year
          Ilmari Lauhakangas made 110 review comments in 1 month, and 564 in 1 year
          Adolfo Jayme Barrientos made 106 review comments in 1 month, and 532 in 1 year
          Grandin, Noel made 84 review comments in 1 month, and 718 in 1 year
          Michael Stahl made 82 review comments in 1 month, and 908 in 1 year
          Vajna, Miklos made 68 review comments in 1 month, and 1088 in 1 year
          Hossein made 66 review comments in 1 month, and 322 in 1 year
          Thorsten Behrens made 64 review comments in 1 month, and 596 in 1 year
          Christian Lohmaier made 54 review comments in 1 month, and 360 in 1 year
          Kaganski, Mike made 52 review comments in 1 month, and 470 in 1 year

* GSoC (Ilmari)
    + next deadline: end of bonding period: 27th of May
    + Ritobroto / .NET project (Hossein)
      + plan to introduce this incrementally, deprecate the old one at the end
      + should happen gradually

* Commit Access

* LibreOffice Technology hackfest at Budapest (Miklos)
  + 4th & 5th June (Tue-Wed), in 1,5 weeks
  + details: https://wiki.documentfoundation.org/Hackfest/Budapest2024
  + on blog: https://blog.documentfoundation.org/blog/2024/05/16/coming-up-libreoffice-technology-budapest-2024-hackfest/

* Developer Certification (Stephan/Miklos/László/Gabriel)
  + resting since: 5 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
gerrit_android_aarch64     jobs: 149 ok: 138 ko:   7 fail ratio: 4.70% mean_ok:  10 ( 12) median_ok:   8 ( 10)
gerrit_android_arm         jobs: 151 ok: 138 ko:  10 fail ratio: 6.62% mean_ok:  11 ( 12) median_ok:   8 ( 10)
gerrit_android_x86         jobs: 150 ok: 136 ko:   9 fail ratio: 6.00% mean_ok:  10 ( 11) median_ok:   7 (  9)
gerrit_android_x86_64      jobs: 150 ok: 138 ko:   9 fail ratio: 6.00% mean_ok:  11 ( 12) median_ok:   8 (  8)
gerrit_linux_clang_dbgutil jobs: 325 ok: 225 ko:  86 fail ratio: 26.46% mean_ok:  39 ( 40) median_ok:  35 ( 36)
gerrit_linux_gcc_release   jobs: 346 ok: 291 ko:  40 fail ratio: 11.56% mean_ok:  19 ( 20) median_ok:  15 ( 15)
gerrit_mac                 jobs: 325 ok: 269 ko:  43 fail ratio: 13.23% mean_ok:  58 ( 58) median_ok:  53 ( 53)
gerrit_windows             jobs: 324 ok: 211 ko:  93 fail ratio: 28.70% mean_ok:  99 (106) median_ok:  89 ( 92)
gerrit_master_ml           jobs: 386 ok: 175 ko: 179 fail ratio: 46.37% mean_ok: 112 (112) median_ok: 103 (103)
gerrit_master              jobs:  70 ok:  23 ko:  39 fail ratio: 55.71% mean_ok: 120 (120) median_ok: 110 (110)
gerrit_master_seq          jobs: 316 ok: 152 ko: 140 fail ratio: 44.30% mean_ok: 111 (111) median_ok: 102 (102)
   + tests that failed more than twice in last seven days:
      3 CppunitTest_sc_stylefamiliesobj                gerrit_linux_clang_dbgutil
      3 CppunitTest_sw_a11y                gerrit_windows
      4 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
      4 CppunitTest_sw_ooxmlexport2                gerrit_mac
      4 CppunitTest_sw_ooxmlexport6                gerrit_linux_gcc_release
      5 CppunitTest_sw_core_text                gerrit_linux_gcc_release
     10 aborted by jenkins job timeout                gerrit_windows
     38 CppunitTest_vcl_gtk3_a11y                gerrit_linux_clang_dbgutil
    + this week: have a new problem with CppunitTest_vcl_gtk3_a11y (Cloph)
      + failure is not new, but the frequency increased recently
      + assume: timing issue

* What’s cooking (Miklos)
    + A11y update (Michael W)
        + Patrick looking into a11y-related high memory use in Calc on macOS
          (tdf#158914)
        + working on editable combobox a11y (tdf#160971)
        + upstream Accerciser, GTK 4, Qt improvements
        + planning to look into vertical tabpages a11y
    + RTL/CTL/CJK update (Jonathan)
        + tdf#61444: Text layout broken across formatting changes
        + tdf#124116: Text shaping broken across formatting changes
        + tdf#71956: Style changes inside grapheme clusters
            - All text rendering changes committed
        + tdf#56408: Writer always breaks lines at text direction change
            - Beginning investigation
        + Xisco to run the mso-interop tool to see what it finds, takes ~4 days
    + tdf#160984 Section-based continuous endnotes in Writer (Miklos)
    + SAL_RET_MAYBENULL (Caolán)
      + it exists!
      + add it to a function returning a pointer, then MSVC enforces the client checks for nullptrs
      + in the stock Jenkins config already

* QA update (Xisco)
    + UNCONFIRMED: 1161 (-47)
        + enhancements: 277  (-1)
        + needsUXEval: 12 (+0)
        + haveBackTrace: 10 (-1)
        + needsDevAdvice: 46 (-1)
        + documentation:  3 (-1)
        + android:  0 (+0)
        + iOS:  0 (+0)
        + Online:  9 (+0)

    + Most pressing bugs:
     New:

    None


    + New high severity bugs of the week:
        + Image disappears when inserting 2 images at the same location
            + https://bugs.documentfoundation.org/show_bug.cgi?id=107529
            + bisected to Tamas Z
            + Since 4.4

        + FILESAVE DOCX: inline (anchored as char) frames moved to end of paragraph on export
            + https://bugs.documentfoundation.org/show_bug.cgi?id=124821
            + bisected to Miklos; ever since writing drawingML in LO 4.3
            + Justin has a fix for it

        + Paragraph classification deleted after Print Preview or when opening file
            + https://bugs.documentfoundation.org/show_bug.cgi?id=160877
            + bisected to Ashod
            + Since 6.3 (2018)

        + Document Properties pages in all modules do not fit screen and cannot be resized (gtk3/gtk4)
            + https://bugs.documentfoundation.org/show_bug.cgi?id=160937

                + looks to me like its the "Description" page that is the problem (Caolan)

         + needs a scrollbar or whatever in that page, or less things in it

            + not tagged as a regression

        + FILEOPEN DOCX SaxException when opening specific file
            + https://bugs.documentfoundation.org/show_bug.cgi?id=161139
            + bisected to Tomaz
            + Since 24.2

* QA stats (Stéphane)
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +126  -29 (-152) overall)
      many thanks to the top bug squashers:
       Buovjaga                37
       Stéphane Guillou (stragu) 34
       QA Administrators       11
       Heiko Tietze            7
       Caolán McNamara         6
       Michael Weghorn         5
       V Stuart Foote          5
       Adolfo Jayme Barrientos 4
       m_a_riosv               4
       Dione Maddern           3

    + top 10 bugs reporters:
       Stéphane Guillou (stragu) 8
       Hossein                 3
       Mike Kaganski           3
       Eyal Rozenberg          2
       Gabor Kelemen (allotropia) 2
       Tuomas Hietala          2
       Heiko Tietze            1
       J22Gim                  1
       Michael Meeks           1
       Orwel                   1

    + top 10 bugs fixers:
       Caolán McNamara         5
       Adolfo Jayme Barrientos 4
       Dione Maddern           3
       Rathke, Eike            3
       Heiko Tietze            2
       Justin Luth             2
       Kaganski, Mike          2
       Kurt Nordback           2
       Michael Stahl           2
       Németh, László          2

    + top 10 bugs confirmers:
       Stéphane Guillou        58
       m.a.riosv               7
       Heiko Tietze            6
       Dione Maddern           3
       Weghorn, Michael        3
       Aron Budea              2
       Ilmari Lauhakangas      2
       Kaganski, Mike          2
       Nabet, Julien           2
       Raal                    2


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Stéphane Guillou       8
        Raal                   3
        Aron Budea             1
        Ilmari Lauhakangas     1
        Kelemen, Gabor         1
        Xisco Fauli            1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Stéphane Guillou       8
        Raal                   3
        Aron Budea             1
        Ilmari Lauhakangas     1
        Kelemen, Gabor         1
        Xisco Fauli            1


* all bugs tagged with 'regression'
   + 1250(+5) bugs open of 13382(+22) total 23(-1) high prio.

     done by:
        Stéphane Guillou      10
        m.a.riosv              4
        Aron Budea             1
        Kelemen, Gabor         1
        Raal                   1
        Rafael Lima            1
        Nabet, Julien          1
        Xisco Fauli            1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 13(-1)
     Calc          - 3(+0)
     Impress       - 2(+0)
     LibreOffice   - 2(+0)
     UI            - 2(+0)

   by OS:
     All           - 16(-1)
     Linux         - 5(+0)
     Mac OS X      - 0(+0)
     Windows       - 2(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 432(+3)
     Calc                     - 232(+2)
     Impress                  - 127(-1)
     LibreOffice              - 53(+1)
     Draw                     - 52(+0)
     UI                       - 44(+2)
     Writer: docx filter      - 44(-1)
     Base                     - 41(-1)
     Crashes                  - 41(+1)
     Borders                  - 35(+1)
     Writer: perf             - 34(+0)
     Writer: other filter     - 31(+0)
     Printing and PDF export  - 26(+0)
     Chart                    - 24(+0)
     RTL                      - 23(+0)
     BASIC                    - 21(+0)
     filters and storage      - 21(+0)
     Writer: doc filter       - 16(+0)
     graphics stack           - 13(+1)
     Formula Editor           - 7(+0)
     framework                - 3(+0)
     Extensions               - 2(+0)
     sdk                      - 2(+0)
     Linguistic               - 1(+0)