ESC meeting minutes: 2024-04-18

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Present:
    + Olivier, Ilmari, Regina, Michael S, Michael W, Jonathan, Hossein, Stephan, Miklos, Xisco, Eike, Heiko, Cloph, Caolan

* Completed Action Items:

* Pending Action Items:
    + Update api.libreoffice.org from 7.4 (Cloph)

* Release Engineering update (Cloph)
    + 7.6: 7.6.7 RC1 this week, probably later today
    + 24.2: 24.2.3 RC2 next week

* Documentation (Olivier)
    + New Help
       + Fix on CSS (Juan José)
    + Helpcontents2
       + New pages for paragraph signature (wip) (Colton Garrett)
         + may be useful to CC Ashod on the change (Miklos)
         + several signature parts: PDF, macros, gpg or not, etc (Olivier)
       + Updates and fixes (ohallot)
    + Guides
       + Work in progress
       + About translations.
    + Bugzilla Documentation statistics
        265(265) bugs open
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
           created     8(1)     30(-22)    89(0)     218(-6)
         commented     3(-16)   57(-39)   235(-3)    836(-12)
          resolved     6(4)     16(-6)     43(5)     116(2)
    + top 10 contributors:
          Olivier Hallot made 44 changes in 1 month, and 263 changes in 1 year
          Dione Maddern made 17 changes in 1 month, and 31 changes in 1 year
          Kaganski, Mike made 15 changes in 1 month, and 69 changes in 1 year
          MeBugzilla made 7 changes in 1 month, and 7 changes in 1 year
          Weghorn, Michael made 7 changes in 1 month, and 8 changes in 1 year
          Nabet, Julien made 7 changes in 1 month, and 53 changes in 1 year
          Cor Nouws made 3 changes in 1 month, and 3 changes in 1 year
          Adolfo Jayme Barrientos made 3 changes in 1 month, and 24 changes in 1 year
          nobu made 3 changes in 1 month, and 12 changes in 1 year
          Pierre F made 2 changes in 1 month, and 30 changes in 1 year

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        243(243) (topicUI) bugs open, 45(45) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
             added      4(-4)    19(1)     23(2)       31(2)
         commented     71(41)   231(23)   564(59)    1949(-32)
           removed      1(1)      2(1)      2(1)       12(0)
          resolved      8(2)     28(2)     85(3)      320(4)
    + top 10 contributors:
          Stéphane Guillou made 96 changes in 1 month, and 683 changes in 1 year
          Heiko Tietze made 91 changes in 1 month, and 1124 changes in 1 year
          Vernon, Stuart Foote made 68 changes in 1 month, and 274 changes in 1 year
          Eyal Rozenberg made 27 changes in 1 month, and 156 changes in 1 year
          Ilmari Lauhakangas made 26 changes in 1 month, and 162 changes in 1 year
          Ady made 20 changes in 1 month, and 141 changes in 1 year
          Justin Luth made 18 changes in 1 month, and 140 changes in 1 year
          Devansh Varshney made 13 changes in 1 month, and 20 changes in 1 year
          Cor Nouws made 10 changes in 1 month, and 18 changes in 1 year
          m.a.riosv made 10 changes in 1 month, and 59 changes in 1 year
    + [Bug 160686] "Left Page" and "Right Page" are nonsensical and should be removed
    + [Bug 160684] The Landscape style is nonsensical while we have neither
           hierarchical nor composable page styles
    + [Bug 160682] HTML "page style" is not a page style - move this functionality
           elsewhere
 -> + [Bug 154434] FILEOPEN HTML: Writer loses HTML layout
      + wonder to what extent we want to support for format (Heiko)
      + but these days many apps have internal HTML renderers (Hossein)
      + curently closed as wontfix (Heiko)
        + not sure where to draw the line
      + also CSS, do we event handle CSS layout at all? (Ilmari)
        + at layout: things start to fall apart
        + also unclear where to draw the line
      + using a writer2html extension (Olivier)
      + when developing a product, you need to consider your audience / market section (Hossein)
        + compare us vs other word processors
        + best to comare us to other word processors, not browsers
    + [Bug 160658] Shortcut key menu's elements are odd and empty
    + [Bug 139112] Accessibility options dialog should adapt its width to long labels
    + [Bug 160629] Bullets and Numbering dialog in Writer does not say it's about an
           implicit list style
    + [Bug 160608] "Re-type Password" dialog needs UX improvement
    + [Bug 49259] Writer is too jumpy when selecting an object if another object
           was selected
    + [Bug 99608] Using clone formatting enables scrolling with the mouse -- but
           it shouldn't

   + Poll "What kind of User Interface are you using?"
     + https://fosstodon.org/@libodesign/112285659953746809
     + agree with Heiko, it makes sense to invest more into the tabbed interface (Hossein)
       + agree (Olivier)
     + would like to define some notebookbar gsoc project for next year (Hossein)

* Crash Testing (Caolan)
    + 24(+4) import failure, 19(+17) export failures
      - lots of actual errors, enough to run out of space with core dumps
      - some pivot table related, one fixed, another in gerrit
      - some fround32->fround64 related, MikeK has a fix in gerrit
    + 16 coverity issues
      - not sure what the warnings are trying to tell me, virtual base related?
97    BasicMethodNodeImpl::~BasicMethodNodeImpl()
98    {
   1. destroy: ~WeakImplHelper destroys this->m_aMutex.["show details"]
   CID 1596129: (#1 of 1): Uninitialized lock use (LOCK)
   2. uninitialized_use: ~OPropertyContainer2 uses this->m_aMutex in an uninitialized state.["show details"]
99    }

    + 3 ossfuzz issues
     - one crash (auto testing if fixed in progress)

* Crash Reporting (Xisco)
    + 7.6.5.2    8103(+920)
    + 7.6.6.3    1054(+587)
    + 24.2.0.3   15407(+717)
    + 24.2.1.2   10893(+1203)
    + 24.2.2.2   3121(+1458)

    + New in 24.2

    - https://crashreport.libreoffice.org/stats/signature/ScOutputData::DrawRefMark(short,long,short,long,Color%20const%20&,bool)


    - https://crashreport.libreoffice.org/stats/signature/WhichRangesContainer::getOffsetFromWhich(unsigned%20short)

    - cell aligment ?

    - what stops pLastPattern of ScInputHandler from being a dangling pointer if its removed from the document (if that is how it works)

    - https://bz.apache.org/ooo/show_bug.cgi?id=67990 was a crash with pLastPattern with a few steps to reproduce that old issue


* Mentoring (Hossein)
 + Multiple calls for Windows-build issues
 + Finalized and published a blog post on dev blog
   Crash fixes part 3 – Testing crashes
   https://dev.blog.documentfoundation.org/2024/04/18/crash-fixes-part-3-testing-crashes/
 + ongoing discussion wrt updating the .NET UNO binding (Hossein)
   + if interested, talk to Hossein for details
          committer...   1 week     1 month      3 months     12 months
                  open      46(-31)    120(-22)     143(-16)      143(-16)
               reviews     318(14)    1376(-164)   3862(-112)   12518(8)
                merged     213(19)     981(-34)    3277(-84)    12494(-1)
             abandoned       9(-7)      49(-2)      167(-3)       665(-1)
           own commits     129(-11)    641(-41)    2144(-67)     9192(-84)
        review commits      43(-14)    259(-55)     872(-55)     3055(-10)
        contributor...   1 week      1 month      3 months     12 months
                  open      36(4)        99(0)       105(4)        105(4)
               reviews     582(-106)   2612(-172)   7690(-256)   29570(-202)
                merged      17(-4)      137(-18)     356(-7)      1724(-73)
             abandoned      11(-6)       45(8)       290(0)        690(1)
           own commits      16(-15)     153(-28)     446(-17)     1117(-3)
        review commits       0(0)         0(0)         0(0)          0(0)
    + easyHack statistics:
       needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 332(332)
       total 415(415)   assigned 28(28)   open 353(353)
    + top 10 contributors:
          LeSasse made 19 patches in 1 month, and 19 patches in 1 year
          Armin Le Grand (allotropia) made 16 patches in 1 month, and 90 patches in 1 year
          Ritobroto Mukherjee made 13 patches in 1 month, and 13 patches in 1 year
          Dione Maddern made 10 patches in 1 month, and 34 patches in 1 year
          Rafał Dobrakowski made 8 patches in 1 month, and 17 patches in 1 year
          Bogdan B made 5 patches in 1 month, and 20 patches in 1 year
          Aaron Bourdeaux made 5 patches in 1 month, and 5 patches in 1 year
          Juan José González made 4 patches in 1 month, and 11 patches in 1 year
          Xuan Chen made 3 patches in 1 month, and 5 patches in 1 year
            made 3 patches in 1 month, and 3 patches in 1 year
    + top 10 reviewers:
          Caolán McNamara made 106 review comments in 1 month, and 1382 in 1 year
          Adolfo Jayme Barrientos made 104 review comments in 1 month, and 492 in 1 year
          Grandin, Noel made 92 review comments in 1 month, and 708 in 1 year
          Vajna, Miklos made 84 review comments in 1 month, and 1102 in 1 year
          Ilmari Lauhakangas made 80 review comments in 1 month, and 508 in 1 year
          Olivier Hallot made 76 review comments in 1 month, and 348 in 1 year
          Thorsten Behrens made 76 review comments in 1 month, and 656 in 1 year
          Hossein made 72 review comments in 1 month, and 326 in 1 year
          Christian Lohmaier made 64 review comments in 1 month, and 376 in 1 year
          Michael Stahl made 64 review comments in 1 month, and 936 in 1 year
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Zainab Abbasi
          Ashwani Kumar
          colton Garrett
          Hakim Ottey
          Omkar  Nikam

* GSoC (Ilmari)
    + https://summerofcode.withgoogle.com/programs/2024/organizations/libreoffice
    + https://wiki.documentfoundation.org/Development/GSoC/2024
    + April 24: project rankings due
    + Patch review help appreciated: https://wiki.documentfoundation.org/Development/gerrit/CommonQueries

* Commit Access

* Developer Certification (Stephan/Miklos/László/Gabriel)
  + resting since: 1 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
gerrit_android_aarch64     jobs: 151 ok: 148 ko:   2 fail ratio: 1.32% mean_ok:   8 (  9) median_ok:   6 (  7)
gerrit_android_arm         jobs: 151 ok: 147 ko:   2 fail ratio: 1.32% mean_ok:   9 (  9) median_ok:   6 (  7)
gerrit_android_x86         jobs: 151 ok: 149 ko:   2 fail ratio: 1.32% mean_ok:   7 (  9) median_ok:   6 (  7)
gerrit_android_x86_64      jobs: 150 ok: 147 ko:   2 fail ratio: 1.33% mean_ok:   8 (  9) median_ok:   6 (  6)
gerrit_linux_clang_dbgutil jobs: 302 ok: 242 ko:  53 fail ratio: 17.55% mean_ok:  34 ( 35) median_ok:  29 ( 30)
gerrit_linux_gcc_release   jobs: 354 ok: 292 ko:  51 fail ratio: 14.41% mean_ok:  16 ( 17) median_ok:  14 ( 14)
gerrit_mac                 jobs: 303 ok: 253 ko:  35 fail ratio: 11.55% mean_ok:  51 ( 51) median_ok:  49 ( 49)
gerrit_windows             jobs: 352 ok: 173 ko: 144 fail ratio: 40.91% mean_ok:  54 (133) median_ok:  55 (107)
gerrit_master_ml           jobs: 400 ok: 150 ko: 206 fail ratio: 51.50% mean_ok: 144 (145) median_ok: 123 (125)
gerrit_master              jobs:  48 ok:  20 ko:  21 fail ratio: 43.75% mean_ok:  97 ( 97) median_ok:  56 ( 56)
gerrit_master_seq          jobs: 350 ok: 130 ko: 183 fail ratio: 52.29% mean_ok: 150 (150) median_ok: 131 (131)
   + https://dev-www.libreoffice.org/tmp/gerrit_240418.html
   + tests that failed more than twice in last seven days
      3 CppunitTest_sw_ooxmlexport17                gerrit_mac
      4 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
      4 CppunitTest_svgio                gerrit_linux_gcc_release
      4 JunitTest_chart2_unoapi                gerrit_linux_clang_dbgutil
    108 aborted by jenkins job timeout                gerrit_windows
    + Jenkins is suffering from the Windows builds getting stuck (Cloph)
      + seems it's not tied to specific bots
      + only a matter of time when a build hangs, then all subsequent builds fail
    + also saw it on libreoffice-24-2 branch (Xisco)
    + if you see a bot failing like this, take it offline and ping #tdf-infra (Cloph)
      + if this happens, please announce that more widely (Stephan)
      + maybe on the mailing list
    + Noel has a WIP change to try to have a Windows version of the kill wrapper
      https://gerrit.libreoffice.org/c/lode/+/129675

* What’s cooking (Miklos)
    + A11y update (Michael W)
      + announcement of text formatting toggling with NVDA (tdf#160695/nvda#4248)
      + Navigator a11y improvements (tdf#159910)
      + gtk3: comobobox a11y
    + RTL/CTL/CJK update (Jonathan)

        + (Bug 49885): Propose moving to ICU for CJ word BreakIterator

          + trying to upstream the Chinese/Japanese customizations

          + have a memory that people consider word counting as very important (Caolan)

            + aware of the problem (Jonathan)

    + Regression hotspots script updates (Ilmari)
       + https://git.libreoffice.org/dev-tools/+/refs/heads/master/scripts/regression-hotspots.py
       + https://wiki.documentfoundation.org/Development/RegressionHotspots
       + Runtime down from 10 hours to 30 seconds
       + How to make it even more useful for QA stats?
       + Handling renamed files and dirs?
       + Presenting change over time?

     + build with wsl-as-helper but from within git-bash (Cloph)

       + cleaning it up/getting it ready for submission

       + still not all working via plain configure, some hardcoded paths

       + git-bash can be installed from visual studio

       + long-term goal would be to replace cygwin with wsl+git-bash

         + still needs a manually installed perl, which is a bit ugly

       + just got some Windows arm64 HW, cygwin is really ugly there (Thorsten)

         + interested to try this there, on Windows 11

         + all in for trying this out (Stephan)

       + mingw itself, is that an option? (Hossein)

         + not the compiler, the environment

         + configure to work without cygwin is a lot of work (Cloph)

         + idea is to build from git-bash, and call selected tools from wsl


* QA update (Xisco)
    + UNCONFIRMED: 1168 (+5)
        + enhancements: 283  (+5)
        + needsUXEval: 17 (+5)
        + haveBackTrace: 10 (-1)
        + needsDevAdvice: 46 (+2)
        + documentation:  3 (+1)
        + android:  0 (+0)
        + iOS:  0 (+0)
        + Online:  9 (+0)


    + Most pressing bugs:
     New:

             None


    + New high severity bugs of the week:
        + FILEOPEN XLSX Missing pivot tables
            + https://bugs.documentfoundation.org/show_bug.cgi?id=160670
            + Fixed. Thanks to Tomaz

* QA stats (Stéphane)
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +95  +14 (-108) overall)
      many thanks to the top bug squashers:
       QA Administrators       21
       m_a_riosv               10
       Stéphane Guillou (stragu) 9
       Heiko Tietze            7
       Olivier Hallot          5
       Buovjaga                4
       V Stuart Foote          4
       Dieter                  3
       Eike Rathke             3
       Jim Raykowski           3

    + top 10 bugs reporters:
       Telesto                 9
       Christoph Anton Mitterer 4
       Eyal Rozenberg          3
       Gabor Kelemen (allotropia) 3
       Mike Kaganski           3
       Gerald Pfeifer          2
       J22Gim                  2
       Timur                   2
       steve                   2
       Olivier Hallot          1

    + top 10 bugs fixers:
       Olivier Hallot          5
       Jim Raykowski           3
       Adolfo Jayme Barrientos 1
       Balazs Varga            1
       Balland-Poirier, Laurent 1
       Don                     1
       Grandin, Noel           1
       Heiko Tietze            1
       Justin Luth             1
       Kosiorek, Bartosz       1

    + top 10 bugs confirmers:
       *UNKNOWN*               12
       Stéphane Guillou        7
       Dieter                  5
       Heiko Tietze            5
       Ilmari Lauhakangas      5
       Robert Großkopf         5
       m.a.riosv               4
       Vernon, Stuart Foote    3
       Henschel, Regina        2
       Kaganski, Mike          2


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Xisco Fauli            2
        Aron Budea             1
        Kira Tubo              1
        Kaganski, Mike         1
        Stéphane Guillou       1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Xisco Fauli            2
        Aron Budea             1
        Kira Tubo              1
        Kaganski, Mike         1
        Stéphane Guillou       1


* all bugs tagged with 'regression'
   + 1236(+3) bugs open of 13302(+10) total 23(-1) high prio.

     done by:
        m.a.riosv              2
        Dieter                 1
        Kaganski, Mike         1
        Robert Großkopf        1
        Telesto                1
        Timur                  1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 16(-1)
     Calc          - 2(+0)
     Impress       - 2(+0)
     LibreOffice   - 1(+0)
     UI            - 1(+0)

   by OS:
     All           - 18(+0)
     Linux         - 3(+0)
     Mac OS X      - 0(+0)
     Windows       - 2(-1)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 437(+0)
     Calc                     - 225(+2)
     Impress                  - 127(+0)
     Draw                     - 53(+2)
     LibreOffice              - 53(+0)
     Writer: docx filter      - 45(+0)
     Crashes                  - 42(+0)
     Base                     - 40(+0)
     UI                       - 37(+0)
     Borders                  - 35(+0)
     Writer: perf             - 35(+0)
     Writer: other filter     - 30(+0)
     Chart                    - 24(+0)
     Printing and PDF export  - 24(+0)
     RTL                      - 23(+0)
     filters and storage      - 22(+0)
     BASIC                    - 19(+0)
     Writer: doc filter       - 16(+0)
     graphics stack           - 12(+0)
     Formula Editor           - 7(+0)
     framework                - 3(+0)
     Extensions               - 2(+0)
     sdk                      - 2(+0)
     Linguistic               - 1(+0)



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux