New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

1 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1592140:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/drawinglayer/source/primitive2d/patternfillprimitive2d.cxx: 237 in drawinglayer::primitive2d::PatternFillPrimitive2D::create2DDecomposition(const drawinglayer::geometry::ViewInformation2D &) const()


________________________________________________________________________________________________________
*** CID 1592140:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
/drawinglayer/source/primitive2d/patternfillprimitive2d.cxx: 237 in drawinglayer::primitive2d::PatternFillPrimitive2D::create2DDecomposition(const drawinglayer::geometry::ViewInformation2D &) const()
231     
232                 // create one primitive for each matrix
233                 for(size_t a(0); a < aMatrices.size(); a++)
234                 {
235                     aRetval[a] = new TransformPrimitive2D(
236                         aMatrices[a],
>>>     CID 1592140:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
>>>     "aContent" is passed-by-value as parameter to "drawinglayer::primitive2d::TransformPrimitive2D::TransformPrimitive2D(basegfx::B2DHomMatrix, drawinglayer::primitive2d::Primitive2DContainer &&)" when it could be moved instead.
237                         Primitive2DContainer(aContent));
238                 }
239     
240                 // transform result which is in unit coordinates to mask's object coordinates
241                 {
242                     const basegfx::B2DHomMatrix aMaskTransform(


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNnPiSHxWPOELPnIxzXoBNaw-3Dtz1R_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiZjg2Q2TJLdTnF-2B9XFDtNnn7ZwF3iYbeyhd4IuSBeG6GhFOROVKZeGU-2Bn2kqQJh9KOx-2Bg78lyJNUvgB8bzjaslJyPbolkCmGdsj6dNoJ92d2GYkFpA54lTi-2BlWlAhXyTPlLgSn12O-2FJyo5xLYnr2AgL-2FvdcOcJ90t21PpSHx9VYg-3D