ESC meeting minutes: 2024-01-25

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Present:
    + Caolan, Cloph, Heiko, Olivier, Ilmari, Stephan, Stephane, Xisco, Hossein, Miklos, Michael W, Michael S, Gabriel

* Completed Action Items:
    + try to restore source code links in crashreports (Cloph)
      + done, for new reports
      + also fixed 24.2 reports
    + look at missing bundled python in bibisect binaries (Xisco)
      + see mailing list post

* Pending Action Items:

* Release Engineering update (Cloph)
    + 7.6: 7.6.5 RC1 in 1 week
      + plan to tag on Tuesday
    + 24.2: RC 3 this week, later today
      + open reviews: <https://gerrit.libreoffice.org/c/core/+/162546>
      + libreoffice-24-2-0 branch, needs +2 reviews
      + late features:
        + MAR updates (Stephan)
        + still need to put that in place (Cloph)
          + in practice, this is only needed for .1 (Stephan)
          + good to check the rc2 -> rc2 already (Cloph)
    + Jenkins config read permission, is that good to not have? (Miklos)
      + ${LODE_HOME}/bin/tb_slave_wrapper --real --mode=config --clean (Cloph)
      + Config=windows_msc_dbgutil_32 , Config=linux_clang_dbgutil_64
        Config=macosx_clang_dbgutil , Config=linux_gcc_release_64
        → determines what distro-config is used from distro-configs/Jenkins
      + ${LODE_HOME}/bin/kill-wrapper "${LODE_HOME}/bin/tb_slave_wrapper --real --mode=config --clean" 900
      + think this is all the non-trivial bits (Cloph)
        (with_jdk_home is set to older JDK for 7-6 branch for example, or android builds set PATH=${PATH}:/opt/rh/rh-python38/root/usr/bin in addition)
      + jenkins builders have LODE_HOME environment variable set (cloph)
        → that e.g. has some special treatment in configure.ac to --enable-werror

* Documentation (Olivier)
    + Helpcontent2
      + Updated in Help for UNO commands (ohallot)
      + Updates in links (D. Maddern)
      + Fix on macOS-specific Help (P. Luby)
    + Guides
      + Published Getting Started Guide 7.6 (R. Thornton, V. Slavitskaya, + ... )
         https://blog.documentfoundation.org/blog/2024/01/25/new-getting-started-guide-for-libreoffice-7-6/
    + Most annoying bug for Guides:
        + https://bugs.documentfoundation.org/show_bug.cgi?id=159366
          Loss of list formatting on reloading document

    + Bugzilla Documentation statistics
        275(275) bugs open
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
           created      5(1)    15(3)      35(-1)    246(-1)
         commented     16(10)   62(9)     158(-1)    961(4)
          resolved      1(0)     8(1)      14(-1)    130(0)
    + top 10 contributors:
          Nabet, Julien made 13 changes in 1 month, and 46 changes in 1 year
          Faisal made 6 changes in 1 month, and 6 changes in 1 year
          Heiko Tietze made 5 changes in 1 month, and 105 changes in 1 year
          Ilmari Lauhakangas made 5 changes in 1 month, and 90 changes in 1 year
          Olivier Hallot made 5 changes in 1 month, and 367 changes in 1 year
          Stéphane Guillou made 5 changes in 1 month, and 278 changes in 1 year
          Kaganski, Mike made 4 changes in 1 month, and 66 changes in 1 year
          libretist made 4 changes in 1 month, and 4 changes in 1 year
          Telesto made 4 changes in 1 month, and 9 changes in 1 year
          Eivind Samseth made 3 changes in 1 month, and 3 changes in 1 year

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        249(249) (topicUI) bugs open, 59(59) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week    1 month    3 months   12 months
             added      2(-4)     16(-8)     28(-8)      41(-7)
         commented     39(-46)   156(-56)   563(-67)   2175(-60)
           removed      0(0)       0(-1)      3(0)       14(0)
          resolved      7(3)      18(2)      68(1)      319(0)
    + top 10 contributors:
          Heiko Tietze made 101 changes in 1 month, and 1289 changes in 1 year
          Stéphane Guillou made 53 changes in 1 month, and 612 changes in 1 year
          Eyal Rozenberg made 21 changes in 1 month, and 211 changes in 1 year
          Dieter made 13 changes in 1 month, and 209 changes in 1 year
          Telesto made 13 changes in 1 month, and 48 changes in 1 year
          Jim Raykowski made 12 changes in 1 month, and 30 changes in 1 year
          Vernon, Stuart Foote made 11 changes in 1 month, and 279 changes in 1 year
          Samuel Mehrbrodt made 8 changes in 1 month, and 18 changes in 1 year
          Seth Chaiklin made 8 changes in 1 month, and 81 changes in 1 year
          Akshay Warrier made 7 changes in 1 month, and 7 changes in 1 year
    + [Bug 159299] Usability: Menu item "View/Field Names" and causing confusion,
           suggest removing entry and keyboard shortcut
    + [Bug 159100] Sidebar Hide/Show widget, the Show action is active beyond its
           button bounds
 -> + [Bug 159091] UI: The function of the Automatic recovery dialog was interrupted
           dialog is obscure
           + no documentation on how exactly the recovery works
    + [Bug 159277] It would be nice to have an exclude file type option from
           Recent Files.
    + [Bug 159261] Use Noto family fonts as default fonts for all the LibreOffice tools
    + [Bug 159257] Improve number of documents shown in recent document lists

    + l10n survey started, link is provided to the l10n contributors

* Crash Testing (Caolan)
    + 5(-22) import failure, 1(-21) export failures
      - https://wiki.documentfoundation.org/Development/Crashtesting
      - one new crash, fixed merged now
    + 8 coverity issues
      - no std::move warnings left, all memory [illegal access/corruption] claims now
    + 4 ossfuzz issues, no crashes

* Crash Reporting (Xisco)
    + 7.5.9.2    3442(+782)
    + 7.6.3.2    6035(+642)
    + 7.6.4.1    16591(+3507)
    + 24.2.0.2    40(+0)


        + One crash in 24.2 found and fixed (Xisco)


* Mentoring (Hossein)
  * Reviewed submissions from the newcomers
  * Finalized and published a new blog post on gbuild
    gbuild: LibreOffice build system – part 2 (some tips and tricks)
    https://dev.blog.documentfoundation.org/2024/01/25/gbuild-libreoffice-build-system-part-2/
  * Drafted another blog post on gbuild macros
    gbuild: LibreOffice build system – part 3 (JUnitTest gbuild macros)
    https://dev.blog.documentfoundation.org/?p=1089&preview=1&_ppp=e0df561064
  * Calls with the Python volunteers
    https://www.volunteermatch.org/search/opp3746451.jsp
    -> 1 porting is done
  Q: Possibility of moving all SDK examples to an external repo:
     https://git.libreoffice.org/sdk-examples/
     + we try to build (but not run) them during 'make check' (Stephan)
       + that would speak against moving them out
     + have it as a submodule? (Hossein)
     + what would be the benefit? (Stephan)
       + work on examples without cloning core.git (Hossein)
       + to work with the SDK, no need to build the code
       + to avoid cloning core? (Stephan)
         + also cygwin can be avoided (Hossein)
     + what would be the benefit of a submodule? (Ilmari)
       + still build-test it, if it has to be an external repo (Miklos)
     + would prefer either it separated or have it in core.git (Stephan)
       + think there is value in having the examples in the SDK (Hossein)
     + think there is some value in nagging people towards the core (Miklos)
     + think --enable-odk is already disabled by default these days (Michael S)
       + not sure I follow the example (Stephan)
       + the whole sdk is not built by default (Michael S)
       + and pulling into the SDK would be additional effort (Stephan)
     + do we not want to the examples from the SDK, correct? (Miklos)
       + we don't want to lose it, sure (Hossein)
     => good to leave things as-is

          committer...   1 week     1 month     3 months    12 months
                  open      71(0)      134(5)      141(11)      141(11)
               reviews     450(-28)   1354(32)    3336(108)   11814(88)
                merged     267(-35)   1061(-30)   3234(67)    12294(-38)
             abandoned      18(4)       62(1)      220(7)       654(0)
           own commits     157(-50)    725(-40)   2475(-66)    9696(-93)
        review commits      76(-23)    310(1)      814(22)     3028(38)
        contributor...   1 week      1 month      3 months    12 months
                  open      27(-16)     256(-25)     291(-11)     292(-11)
               reviews     742(-140)   2704(-150)   7868(-96)   30358(-206)
                merged      28(0)       100(-14)     346(-88)    2271(-70)
             abandoned       6(-2)       43(-7)      125(2)       538(3)
           own commits      43(7)       127(-3)      266(22)     1017(28)
        review commits       0(0)         0(0)         0(0)         0(0)
    + easyHack statistics:
       needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 320(320)
       total 407(407)   assigned 22(22)   open 354(354)
    + top 10 contributors:
          Armin Le Grand (allotropia) made 17 patches in 1 month, and 79 patches in 1 year
          + ideally this list doesn't feature committers (Hossein)
            + best to look at that yourself if interested (Miklos)
          Srebotnjak, Martin made 8 patches in 1 month, and 19 patches in 1 year
          Kira Tubo made 8 patches in 1 month, and 10 patches in 1 year
          Weblate made 6 patches in 1 month, and 16 patches in 1 year
          Matt K made 6 patches in 1 month, and 20 patches in 1 year
          Dione Maddern made 6 patches in 1 month, and 8 patches in 1 year
          Luv Sharma made 6 patches in 1 month, and 6 patches in 1 year
          Eli Schwartz made 5 patches in 1 month, and 5 patches in 1 year
          Bogdan B made 4 patches in 1 month, and 20 patches in 1 year
          Juan José González made 4 patches in 1 month, and 7 patches in 1 year
    + top 10 reviewers:
          + ideally this should not count self-reviews (Hossein)
          Caolán McNamara made 134 review comments in 1 month, and 1000 in 1 year
          Michael Stahl made 110 review comments in 1 month, and 1096 in 1 year
          Xisco Fauli made 98 review comments in 1 month, and 812 in 1 year
          Ilmari Lauhakangas made 94 review comments in 1 month, and 456 in 1 year
          Vajna, Miklos made 92 review comments in 1 month, and 944 in 1 year
          Thorsten Behrens made 84 review comments in 1 month, and 608 in 1 year
          Adolfo Jayme Barrientos made 76 review comments in 1 month, and 570 in 1 year
          Hossein made 62 review comments in 1 month, and 276 in 1 year
          Weghorn, Michael made 54 review comments in 1 month, and 320 in 1 year
          Kaganski, Mike made 54 review comments in 1 month, and 440 in 1 year
    + Patches automatically abandoned:
        tdf#147021 Use std::size() and std::ssize() in filter ( Taichi Haradaguchi )
            - https://gerrit.libreoffice.org/#/c/157942
        vcl: rename SalLayout to SalTextLayout ( Chris Sherlock )
            - https://gerrit.libreoffice.org/#/c/158584
        vcl: introduce SalTextLayoutGlyphs::GetFont() ( Chris Sherlock )
            - https://gerrit.libreoffice.org/#/c/158965
        tdf#152155 vcl: clean-up gtk listbox position fix ( László Németh )
            - https://gerrit.libreoffice.org/#/c/159064
        vcl: extract lcl_GetFormatLines() ( Chris Sherlock )
            - https://gerrit.libreoffice.org/#/c/159605
        tdf#129608 update comments in Navigator ( Oliver Specht )
            - https://gerrit.libreoffice.org/#/c/159731
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Akshay Warrier
          Eli Schwartz
          Seturaj Matroja
          Bayram Çiçek (Collabora)

* Outreachy (Ilmari)
  + work is ongoing & is on track.

* GSoC (Ilmari)
    * Organisation application sent
      + https://developers.google.com/open-source/gsoc/timeline
    * More ideas welcome https://wiki.documentfoundation.org/Development/GSoC/Ideas

* Commit Access
  + Matt K (Xisco)
    + Mike K is sponsoring
AI: grant the permission (Cloph)
AI: send welcome mail (Xisco)

* Developer Certification (Stephan/Miklos/László/Gabriel)
  + resting since: 14 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
gerrit_android_aarch64     jobs: 181 ok: 169 ko:  10 fail ratio: 5.52% mean_ok:  11 ( 15) median_ok:   8 ( 11)
gerrit_android_arm         jobs: 183 ok: 172 ko:   8 fail ratio: 4.37% mean_ok:  11 ( 15) median_ok:   8 ( 11)
gerrit_android_x86         jobs: 181 ok: 168 ko:  11 fail ratio: 6.08% mean_ok:  10 ( 14) median_ok:   7 ( 10)
gerrit_android_x86_64      jobs: 182 ok: 173 ko:   4 fail ratio: 2.20% mean_ok:  10 ( 15) median_ok:   8 ( 10)
gerrit_linux_clang_dbgutil jobs: 376 ok: 276 ko:  92 fail ratio: 24.47% mean_ok:  39 ( 43) median_ok:  34 ( 37)
gerrit_linux_gcc_release   jobs: 412 ok: 351 ko:  41 fail ratio: 9.95% mean_ok:  19 ( 22) median_ok:  15 ( 17)
gerrit_mac                 jobs: 362 ok: 324 ko:  27 fail ratio: 7.46% mean_ok:  52 ( 53) median_ok:  47 ( 47)
gerrit_windows             jobs: 430 ok: 316 ko:  94 fail ratio: 21.86% mean_ok:  61 ( 75) median_ok:  48 ( 60)
gerrit_master_ml           jobs: 432 ok: 242 ko: 152 fail ratio: 35.19% mean_ok:  99 ( 99) median_ok:  85 ( 86)
gerrit_master              jobs:  50 ok:  29 ko:  20 fail ratio: 40.00% mean_ok:  75 ( 75) median_ok:  69 ( 69)
gerrit_master_seq          jobs: 379 ok: 213 ko: 129 fail ratio: 34.04% mean_ok: 102 (102) median_ok:  89 ( 89)
   + https://dev-www.libreoffice.org/tmp/gerrit_240125.html
   + tests that failed more than twice in last seven days:
      3 aborted by jenkins job timeout                gerrit_windows
      3 JunitTest_sw_complex                gerrit_linux_clang_dbgutil
      3 PythonTest_pyuno_pytests_testssl                gerrit_windows
      3 UITest_signatureLine                gerrit_linux_clang_dbgutil
      4 JunitTest_chart2_unoapi                gerrit_linux_clang_dbgutil
      4 UITest_sw_navigator                gerrit_linux_clang_dbgutil
      6 CppunitTest_sc_tiledrendering                gerrit_linux_gcc_release
     11 CppunitTest_sw_a11y                gerrit_windows
     11 CppunitTest_test_a11y                gerrit_windows
     12 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
     + situation normalized again after reverting the firebird update (Cloph)
     + nothing really unusual happened otherwise

* What’s cooking (Miklos)
    + A11y update (Michael W)
      + fixed duplicated shortcut handling w/ a11y enabled in Qt-based VCL plugins
        (tdf#159333)
      + small fixes related to shape handling
      + plan to get back to tdf#135236, support for reporting spelling errors for
        editengine via text attribute on a11y layer, some related fixes
   + fonts on Mac (Cloph)
      + document-support fonts installed (by macOS) but not visible to LO
        + e.g. could be used for font fallback but maybe not offer them on the UI?
        + probably useful to ask input from Patrick (Miklos)
        + catch is to ideally not offer these for new documents (Cloph)
   + Calc cell text editeng paste (Miklos)
     + HTML paste now works, only ODF/RTF worked previously
   + ODF wholesome encryption is now enabled by default (Xisco)
     + thanks to Michael S for the work
     + only towards 24.8, so if you are on 24.2, you should be able to open your encrypted documents
   + tools -> options search (Hossein)
     + think the latency is too high
       + Opening the dialog for the first time
     + would measure the benefit of search vs cost of waiting that long
     + suggest to consider this for 24.2.1
     + Will file a bug and CC author (Hossein)

* FOSDEM 2024 - Hackfest Feb. 5/6 at ICAB Incubator
  + https://wiki.documentfoundation.org/Events/2024/FOSDEM
  + if you attend the community dinner and/or the hackfest, please add your name (Cloph)
    + failing that, at least mail Italo

* COOL Days 2024 (Miklos)
  + good to mention it here (Heiko)
  + https://www.collaboraoffice.com/cool-days-2024/ (Cambridge): 8th -> 10th April

* QA update (Xisco)
    + UNCONFIRMED: 1093 (-13)
        + enhancements: 258  (+7)
        + needsUXEval: 11 (-6)
        + haveBackTrace: 12 (+1)
        + needsDevAdvice: 43 (+2)
        + documentation:  5 (-1)
        + android:  0 (+0)
        + iOS:  0 (+0)
        + Online:  10 (+0)


    + Most pressing bugs:
     New:

    None


    + New high severity bugs of the week:
        + CRASH: inserting page break and undoing
            + https://bugs.documentfoundation.org/show_bug.cgi?id=149499
            + already assigned to Matt K

        + FILESAVE PDF Tagged PDF export of media file fails to create PDF
            + https://bugs.documentfoundation.org/show_bug.cgi?id=159094
            + bisected to Michael S

* QA stats (Stéphane)
    + Weekly focus: Templates. https://pad.documentfoundation.org/p/qa
    + Spent some time on text wrapping in Calc cells this week
    + Some interesting consolidated/reviewed bugs:
        + character and word count in statusbar does not update frequently enough for shift selection: https://bugs.documentfoundation.org/show_bug.cgi?id=98889
        + just opening the Standard Filter dialog makes a database range extend: https://bugs.documentfoundation.org/show_bug.cgi?id=127419
        + crashes and artefacts when inserting shape from Gallery, comments welcome on how to solve the drag-and-drop action: https://bugs.documentfoundation.org/show_bug.cgi?id=132810
          + drag&drop from the gallery is quite painful (Heiko)
            + the built-in gallery is read-only, which is not nice
    + Weekly summary: https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +120  +18 (-130) overall)
      many thanks to the top bug squashers:
       Buovjaga                20
       Mike Kaganski           16
       Gabor Kelemen (allotropia) 11
       QA Administrators       8
       m_a_riosv               7
       Heiko Tietze            6
       Justin L                5
       Michael Stahl (allotropia) 5
       Rafael Lima             5
       Stéphane Guillou (stragu) 5

    + top 10 bugs reporters:
       Gabor Kelemen (allotropia) 11
       Rafael Lima             5
       Heiko Tietze            4
       Mike Kaganski           3
       Zach Simmons            3
       Justin L                2
       Michael Weghorn         2
       Oliver Specht (CIB)     2
       Telesto                 2
       Ulrich Windl            2

    + top 10 bugs fixers:
       Kaganski, Mike          11
       Kelemen, Gabor          9
       Michael Stahl           5
       Heiko Tietze            4
       Justin Luth             3
       Rafael Lima             3
       Samuel Mehrbrodt        3
       Nabet, Julien           2
       Nagy Tibor              2
       Sarper Akdemir          2

    + top 10 bugs confirmers:
       Ilmari Lauhakangas      23
       Heiko Tietze            10
       m.a.riosv               10
       Stéphane Guillou        8
       Nabet, Julien           5
       Ady                     3
       Kaganski, Mike          3
       Raal                    3
       Vernon, Stuart Foote    3
       *UNKNOWN*               2


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Stéphane Guillou       2
        Ilmari Lauhakangas     1
        Kelemen, Gabor         1
        piotr.7706             1
        Raal                   1
        Telesto                1
        Xisco Fauli            1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Stéphane Guillou       2
        Ilmari Lauhakangas     1
        Kelemen, Gabor         1
        piotr.7706             1
        Raal                   1
        Telesto                1
        Xisco Fauli            1


* all bugs tagged with 'regression'
   + 1254(-6) bugs open of 13138(+14) total 20(+0) high prio.

     done by:
        Ilmari Lauhakangas     3
        Stéphane Guillou       3
        Kelemen, Gabor         1
        m.a.riosv              1
        Telesto                1
        Vernon, Stuart Foote   1
        Xisco Fauli            1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 13(-1)
     Calc          - 2(+0)
     Impress       - 1(+0)
     LibreOffice   - 1(+0)
     Printing and PDF export - 1(+1)
     UI            - 1(+0)

   by OS:
     All           - 15(+0)
     Linux         - 4(+0)
     Mac OS X      - 0(+0)
     Windows       - 1(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 447(-4)
     Calc                     - 227(-3)
     Impress                  - 130(+0)
     LibreOffice              - 52(+1)
     Draw                     - 51(-1)
     Crashes                  - 50(-1)
     Writer: docx filter      - 43(+0)
     Base                     - 39(-1)
     UI                       - 39(+0)
     Borders                  - 35(+0)
     Writer: perf             - 35(+0)
     Writer: other filter     - 31(+0)
     Printing and PDF export  - 26(+0)
     Chart                    - 24(+0)
     RTL                      - 23(+0)
     filters and storage      - 20(-1)
     BASIC                    - 19(+0)
     Writer: doc filter       - 16(+0)
     graphics stack           - 11(+0)
     Formula Editor           - 7(+0)
     framework                - 5(+0)
     Extensions               - 2(+0)
     sdk                      - 2(+0)
     Linguistic               - 1(+0)



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux