ESC meeting minutes: 2024-01-04

Miklos Vajna <vmiklos@xxxxxxxxxxxxx> · Thu, 4 Jan 2024 16:34:59 +0100



* Present:
    + Heiko, Olivier, Stephane, Thorsten, Hossein, Ilmari, Stephan, Xisco, Michael S, Miklos

* Completed Action Items:

* Pending Action Items:

* Release Engineering update (Cloph)
    + 7.6: 7.6.5 RC1 in 4 weeks
    + 24.2: RC 2 next week
      + late features (Michael S)
        + working on the new ODF encryption (done)
        + MSI custom action for MAR, waiting for Gerrit (Stephan)
    + RCs not announced at <https://www.libreoffice.org/download/pre-releases/>?
      (Stephan)
      + says "No RC is currently available for the 7.3/7.4 codeline"
        + will check if the new RC shows up there or not (Xisco)
      + build fails signing Argon2OptDll.dll with --enable-windows-build-signing (Xisco)

          + More info: https://gerrit.libreoffice.org/c/core/+/161388

     + Thanks to Cloph for finding a solution.

     + aarch64 and x86 build are done. x64 is on going.

     + expecting the builds to arrive tonight


    + key generation for MAR, when TDF binaries are done (Xisco)

      + see my request? (Stephan)

      + yes (Xisco)


* Documentation (Olivier)
    + New Help -  No news
    + Helpcontent2
       + More fixes in UI - Help for Calc (ohallot)
          + many uno commands not on good target/missing
          + some Notebook bar menu commands not linked to Help page
       + Pages housekeeping (A. Gelmini,  Taichi Haradaguchi)
    + Guides
       + work in progress.
       + Open issues on guides
          + Web output (include grid for page style)
          + translate-ability

    + Bugzilla Documentation statistics
        274(274) bugs open
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
           created      3(1)    14(-1)     39(-3)    255(-4)
         commented     14(9)    60(9)     151(3)     967(5)
          resolved      3(2)     8(3)      15(0)     135(-1)
    + top 10 contributors:
          Stéphane Guillou made 15 changes in 1 month, and 329 changes in 1 year
          Nabet, Julien made 14 changes in 1 month, and 42 changes in 1 year
          Caolán McNamara made 4 changes in 1 month, and 4 changes in 1 year
          Seth Chaiklin made 4 changes in 1 month, and 319 changes in 1 year
          libretist made 4 changes in 1 month, and 4 changes in 1 year
          nobu made 4 changes in 1 month, and 6 changes in 1 year
          Eivind Samseth made 3 changes in 1 month, and 3 changes in 1 year
          *UNKNOWN* made 3 changes in 1 month, and 4 changes in 1 year
          Balland-Poirier, Laurent made 3 changes in 1 month, and 3 changes in 1 year
          steve made 3 changes in 1 month, and 10 changes in 1 year

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        252(252) (topicUI) bugs open, 58(58) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week    1 month    3 months   12 months
             added      5(-4)     24(3)      28(4)       40(4)
         commented     17(-13)   258(-46)   574(-10)   2237(0)
           removed      0(-1)      2(0)       4(0)       14(0)
          resolved      4(3)      25(-4)     73(1)      331(0)
    + top 10 contributors:
          Heiko Tietze made 124 changes in 1 month, and 1335 changes in 1 year
          Stéphane Guillou made 85 changes in 1 month, and 625 changes in 1 year
          Vernon, Stuart Foote made 39 changes in 1 month, and 309 changes in 1 year
          Eyal Rozenberg made 33 changes in 1 month, and 210 changes in 1 year
          Dieter made 29 changes in 1 month, and 226 changes in 1 year
          Ilmari Lauhakangas made 20 changes in 1 month, and 225 changes in 1 year
          Rafael Lima made 16 changes in 1 month, and 125 changes in 1 year
          Seth Chaiklin made 15 changes in 1 month, and 81 changes in 1 year
          m.a.riosv made 10 changes in 1 month, and 67 changes in 1 year
          Roman Kuznetsov made 9 changes in 1 month, and 106 changes in 1 year
    + [Bug 158992] "Spotlight" Should Only Number/Color Styles That Actually
           Appear in Document
    + [Bug 146466] Inconsistent choices of borders between toolbar and sidebar
    + [Bug 158791] Styles deck: actually hide hidden leaf styles in Hierarchical view
    + [Bug 158958] Comment marker makes it difficult to see the data in a cell
 -> + [Bug 127054] Whitespace is not Hidden if Column Breaks are Used
 -> + [Bug 158940] Nomenclature: "Area" commands not homogeneous in UI for
           Writer Sections
      + also have an other naming problem (Olivier)
        + what is "deck", what is a "panel", and what is a "pane"?
        + have some documentation on this (Heiko)
          + https://wiki.documentfoundation.org/Design/Guidelines/Sidebar
    + [Bug 158624] text file format dialogue on save -- ODF file format?
    + [Bug 158689] Calc's double-click on column header boundary always uses the
           default +2 mm for optimal width, instead of what is defined in
           Format>Columns>Optimal Width
    + [Bug 135063] Calc column width auto fit not working when selection active
           outside column
    + [Bug 158682] Calc: Move rows with protected cells does not give warning
    + [Bug 158877] Non-corrective Autoformat settings can't just be placed
           under AutoCorrect
    + [Bug 158876] Autocorrect options are very confusing and difficult to use
    + [Bug 158869] [UI] Normalize command string for Table Styles
    + [Bug 158864] Many/most dark mode UI elements have too strong a contrast
    + [Bug 158545] UI: Original size button in image properties -> position and
           size tab doesn't restore original size for paper size exceeding images
           in Writer (and breaks image ratio)
    + [Bug 158838] UNO action to toggle applied styles like <emphasis> and <strong>
    + [Bug 158798] Nomenclature: "Arrange" commands not homogeneous in UI

    + heads-up for Caolan: some fallout from bug 150786 (standard theme) in
      bug 153343, bug 152973, bug 156707, bug 155636, bug 155637, bug 156962

* Crash Testing (Caolan)
    + 35(-20) import failure, 14(-4) export failures
    + ??? coverity issues
    + Google / ossfuzz: ?? fuzzers active now

* Crash Reporting (Xisco)
    + 7.5.8.2    3691(+276)
    + 7.5.9.2    1167(+368)
    + 7.6.2.1    35455(+1255)
    + 7.6.3.2    4378(+395)
    + 7.6.4.1    7075(+2044)

    + Most reported crash in 7.6.4

    - https://crashreport.libreoffice.org/stats/signature/static%20bool%20cppu::idefaultConstructElements(struct%20_sal_Sequence%20*%20*,%20struct%20_typelib_TypeDescriptionReference%20*,%20long,%20long,%20long)

    - 789a737ac92c4f2b0eb9820b99c43cc8253c8b29 could fix it. Thanks to Armin.

    - Plan to backport it to 7.6 branch (Xisco)


* Mentoring (Hossein)
  + Focused on reviewing unmerged patches
   + Done around 10, 8 merged
  + Added a new EasyHack
    Make thumbnail generation multi-threaded
    https://bugs.documentfoundation.org/show_bug.cgi?id=158985
    i.e. not block the UI
    + would be also interesting topic for a blog post (Heiko)
      + it's a rather reqular need to run something in the background
      + threading is tricky, not sure if such tasks are difficultyMedium or difficultyInteresting
  + Added a new draft blog post
    Make Impress Master Slides copyable - difficulty interesting EasyHack
          committer...   1 week      1 month     3 months    12 months
                  open      54(-19)     135(-18)    138(-21)     138(-21)
               reviews     262(-118)   1222(-82)   3064(-14)   11650(20)
                merged     232(2)      1078(-40)   3104(37)    12377(116)
             abandoned      15(-1)       91(10)     215(7)       647(3)
           own commits     169(25)      758(-36)   2468(10)     9752(86)
        review commits      49(0)       261(-5)     718(2)      2932(15)
        contributor...   1 week      1 month     3 months    12 months
                  open      24(-214)    310(-9)     311(-11)     312(-11)
               reviews     660(-104)   2914(-96)   7814(14)    30568(188)
                merged      19(-11)     107(8)      408(4)      2316(12)
             abandoned       7(-8)       42(5)      116(1)       529(6)
           own commits      28(-4)      124(17)     257(14)     1039(19)
        review commits       0(0)         0(0)        0(0)         0(0)
    + easyHack statistics:
       needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 320(320)
       total 408(408)   assigned 21(21)   open 357(357)
    + top 10 contributors:
          Stéphane Guillou made 13 patches in 1 month, and 56 patches in 1 year
          Armin Le Grand (allotropia) made 12 patches in 1 month, and 69 patches in 1 year
          Weblate made 9 patches in 1 month, and 13 patches in 1 year
          Bogdan B made 5 patches in 1 month, and 21 patches in 1 year
          Sahil Gautam made 5 patches in 1 month, and 6 patches in 1 year
          Luv Sharma made 5 patches in 1 month, and 5 patches in 1 year
          Dr. David Alan Gilbert made 5 patches in 1 month, and 23 patches in 1 year
          Matt K made 4 patches in 1 month, and 14 patches in 1 year
          Sophia Schroeder made 4 patches in 1 month, and 50 patches in 1 year
          Srebotnjak, Martin made 3 patches in 1 month, and 15 patches in 1 year
    + top 10 reviewers:
          Thorsten Behrens made 116 review comments in 1 month, and 594 in 1 year
          Caolán McNamara made 88 review comments in 1 month, and 896 in 1 year
          Kaganski, Mike made 82 review comments in 1 month, and 440 in 1 year
          Xisco Fauli made 76 review comments in 1 month, and 782 in 1 year
          Vajna, Miklos made 74 review comments in 1 month, and 964 in 1 year
          Ilmari Lauhakangas made 70 review comments in 1 month, and 418 in 1 year
          Grandin, Noel made 68 review comments in 1 month, and 576 in 1 year
          Weghorn, Michael made 64 review comments in 1 month, and 290 in 1 year
          Olivier Hallot made 62 review comments in 1 month, and 304 in 1 year
          Hossein made 54 review comments in 1 month, and 266 in 1 year
    + Patches automatically abandoned:
        auto-disable system-harfbuzz with --enable-dbgutil ( Lionel Mamane )
            - https://gerrit.libreoffice.org/#/c/156681
        tdf#138453 c-authored  shadimabdrawy1999@xxxxxxxxx ( Aml )
            - https://gerrit.libreoffice.org/#/c/158412
        test gb_CppunitTest_set_non_application_font_use ( Xisco Fauli )
            - https://gerrit.libreoffice.org/#/c/158551
        vcl: add test for an invalid index in OutputDevice::GetTextBreak() ( Chris Sherlock )
            - https://gerrit.libreoffice.org/#/c/158575
        vcl: Implement blend modes in AnimationRenderer ( Paris Oplopoios )
            - https://gerrit.libreoffice.org/#/c/158627
        tdf#157797: Add unittest ( Willian Pessoa )
            - https://gerrit.libreoffice.org/#/c/158656
        CppunitTest_sw_layoutwriter2: split in two ( Xisco Fauli )
            - https://gerrit.libreoffice.org/#/c/158740
        Print dlg: cancel button shouldn't save any settings ( Katarina Behrens )
            - https://gerrit.libreoffice.org/#/c/43803
        Inherit SwGrfShell from SwFrameShell ( Maxim Monastirsky )
            - https://gerrit.libreoffice.org/#/c/62379
        Do not merge tdf#120840: window-modal fpicker ( Katarina Behrens )
            - https://gerrit.libreoffice.org/#/c/65004
        tdf#45904: move java based api tests to c++ ( Meryem Ezber )
            - https://gerrit.libreoffice.org/#/c/67932
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Declan Fodor
          Jamie Douglass
          Luv Sharma

* Outreachy (Ilmari)
    + running according to plan, students are busy
    + https://khushishikhu.hashnode.dev/
    + https://omkaracharekar.hashnode.dev/

* Commit Access

* Developer Certification (Stephan/Miklos/László)
  + Thorsten offering to step down before next cert round
  + resting since: 11 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
   + tests that failed more than twice in last seven days
      3 CppunitTest_services        gerrit_linux_gcc_release
      4 CppunitTest_writerperfect_writer        gerrit_windows
      5 CppunitTest_sw_ooxmlexport17        gerrit_mac
      6 CppunitTest_sd_uiimpress        gerrit_linux_gcc_release
     17 CppunitTest_test_a11y        gerrit_windows
     19 aborted by jenkins job timeout        gerrit_windows
     + last week was a quiet week, so less failures (Xisco)

* What’s cooking (Miklos)
    + A11y update (Michael W)

* QA update (Xisco)
    + UNCONFIRMED: 1062 (-20)
        + enhancements: 256  (+0)
        + needsUXEval: 17 (+2)
        + haveBackTrace: 12 (+0)
        + needsDevAdvice: 36 (+1)
        + documentation:  4 (+0)
        + android:  0 (+0)
        + iOS:  0 (+0)
        + Online:  10 (+0)


    + Most pressing bugs:
     New:
         None


    + New high severity bugs of the week:
        + Inertial scrolling switches to zoom if you start pressing a new shortcut key (cmd)
            + https://bugs.documentfoundation.org/show_bug.cgi?id=46429
          + not tagged as a regression

        + EDITING: Moving cells/columns/rows with drag and drop and modifier keys do not work as advertised (see comment #48)
            + https://bugs.documentfoundation.org/show_bug.cgi?id=58440
            + not marked as a regression

* QA stats (Stéphane)
    + Dashboard updated: https://stragu.shinyapps.io/lo_qa_dashboard/
    + Jérôme Bouat's reports about simplifying / reducing the size of installers: https://bugs.documentfoundation.org/buglist.cgi?email2=jerome.bouat%40laposte.net&emailreporter2=1&emailtype2=substring&f1=creation_ts&list_id=1685907&o1=greaterthan&query_format=advanced&resolution=---&resolution=FIXED&resolution=INVALID&resolution=WONTFIX&resolution=DUPLICATE&resolution=WORKSFORME&resolution=MOVED&resolution=NOTABUG&resolution=NOTOURBUG&resolution=INSUFFICIENTDATA&v1=2023-10-01
       + Comments welcome!
    + Weekly QA Focus resuming next week.
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +114  -25 (-103) overall)
      many thanks to the top bug squashers:
       QA Administrators       21
       Stéphane Guillou (stragu) 10
       Buovjaga                9
       eisa01                  9
       Mike Kaganski           7
       Gabor Kelemen (allotropia) 6
       V Stuart Foote          4
       Xisco Faulí             4
       m.a.riosv               4
       raal                    3

    + top 10 bugs reporters:
       Xisco Faulí             6
       Mike Kaganski           4
       Regina Henschel         4
       Tracey                  4
       nobu                    4
       Telesto                 3
       Devon Cooke             2
       Robert Großkopf         2
       Dan Dascalescu          1
       Hossein                 1

    + top 10 bugs fixers:
       Kaganski, Mike          6
       Kelemen, Gabor          5
       Balazs Varga            2
                               1
       *UNKNOWN*               1
       Caolán McNamara         1
       Eivind Samseth          1
       Hossein                 1
       Jim Raykowski           1
       Justin Luth             1

    + top 10 bugs confirmers:
       Stéphane Guillou        31
       m.a.riosv               17
       Dieter                  11
       Raal                    8
       Ady                     6
       Xisco Fauli             6
       Nabet, Julien           4
       Kaganski, Mike          3
       Ilmari Lauhakangas      2
                               1


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Raal                   8
        Xisco Fauli            7
        Stéphane Guillou       2
        Ilmari Lauhakangas     1
        Kelemen, Gabor         1
        Telesto                1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Raal                   9
        Xisco Fauli            7
        Ilmari Lauhakangas     1
        Kelemen, Gabor         1
        Stéphane Guillou       1
        Telesto                1


* all bugs tagged with 'regression'
   + 1245(+7) bugs open of 13083(+22) total 21(+1) high prio.

     done by:
        Stéphane Guillou         7
        Xisco Fauli              7
        Raal                     3
        Pruegsanusak, Korrawit   1
        Ilmari Lauhakangas       1
        Kelemen, Gabor           1
        Robert Großkopf          1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 14(+1)
     Calc          - 2(+0)
     Impress       - 2(+0)
     LibreOffice   - 1(+0)
     UI            - 1(+0)

   by OS:
     All           - 15(+1)
     Linux         - 5(+0)
     Mac OS X      - 0(+0)
     Windows       - 1(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 440(+8)
     Calc                     - 227(-1)
     Impress                  - 130(-2)
     Draw                     - 52(+2)
     LibreOffice              - 52(+1)
     Crashes                  - 48(+1)
     Writer: docx filter      - 43(+0)
     Base                     - 42(+1)
     UI                       - 39(-1)
     Borders                  - 35(+0)
     Writer: perf             - 35(+0)
     Writer: other filter     - 32(+0)
     Printing and PDF export  - 26(+0)
     RTL                      - 25(+0)
     Chart                    - 22(+0)
     filters and storage      - 21(+0)
     BASIC                    - 18(+0)
     Writer: doc filter       - 16(+0)
     graphics stack           - 12(+0)
     Formula Editor           - 7(+0)
     framework                - 5(+2)
     Extensions               - 2(+0)
     sdk                      - 2(+0)
     Linguistic               - 1(+0)