Re: MAKEFLAGS ignored?

[Dan Horák <dan@xxxxxxxx>]

On Fri, 15 Sep 2023 11:11:29 +0200
Michael Stahl <mst@xxxxxxxxxxxxxxx> wrote:

> hi Dan,
> 
> On 07/09/2023 13:36, Dan Horák wrote:
> > Hello,
> > 
> > I was trying to pass the "--keep-going" option to the Makefile via the
> > MAKEFLAGS [1] to get as much test failures as possible in a single run,
> > but it seems to be ignored. After reading the make manual for the value
> > function [2], I think GMAKE_OPTIONS definition should rather look like
> > 
> > -export GMAKE_OPTIONS?=-r$(if $(verbose),,s)$(value $(MAKEFLAGS))
> > +export GMAKE_OPTIONS?=-r$(if $(verbose),,s) $(value MAKEFLAGS)
> > 
> > What do you think?
> 
> this looks rather odd indeed, and i guess you're the first person to try 
> setting MAKEFLAGS manually.
> 
> probably it's best to change it as you suggest.

ok, https://gerrit.libreoffice.org/c/core/+/156942 then :-)


		Dan