New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1542448:  Null pointer dereferences  (REVERSE_INULL)
/cui/source/options/treeopt.cxx: 841 in OfaTreeOptionsDialog::selectFirstEntry()()


________________________________________________________________________________________________________
*** CID 1542448:  Null pointer dereferences  (REVERSE_INULL)
/cui/source/options/treeopt.cxx: 841 in OfaTreeOptionsDialog::selectFirstEntry()()
835                 {
836                     xEntry = xTreeLB->make_iterator();
837                     if (!xTreeLB->get_iter_first(*xEntry) || !xTreeLB->iter_next(*xEntry))
838                         xEntry.reset();
839                 }
840     
>>>     CID 1542448:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "xEntry" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
841                 if (!xEntry)
842                     return;
843     
844                 std::unique_ptr<weld::TreeIter> xParent(xTreeLB->make_iterator(xEntry.get()));
845                 xTreeLB->iter_parent(*xParent);
846                 xTreeLB->expand_row(*xParent);

** CID 1542447:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1542447:  Null pointer dereferences  (FORWARD_NULL)
/sc/source/ui/theme/ThemeColorChanger.cxx: 220 in sc::<unnamed>::changeSheets(ScDocShell &, ScTabViewShell *, ScDrawLayer *, const std::shared_ptr<model::ColorSet> &)()
214                     pView = pViewShell->GetScDrawView();
215     
216                 SdrPage* pPage = pModel->GetPage(static_cast<sal_uInt16>(nTab));
217                 SdrObjListIter aIter(pPage, SdrIterMode::DeepNoGroups);
218                 for (SdrObject* pObject = aIter.Next(); pObject; pObject = aIter.Next())
219                 {
>>>     CID 1542447:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "pView" to "updateSdrObject", which dereferences it.
220                     svx::theme::updateSdrObject(*pColorSet, pObject, pView, rDocShell.GetUndoManager());
221                 }
222     
223                 std::unique_ptr<SdrUndoGroup> pUndo = pModel->GetCalcUndo();
224     
225                 if (pUndo)

** CID 1542446:  Uninitialized variables  (UNINIT)


________________________________________________________________________________________________________
*** CID 1542446:  Uninitialized variables  (UNINIT)
/sc/source/ui/theme/ThemeColorChanger.cxx: 206 in sc::<unnamed>::changeSheets(ScDocShell &, ScTabViewShell *, ScDrawLayer *, const std::shared_ptr<model::ColorSet> &)()
200                         ScEditDataArray* pDataArray = pUndo->GetDataArray();
201     
202                         rDocument.ApplySelectionPattern(aNewPattern, aMark, pDataArray);
203     
204                         rDocShell.GetUndoManager()->AddUndoAction(std::move(pUndo));
205                     }
>>>     CID 1542446:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "aNewPattern.pName._M_payload._M_payload" when calling "~ScPatternAttr".
206                 }
207             }
208     
209             // Change all SdrObjects
210             {
211                 pModel->BeginCalcUndo(true);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DacUJ_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiRlmMPRrg5ltzIRs9dFvttPn1qIlOHBgq3lwvmLvdMiakh1ZnzQwId1VcG2xuTBe1m3U6ViOGvz-2Ff-2BuZsVy83vqDBd5iLHYuKvm9dGZpQyBu1pUcrwxU9IFTjxANiZBsUfY-2FpEhwqQ0LeTlgwyxzqlmJE5B1ql-2FdGV-2FpJFKGnzlI-3D