New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1539913:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/vcl/animate/Animation.hxx: 33 in ()


________________________________________________________________________________________________________
*** CID 1539913:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/vcl/animate/Animation.hxx: 33 in ()
27     
28     #define ANIMATION_TIMEOUT_ON_CLICK 2147483647L
29     
30     class AnimationRenderer;
31     struct AnimationData;
32     
>>>     CID 1539913:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Animation" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalues, where a move assignment may be faster.
33     class VCL_DLLPUBLIC Animation
34     {
35     public:
36         Animation();
37         Animation(const Animation& rAnimation);
38         ~Animation();

** CID 1539912:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/vcl/task.hxx: 42 in ()


________________________________________________________________________________________________________
*** CID 1539912:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/vcl/task.hxx: 42 in ()
36         DEFAULT_IDLE,  ///< Default idle priority
37         LOWEST         ///< Low, very idle cleanup tasks
38     };
39     
40     #define PRIO_COUNT (static_cast<int>(TaskPriority::LOWEST) + 1)
41     
>>>     CID 1539912:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Task" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalues, where a move assignment may be faster.
42     class VCL_DLLPUBLIC Task
43     {
44         friend class Scheduler;
45         friend struct ImplSchedulerData;
46     
47         ImplSchedulerData *mpSchedulerData; ///< Pointer to the element in scheduler list

** CID 1539911:  Performance inefficiencies  (PASS_BY_VALUE)
/sw/source/uibase/shells/txtnum.cxx: 203 in SwTextShell::ExecEnterNum(SfxRequest &)::[lambda(int) (instance 1)]::operator ()(int) const()


________________________________________________________________________________________________________
*** CID 1539911:  Performance inefficiencies  (PASS_BY_VALUE)
/sw/source/uibase/shells/txtnum.cxx: 203 in SwTextShell::ExecEnterNum(SfxRequest &)::[lambda(int) (instance 1)]::operator ()(int) const()
197             if ( pPageItem )
198                 pDlg->SetCurPageId( pPageItem->GetValue() );
199     
200             auto pRequest = std::make_shared<SfxRequest>(rReq);
201             rReq.Ignore(); // the 'old' request is not relevant any more
202     
>>>     CID 1539911:  Performance inefficiencies  (PASS_BY_VALUE)
>>>     Capturing variable "aSet" of type "SfxItemSetFixed<(unsigned short)10414, (unsigned short)10414, (unsigned short)10855, (unsigned short)10859>" (size 144 bytes) by value, which exceeds the low threshold of 128 bytes.
203             pDlg->StartExecuteAsync([aSet, pDlg, pNumRuleAtCurrentSelection, pRequest, this](sal_Int32 nResult){
204                 if (RET_OK == nResult)
205                 {
206                     const SvxNumBulletItem* pBulletItem = pDlg->GetOutputItemSet()->GetItemIfSet(SID_ATTR_NUMBERING_RULE, false);
207                     if (pBulletItem)
208                     {

** CID 1539910:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/vcl/timer.hxx: 26 in ()


________________________________________________________________________________________________________
*** CID 1539910:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
/include/vcl/timer.hxx: 26 in ()
20     #ifndef INCLUDED_VCL_TIMER_HXX
21     #define INCLUDED_VCL_TIMER_HXX
22     
23     #include <tools/link.hxx>
24     #include <vcl/task.hxx>
25     
>>>     CID 1539910:  Low impact quality  (MISSING_MOVE_ASSIGNMENT)
>>>     Class "Timer" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalues, where a move assignment may be faster.
26     class VCL_DLLPUBLIC Timer : public Task
27     {
28         Link<Timer *, void> maInvokeHandler;   ///< Callback Link
29         sal_uInt64          mnTimeout;
30         const bool          mbAuto;
31     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DmmDF_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi4jsLUxQHMVDG3RXGHwidSYu88-2F-2Faz5kqPHCdrWD2FIdZez4c4GCdT7Dmh9LPttHn4rWQFO47Vg7yQs0ZzUKuvGmwrqMfotCbKraY2Y7JSnpfTZJSqNKHWZ-2FAtG-2BBqnAFCG5oeWWsJLA-2F8FWAbqz9sKpGCHnGq6KlmVZzmExSOkk-3D