Hello,
I noticed in include/svx/xdef.hxx that the numbering was wrong from
XATTRSET_LINE (line 105)
103 constexpr TypedWhichId<XLineCapItem> XATTR_LINECAP
(XATTR_LINE_FIRST + 12); /* V3: 1012 */
104 constexpr sal_uInt16 XATTR_LINE_LAST (XATTR_LINECAP);
105 constexpr TypedWhichId<XLineAttrSetItem> XATTRSET_LINE
(XATTR_LINE_LAST + 1); /* V3: 1017 V2: 1017 */
(see
https://opengrok.libreoffice.org/xref/core/include/svx/xdef.hxx?r=c4cf2e82#103)
1) Is it ok to renumber from this point ?
2) Are "V2" "V3" numbers in comments useful or can we remove them to
just keep the last real number ?
We can even see V4 in "include/svx/svddef.hxx"
Remark: ideally, I'd like being able to do this in gdb:
p SDRATTR_TABLE_FIRST
Sometimes it works:
(gdb) p XATTR_LINECAP
$5 = {mnWhich = 1012}
sometimes not:
(gdb) p SDRATTR_TABLE_FIRST
No symbol "SDRATTR_TABLE_FIRST" in current context.
Julien
