ESC meeting minutes: 2023-03-02

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Present:
    + Heiko, Ilmari, Stephane, Olivier, Caolan, Cloph, Eike, Gabriel, Hossein, Michael W, Stephan, Thorsten, Xisco, Jussi, Miklos, Michael S, Michael M, Rachael, Odetayo, Xime

* Completed Action Items:

* Pending Action Items:
    + Remove MAB section (Xisco)

* Release Engineering update (Cloph)
    + 7.5 status: 7.5.2 rc1 next week
    + 7.4 status: 7.4.6 rc2 this week, to be tagged later today
     https://gerrit.libreoffice.org/q/project:core+branch:libreoffice-7-4-6+status:open

* Documentation (Olivier)
    + New Help
       + Shall we continue with XHP?
          + Is there something simpler?
             + warning: code doc systems vs product doc systems
          + markdown or pure HTML?
          + a new format would have to support l10n
          + don't want something more complex than what we have
          + markdown can be simple to edit, but it may have its own issues
          + analysis to be done carefully
          + wollmux doc is in asciidoc (Thorsten)
            + versus markdown: has more features
            + turned it into a wiki
            + wonder if it's an option here
          + what to do with offline help if the content is mediawiki? (Ilmari)
            + perhaps pure HTML
            + idea was to ask the content authors what they think
    + Helpcontent2
       + Usual updates and fixes (S. Chaiklin, ohallot, R Lima, A Barrientos)
       + Massive patch load from S. Schroder (+> 100)
           + Refactoring of files (clogs git log, man-hours to approve)
           + Many patches touches translation w/ cosmetic changes or invisible)
           + I'm holding and will approve in slower pace (ohallot)
           + no need to stop, but good to focus on open bugs (Miklos, Olivier)
    + Guides
        + Printed version of Writer and Calc guides 7.5 (J. Weber)
        + HTML (bookshelf of Writer guide 7.5
    + Google Season of Doc
        + deadline is March 24th
        + Accepting ideas.
    + Bugzilla Documentation statistics
        255(255) bugs open
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
           created     32(3)     61(9)    115(10)     318(6)
         commented     41(-3)   122(28)   261(27)    1043(22)
          resolved     13(4)     30(9)     57(11)     198(11)
    + top 10 contributors:
          Seth Chaiklin made 119 changes in 1 month, and 448 changes in 1 year
          Olivier Hallot made 110 changes in 1 month, and 479 changes in 1 year
          Heiko Tietze made 22 changes in 1 month, and 97 changes in 1 year
          Ilmari Lauhakangas made 10 changes in 1 month, and 98 changes in 1 year
          Adolfo Jayme Barrientos made 6 changes in 1 month, and 41 changes in 1 year
          Kaganski, Mike made 6 changes in 1 month, and 109 changes in 1 year
          Roman Kuznetsov made 4 changes in 1 month, and 63 changes in 1 year
          Rafael Lima made 4 changes in 1 month, and 115 changes in 1 year
          Vernon, Stuart Foote made 3 changes in 1 month, and 34 changes in 1 year
          ady made 2 changes in 1 month, and 3 changes in 1 year

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        277(277) (topicUI) bugs open, 81(81) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week    1 month   3 months   12 months
             added      4(-7)     18(-8)    31(-6)      66(-4)
         commented     67(-15)   285(5)    661(0)     2253(8)
           removed      0(0)       0(0)      3(-1)      27(-1)
          resolved      4(-5)     31(-1)    80(-2)     280(-5)
    + top 10 contributors:
          Heiko Tietze made 136 changes in 1 month, and 1398 changes in 1 year
          Vernon, Stuart Foote made 72 changes in 1 month, and 232 changes in 1 year
          Seth Chaiklin made 44 changes in 1 month, and 210 changes in 1 year
          Stéphane Guillou made 42 changes in 1 month, and 171 changes in 1 year
          Eyal Rozenberg made 36 changes in 1 month, and 265 changes in 1 year
          Rafael Lima made 33 changes in 1 month, and 251 changes in 1 year
          Ilmari Lauhakangas made 23 changes in 1 month, and 208 changes in 1 year
          McNamara, Caolán made 18 changes in 1 month, and 37 changes in 1 year
          ady made 16 changes in 1 month, and 28 changes in 1 year
          Dieter made 13 changes in 1 month, and 200 changes in 1 year
    + [Bug 153901] Add support for comment tooltips on table cell content
    + [Bug 153888] Very bad formatting when importing pdf
 -> + [Bug 153880] Make Calc text hyperlinks stand out more
      + no strong opinion on this, no objections (Eike)
    + [Bug 151927] Invisible Chart lines and labels. Fix: Add Option: Chart
           default background-color
    + [Bug 153806] Improve keyboard interaction for Special Characters dialog
    + [Bug 153798] Line numbers should be aligned to the right in the Basic IDE
    + [Bug 150446] Incorrect behaviour of gutter in mirrored pages with top binding
    + [Bug 153489] Changing the "Separator" for Numbering by Caption in AutoCaption
           results in it being applied to existing captions once new object is inserted

* Crash Testing (Caolan)
    + 1018(+877) import failure, 856(+852) export failures
      - lots of rtf export ones, fixed now, thanks to Michael S
    + 4 coverity issues
      - all in hand for next build
    + 3 Google / ossfuzz: ?? fuzzers active now

* Crash Reporting (Xisco)
   + https://crashreport.libreoffice.org/stats/version/7.4.4.2
         + (+23) 452 429 529 725 1194 1343 832 0
   + https://crashreport.libreoffice.org/stats/version/7.4.5.1
         + (+153) 911 758 646 573 645 0
   + https://crashreport.libreoffice.org/stats/version/7.5.0.3
         + (+517) 2763 2246 1834 1162 0
   + waiting for 7.5.1 results (Xisco)

* Mentoring (Hossein)
          committer...   1 week    1 month    3 months    12 months
                  open      98(-6)    152(-9)    161(-6)      166(-6)
               reviews     506(46)   1396(24)   3476(128)   11584(-70)
                merged     384(19)   1323(54)   3785(97)    14564(-1)
             abandoned      16(0)      64(1)     174(4)       810(-19)
           own commits     274(10)    913(38)   2533(74)    10671(1)
        review commits     112(33)    279(63)    766(66)     2782(33)
        contributor...   1 week      1 month     3 months    12 months
                  open      196(173)    228(165)    234(167)     244(163)
               reviews     1308(374)   3350(446)   8480(478)   31854(312)
                merged       25(11)      62(18)     181(2)       848(6)
             abandoned       15(12)      28(-3)     211(4)       583(14)
           own commits       53(27)     109(41)     291(32)      939(18)
        review commits        0(0)        0(0)        0(0)         0(0)
    + easyHack statistics:
       needsDevEval 9(9)   needsUXEval 1(1)   cleanup_comments 322(322)
       total 389(389)   assigned 21(21)   open 340(340)
    + top 10 contributors:
          Sophia Schroeder made 30 patches in 1 month, and 30 patches in 1 year
          Armin Le Grand (allotropia) made 7 patches in 1 month, and 44 patches in 1 year
          Rafał Dobrakowski made 4 patches in 1 month, and 4 patches in 1 year
          Paris Oplopoios made 4 patches in 1 month, and 15 patches in 1 year
          Hannah Meeks made 3 patches in 1 month, and 24 patches in 1 year
          Colomban Wendling made 3 patches in 1 month, and 13 patches in 1 year
          Sebastian Siewior made 3 patches in 1 month, and 3 patches in 1 year
          Damjan, Jovanovic made 2 patches in 1 month, and 2 patches in 1 year
          Adoche Onaji made 2 patches in 1 month, and 2 patches in 1 year
          Yashodhan Sawardekar made 2 patches in 1 month, and 3 patches in 1 year
    + top 10 reviewers:
          Michael Stahl made 162 review comments in 1 month, and 1134 in 1 year
          McNamara, Caolán made 136 review comments in 1 month, and 1022 in 1 year
          Adolfo Jayme Barrientos made 122 review comments in 1 month, and 984 in 1 year
          Nabet, Julien made 98 review comments in 1 month, and 824 in 1 year
          Xisco Fauli made 88 review comments in 1 month, and 842 in 1 year
          Thorsten Behrens made 84 review comments in 1 month, and 612 in 1 year
          Vajna, Miklos made 64 review comments in 1 month, and 694 in 1 year
          Timar, Andras made 56 review comments in 1 month, and 276 in 1 year
          Christian Lohmaier made 54 review comments in 1 month, and 374 in 1 year
          Ilmari Lauhakangas made 54 review comments in 1 month, and 298 in 1 year
    + Patches automatically abandoned:
        tdf#146150 Use dispatch command instead of numerical ID for the UNO commands ( Vaibhav Malik )
            - https://gerrit.libreoffice.org/#/c/128801
        tdf#143640 Fix UNO object inspector crash ( Hossein )
            - https://gerrit.libreoffice.org/#/c/134035
        WIP: WASM pdf conversion through emscripten and qt5 ( Balazs Varga )
            - https://gerrit.libreoffice.org/#/c/140478
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          niket1322git
          Nirnay K
          Czeber László Ádám (NISZ)

  * Reviewed submissions from the newcomers
  * Reviewed some of the old EasyHacks to make sure they are still relevant in 2023
    * Reviewed another 5 -> Total processed: 75
  * Updated and finalized draft blog post, will be published tomorrow
   * VCL application in its minimal form
     https://dev.blog.documentfoundation.org/?p=721&preview=1&_ppp=0e5862d595
  * Drafted a new blog post
   * Internal includes instead of global ones - EasyHack
     https://dev.blog.documentfoundation.org/?p=444&preview=1&_ppp=141ff4ba2c
  * Hacker News discussion of Telemetry post: https://news.ycombinator.com/item?id=34981719

* ESC expectations around LibreOffice mentoring & review (Michael M)

  + Everyone is welcome to contribute to LibreOffice and we try to provide
timely mentoring and support for new people. However, for projects
that require lots of support - such as multi-month full-time
internships, we strongly recommend that a suitably senior engineer in
the community be identified in advance, who has sufficient time to
oversee, socialize and review such contributions.

    + no objections (Thorsten)
       + understanding this was always implied
       + not bad to have it explicit.
       + someone to get close to mentees with a broader overview is helpful.
    + like helping someone with homework (Miklos)
       + can expect the mentor will do the other side of helping
       + only works if the mentor has the time to do it.

* Outreachy (JussiP)
  + Where to put the new MSI-related dependency, core or lode?
  + summary of the current state (Jussi)
    + internship is coming to an end
    + msicreator is an external script, the work uses it
    + initial change on gerrit, wanted to add msicreator to core
    + request: add it to lode.git
      + there: add it to core.git instead
        https://gerrit.libreoffice.org/c/lode/+/148024
    + idea: if libreoffice starts using it, improve incrementally, once mature, publish as a Python module
    + a policy decision on where the script should go, decisions on either side,
      someone needs to say where to put it.
    + context (Thorsten)
       + lengthy IRC discussion today
       + usually what happens - people go ahead and merge things
       + here an actual review is happening
       + some inconsistencies happen, then a moment of reflection
       + apologize - for suggestion to move from core -> LODE
           + then being casual about what to actually do there.
       + previously - went ahead and merged it, and helped clean things up later
    + similar cases in the past (Miklos)
       + doxygen, gettext etc.
       + in case it's a run-time dependency - bundle in core
       + build-time, used to install manually - now done by lode.
    + disagree (cloph)
       + suggested it to be in core
       + LODE a convenience wrapper to get available stuff installed
          + newer make, utilities etc.
       + anything that might be needed to have different versions for
         different branches - should be tied to core repo.
       + if there is a need to submit it to the repo
         + open to question.
       + as is now, if still evolving - may need touch-ups,
         having it in an external repo that needs to be synched up
         is a larger maintenance burden.
       + potential for breaking changes (Thorsten)
         + install CI builders via LODE - and need to update each month
         + not workable.
    + git submodule ? (Michael M)
    + hope sooner than later a version 1.0 (Thorsten)
       + looked at it today, don't know what the right decision is
       + lets look at it and patch it up later.
    + its special (Miklos)
       + previously had things that had a release
    + see it more as corresponding to packaging code (Cloph)
       + the new packaging framework - from main repo.
    + do the simplest thing that could work (JussiP)
       + put it in core, if something goes wrong, just do it - it goes fine
       + simplest thing -> into core.
       + a merge request - tested to work, can use that to build.
       + if no other review comments, can merge it now.
    + sounds like a plan (Thorsten)
       + was baulking at having two repos here
       + patches there, passed Jenkins already
    + know it is used by people - who have sent patches (JussiP)
    + plan to move to an external later when it stabilizes ? (Michael W)
       + that's the plan, once in pypy - can install from there etc. (JussiP)
          + up-stream first development, all goes there with tests
          + once good enough for LibreOffice - do a 1.0 release
          + and delete internal copy.
    => merge patch into core.

* GSoC (Ilmari)
  + https://wiki.documentfoundation.org/Development/GSoC/2023
  + https://wiki.documentfoundation.org/Development/GSoC/Ideas
    + Ideas are still welcome, if there is a matching mentor (Thorsten)
  + Next step: 4th April, project submission deadline for contributors

* Commit Access
  + no proposals this week

* Developer Certification (Stephan/Kendy/Thorsten/László)
  + resting since: 20 weeks (limit: 20 weeks)
  + expect some proposal by next week (Thorsten)

* Jenkins / CI update (Cloph)
gerrit_android_aarch64     jobs: 278 ok: 249 ko:  15 fail ratio: 5.40% mean_ok:   9 ( 18) median_ok:   7 ( 12)
gerrit_android_arm         jobs: 278 ok: 228 ko:  29 fail ratio: 10.43% mean_ok:   9 ( 17) median_ok:   7 ( 13)
gerrit_android_x86         jobs: 279 ok: 243 ko:  19 fail ratio: 6.81% mean_ok:  10 ( 18) median_ok:   7 ( 13)
gerrit_android_x86_64      jobs: 278 ok: 224 ko:  28 fail ratio: 10.07% mean_ok:   9 ( 17) median_ok:   7 ( 13)
gerrit_linux_clang_dbgutil jobs: 603 ok: 373 ko: 184 fail ratio: 30.51% mean_ok:  44 ( 50) median_ok:  41 ( 48)
gerrit_linux_gcc_release   jobs: 555 ok: 449 ko:  69 fail ratio: 12.43% mean_ok:  22 ( 26) median_ok:  20 ( 21)
gerrit_mac                 jobs: 579 ok: 432 ko:  88 fail ratio: 15.20% mean_ok:  40 ( 62) median_ok:  38 ( 51)
gerrit_windows             jobs: 615 ok: 389 ko: 148 fail ratio: 24.07% mean_ok:  64 ( 92) median_ok:  60 ( 90)
gerrit_master              jobs: 683 ok: 300 ko: 300 fail ratio: 43.92% mean_ok:  89 ( 93) median_ok:  87 ( 87)
   + https://dev-www.libreoffice.org/tmp/gerrit_230302.thml
   + tests that failed more than twice in last seven days
      3 CppunitTest_sc_subsequent_export_test2                gerrit_windows
      3 CppunitTest_sw_a11y                gerrit_windows
      3 CppunitTest_sw_uiwriter8                gerrit_mac
      4 CppunitTest_sd_svg_export_tests                gerrit_linux_clang_dbgutil
      4 CppunitTest_sw_uiwriter8                gerrit_linux_clang_dbgutil
      6 CppunitTest_sw_mailmerge                gerrit_windows
      6 UITest_writer_tests                gerrit_linux_clang_dbgutil
      7 CppunitTest_framework_dispatch                gerrit_windows
      7 CppunitTest_sw_mailmerge2                gerrit_windows
      8 Killed by the kill-wrapper                gerrit_mac
      8 UITest_calc_tests8                gerrit_linux_clang_dbgutil
     12 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
     18 CppunitTest_sc_uicalc                gerrit_windows
     19 CppunitTest_sw_uiwriter3                gerrit_windows
     25 CppunitTest_sw_uiwriter3                gerrit_linux_clang_dbgutil

         -> Should be better after 6ee7245960837b6376b49f7c33eef966770022f4

     33 CppunitTest_sw_odfexport2                gerrit_mac

         -> Disable in bc72cbf2e481fe04f610f3bf799ba606d9387ffa

    + bad week, but should be better (Cloph)


* LibreOffice hackfest in Cambridge (Miklos)
  + as part of COOL days: 28 & 29th March 2023
  + https://www.collaboraoffice.com/cooldays/ has more info

* What’s cooking (Miklos)
  + Multi-page floating tables (Miklos)
    + early stage, SW_FORCE_FLY_SPLIT=1 is meant to allow experimenting
  + multi-color gradients (Armin)
    + focusing on plumbing / rendering, no model changes yet (Thorsten)
  + theming work (Tomaz)
    + focusing on Writer for now

* QA update (Xisco)
    + UNCONFIRMED: 1350 (-80)
        + enhancements: 297  (-13)
        + needsUXEval: 8 (-7)
        + haveBackTrace: 6 (-1)
        + needsDevAdvice: 29 (+0)
        + documentation:  1 (-16)
        + android:  3 (+0)
        + iOS:  0 (+0)
        + Online:  11 (+0)


    + Most pressing bugs:
     New:

    None


    + New high severity bugs of the week:
        + Copying table column outside of table crashes Writer
            + https://bugs.documentfoundation.org/show_bug.cgi?id=153819
              + discussion is ongoing if this is a regression
              + bisected where the behavior changed

* QA stats (Stéphane)
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +113  +41 (-148) overall)
      many thanks to the top bug squashers:
       Buovjaga                18
       Stéphane Guillou (stragu) 17
       QA Administrators       15
       sdc.blanco              9
       Olivier Hallot          6
       Heiko Tietze            5
       V Stuart Foote          5
       Xisco Faulí             5
       m.a.riosv               5
       Mike Kaganski           4

    + top 10 bugs reporters:
       sdc.blanco              9
       Rafael Lima             7
       Marcin Juszkiewicz      5
       Stéphane Guillou (stragu) 5
       Palongo                 4
       Franklin Weng           2
       Mike Kaganski           2
       NISZ LibreOffice Team   2
       Piotr Osada             2
       Regina Henschel         2

    + top 10 bugs fixers:
       Seth Chaiklin           9
       Heiko Tietze            3
       Kaganski, Mike          3
       Németh, László          3
       Xisco Fauli             3
       خالد حسني               3
       Grandin, Noel           2
       Michael Stahl           2
       Olivier Hallot          2
       Rafael Lima             2

    + top 10 bugs confirmers:
       Ilmari Lauhakangas      42
       Stéphane Guillou        24
       Olivier Hallot          17
       Heiko Tietze            15
       Dieter                  10
       m.a.riosv               10
       Nabet, Julien           5
       Ezinne Nnamani          4
       Xisco Fauli             4
       *UNKNOWN*               3

* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 2/54 -     3 %  (+0)
     5.4 : 0/41 -     0 %  (+0)
     5.3 : 0/54 -     0 %  (+0)
     5.2 : 0/43 -     0 %  (+0)
     5.1 : 0/35 -     0 %  (+0)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 0/76 -     0 %  (+0)
     4.3 : 0/73 -     0 %  (+0)
     4.2 : 2/134 -    1 %  (+0)
     4.1 : 1/85 -     1 %  (-1)
     4.0 : 1/82 -     1 %  (+0)
     old : 1/246 -    0 %  (+0)

* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Stéphane Guillou       3
        Xisco Fauli            3
        Ilmari Lauhakangas     2
        Raal                   2
        itssmithlogan          1
        Weghorn, Michael       1

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Stéphane Guillou       3
        Xisco Fauli            3
        Ilmari Lauhakangas     2
        Raal                   2
        Weghorn, Michael       1

* all bugs tagged with 'regression'
   + 1227(+5) bugs open of 12364(+18) total 10(+0) high prio.

     done by:
        Stéphane Guillou       5
        Xisco Fauli            2
        ady                    1
        Ilmari Lauhakangas     1
        Ezinne Nnamani         1
        Raal                   1
        Telesto                1
        Vernon, Stuart Foote   1

* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 7(+1)
     Calc          - 1(+0)
     Draw          - 1(+0)
     LibreOffice   - 1(+0)
     Base          - 0(-1)

   by OS:
     All           - 7(+1)
     Linux         - 1(-1)
     Mac OS X      - 0(+0)
     Windows       - 2(+0)

* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 428(+4)
     Calc                     - 220(+1)
     Impress                  - 124(+0)
     Writer: docx filter      - 59(+0)
     LibreOffice              - 51(+2)
     Crashes                  - 50(+1)
     Draw                     - 45(+1)
     Base                     - 43(-1)
     UI                       - 40(+1)
     Writer: perf             - 35(+0)
     Borders                  - 33(+0)
     Writer: other filter     - 30(+0)
     Chart                    - 25(-1)
     RTL                      - 24(+0)
     Writer: doc filter       - 21(+1)
     Printing and PDF export  - 20(+1)
     BASIC                    - 19(+1)
     filters and storage      - 15(+0)
     graphics stack           - 14(-1)
     Formula Editor           - 3(-1)
     sdk                      - 2(+0)
     Linguistic               - 1(+0)
     framework                - 1(+0)



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux