On 24.12.2022 13.42, Siddharth Khattar wrote:
Hello,
So I did all the recommended changes that were commented in the code
in the file "impastpl.cxx" but Jenkins is still giving me a build
error. Can someone please help me with it, the link to it on Gerrit
is: https://gerrit.libreoffice.org/c/core/+/144537
I tried a further commit and investigated a few things by changing
some static_cast back to const_cast but couldn't figure it out,
unfortunately. For reference, The easy hack I'm referring to is:
https://bugs.documentfoundation.org/show_bug.cgi?id=90341
Without commenting on the content of the changes, your problem is that
you have created a series of patches. The expectation is that for a task
like this, you keep updating the single patch. In your latest patch I
also commented about this: https://gerrit.libreoffice.org/c/core/+/144790
You should look at 'git log', see how many of your own commits you have
and then say
git reset --soft HEAD~x
where x is the number of your own commits minus one. Now you have all
your modifications ready to commit with 'git commit --amend' and they
will go toward your first patch which should be this:
https://gerrit.libreoffice.org/c/core/+/144374
When editing the commit message, double-check that the Change-Id is
Change-Id: I8a3d7c6695dea16536f1a0ebbbbd2c27fbedeb8d
Finally './logerrit submit master' to submit the new patchset.
Ilmari
