New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1517773:    (WRAPPER_ESCAPE)
/sdext/source/minimizer/optimizerdialog.cxx: 319 in OptimizerDialog::createPage(short)()
/sdext/source/minimizer/optimizerdialog.cxx: 327 in OptimizerDialog::createPage(short)()
/sdext/source/minimizer/optimizerdialog.cxx: 331 in OptimizerDialog::createPage(short)()
/sdext/source/minimizer/optimizerdialog.cxx: 335 in OptimizerDialog::createPage(short)()
/sdext/source/minimizer/optimizerdialog.cxx: 323 in OptimizerDialog::createPage(short)()


________________________________________________________________________________________________________
*** CID 1517773:    (WRAPPER_ESCAPE)
/sdext/source/minimizer/optimizerdialog.cxx: 319 in OptimizerDialog::createPage(short)()
313         std::unique_ptr<vcl::OWizardPage> xRet;
314     
315         switch (nState)
316         {
317             case ITEM_ID_INTRODUCTION:
318                 xRet.reset(new IntroPage(pPageContainer, *this));
>>>     CID 1517773:    (WRAPPER_ESCAPE)
>>>     The internal representation of local "xRet" escapes into "this->mpPage0", but is destroyed when it exits scope.
319                 mpPage0 = static_cast<IntroPage*>(xRet.get());
320                 break;
321             case ITEM_ID_SLIDES:
322                 xRet.reset(new SlidesPage(pPageContainer, *this));
323                 mpPage1 = static_cast<SlidesPage*>(xRet.get());
324                 break;
/sdext/source/minimizer/optimizerdialog.cxx: 327 in OptimizerDialog::createPage(short)()
321             case ITEM_ID_SLIDES:
322                 xRet.reset(new SlidesPage(pPageContainer, *this));
323                 mpPage1 = static_cast<SlidesPage*>(xRet.get());
324                 break;
325             case ITEM_ID_GRAPHIC_OPTIMIZATION:
326                 xRet.reset(new ImagesPage(pPageContainer, *this));
>>>     CID 1517773:    (WRAPPER_ESCAPE)
>>>     The internal representation of local "xRet" escapes into "this->mpPage2", but is destroyed when it exits scope.
327                 mpPage2 = static_cast<ImagesPage*>(xRet.get());
328                 break;
329             case ITEM_ID_OLE_OPTIMIZATION:
330                 xRet.reset(new ObjectsPage(pPageContainer, *this));
331                 mpPage3 = static_cast<ObjectsPage*>(xRet.get());
332                 break;
/sdext/source/minimizer/optimizerdialog.cxx: 331 in OptimizerDialog::createPage(short)()
325             case ITEM_ID_GRAPHIC_OPTIMIZATION:
326                 xRet.reset(new ImagesPage(pPageContainer, *this));
327                 mpPage2 = static_cast<ImagesPage*>(xRet.get());
328                 break;
329             case ITEM_ID_OLE_OPTIMIZATION:
330                 xRet.reset(new ObjectsPage(pPageContainer, *this));
>>>     CID 1517773:    (WRAPPER_ESCAPE)
>>>     The internal representation of local "xRet" escapes into "this->mpPage3", but is destroyed when it exits scope.
331                 mpPage3 = static_cast<ObjectsPage*>(xRet.get());
332                 break;
333             case ITEM_ID_SUMMARY:
334                 xRet.reset(new SummaryPage(pPageContainer, *this));
335                 mpPage4 = static_cast<SummaryPage*>(xRet.get());
336                 break;
/sdext/source/minimizer/optimizerdialog.cxx: 335 in OptimizerDialog::createPage(short)()
329             case ITEM_ID_OLE_OPTIMIZATION:
330                 xRet.reset(new ObjectsPage(pPageContainer, *this));
331                 mpPage3 = static_cast<ObjectsPage*>(xRet.get());
332                 break;
333             case ITEM_ID_SUMMARY:
334                 xRet.reset(new SummaryPage(pPageContainer, *this));
>>>     CID 1517773:    (WRAPPER_ESCAPE)
>>>     The internal representation of local "xRet" escapes into "this->mpPage4", but is destroyed when it exits scope.
335                 mpPage4 = static_cast<SummaryPage*>(xRet.get());
336                 break;
337         }
338     
339         m_xAssistant->set_page_title(sIdent, getStateDisplayName(nState));
340     
/sdext/source/minimizer/optimizerdialog.cxx: 323 in OptimizerDialog::createPage(short)()
317             case ITEM_ID_INTRODUCTION:
318                 xRet.reset(new IntroPage(pPageContainer, *this));
319                 mpPage0 = static_cast<IntroPage*>(xRet.get());
320                 break;
321             case ITEM_ID_SLIDES:
322                 xRet.reset(new SlidesPage(pPageContainer, *this));
>>>     CID 1517773:    (WRAPPER_ESCAPE)
>>>     The internal representation of local "xRet" escapes into "this->mpPage1", but is destroyed when it exits scope.
323                 mpPage1 = static_cast<SlidesPage*>(xRet.get());
324                 break;
325             case ITEM_ID_GRAPHIC_OPTIMIZATION:
326                 xRet.reset(new ImagesPage(pPageContainer, *this));
327                 mpPage2 = static_cast<ImagesPage*>(xRet.get());
328                 break;

** CID 1517772:  Control flow issues  (DEADCODE)
/sw/source/uibase/utlui/content.cxx: 5987 in SwContentTree::BringPostItFieldsToAttention(std::vector<const SwTextAttr *, std::allocator<const SwTextAttr *>> &)()


________________________________________________________________________________________________________
*** CID 1517772:  Control flow issues  (DEADCODE)
/sw/source/uibase/utlui/content.cxx: 5987 in SwContentTree::BringPostItFieldsToAttention(std::vector<const SwTextAttr *, std::allocator<const SwTextAttr *>> &)()
5981                 continue;
5982             assert(dynamic_cast<const SwTextAnnotationField*>(p->GetFormatField().GetTextField()));
5983             const SwTextAnnotationField* pTextAnnotationField =
5984                     static_cast<const SwTextAnnotationField*>(p->GetFormatField().GetTextField());
5985             if (!pTextAnnotationField)
5986                 continue;
>>>     CID 1517772:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "NULL" inside this statement: "pAnnotationMark = ((pTextAn...".
5987             const ::sw::mark::IMark* pAnnotationMark =
5988                     pTextAnnotationField != nullptr ? pTextAnnotationField->GetAnnotationMark()
5989                                                     : nullptr;
5990             const SwPosition aMarkStart = pAnnotationMark ? pAnnotationMark->GetMarkStart()
5991                                                     : SwPosition(rTextNode, p->GetStart());
5992             const SwPosition aMarkEnd = pAnnotationMark ? pAnnotationMark->GetMarkEnd()


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Daft__OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi1ZTKN0brBQBpfs3UXr-2BVyFjWGel32mMdWwMQ3MwJi3-2BZ0-2FwvGaEkWfvQ-2FwIngdEpMyBsHaY3FgcxpKLPkYNi29w62pZQJnCyw-2FtXl5XtSboEyU5t1YZrNhKhp0xPRpoFMYpKC-2Fe1-2FwHy18ytIrBP4pCmCiwCZNTTc8CUVTQs5Pk-3D