New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1516789:  Incorrect expression  (DIVIDE_BY_ZERO)
/svx/source/styles/CommonStylePreviewRenderer.cxx: 299 in svx::CommonStylePreviewRenderer::CalcRenderSize()()


________________________________________________________________________________________________________
*** CID 1516789:  Incorrect expression  (DIVIDE_BY_ZERO)
/svx/source/styles/CommonStylePreviewRenderer.cxx: 299 in svx::CommonStylePreviewRenderer::CalcRenderSize()()
293                 break;
294         }
295         while(true);
296     
297         double fRatio = 1;
298         if (mnHeight > mnMaxHeight)
>>>     CID 1516789:  Incorrect expression  (DIVIDE_BY_ZERO)
>>>     In expression "(double)this->mnMaxHeight / this->mnHeight", division by expression "this->mnHeight" which may be zero has undefined behavior.
299             fRatio = double(mnMaxHeight) / mnHeight;
300     
301         mnHeight *= fRatio;
302         mnBaseLine *= fRatio;
303         if (fRatio != 1)
304         {

** CID 1516788:  Uninitialized members  (UNINIT_CTOR)
/sw/source/ui/vba/vbaformfields.cxx: 132 in <unnamed>::FormFieldCollectionHelper::FormFieldCollectionHelper(com::sun::star::uno::Reference<ooo::vba::XHelperInterface>, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>, const com::sun::star::uno::Reference<com::sun::star::frame::XModel> &)()


________________________________________________________________________________________________________
*** CID 1516788:  Uninitialized members  (UNINIT_CTOR)
/sw/source/ui/vba/vbaformfields.cxx: 132 in <unnamed>::FormFieldCollectionHelper::FormFieldCollectionHelper(com::sun::star::uno::Reference<ooo::vba::XHelperInterface>, com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext>, const com::sun::star::uno::Reference<com::sun::star::frame::XModel> &)()
126                                   const css::uno::Reference<css::uno::XComponentContext> xContext,
127                                   const css::uno::Reference<frame::XModel>& xModel)
128             : mxParent(std::move(xParent))
129             , mxContext(std::move(xContext))
130             , mxModel(std::move(xModel))
131         {
>>>     CID 1516788:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "m_pCache" is not initialized in this constructor nor in any functions that it calls.
132         }
133     
134         // XIndexAccess
135         virtual sal_Int32 SAL_CALL getCount() override
136         {
137             sal_Int32 nCount = SAL_MAX_INT32;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DKiZQ_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJir2-2B-2FL-2FLX1x-2FSU410IowzDaqGQn7EXHrDxleMhqmHlLsh-2Bb4V-2BTgn034VTVHqRxeWkSkloDuxLaYIehHNHOyYWgKYIl8KaUw0SZ92qy-2B-2BcmVL9HxVL7WAMhCtwLTzEM3WDSkItJV-2BhEQbaalzFjha7sEFr2pV8I5YSzzMF4IUl-2FM-3D