ESC meeting minutes: 2022-10-27

[Miklos Vajna <vmiklos@xxxxxxxxxxxxx>]

* Present:
    + Olivier, Michael S, Thorsten, Caolan, Stephan, Ilmari, Miklos, Xisco, Hossein, Cloph, Gabriel, Tomaž, Juan

* Completed Action Items:
    + update the budget page for tdf#104597 (Ilmari)
    + double-check Xisco's take on LOOL & pass it to the board (Stephan)
    + report Arabic follow-up for tdf#104597 (Hossein) -> Done (tdf#151788) but seems to be fixed

* Pending Action Items:
    + ignore enhancement severity for the “QA update” section (Xisco)
    + create the Jenkins job for macOS arm64 (Cloph)

* Release Engineering update (Cloph)
    + 7.4 status: 7.4.3 rc1 in 1 week
    + 7.3 status: 7.3.7 rc2 this week; last planned release of the 7.3 line
    + 7.5 release plan: alpha soonish, expect a wiki page similar to 7.3, a year later

* Documentation (Olivier)
    + Helpcontents2
       + updated screenshots and added new (ohallot)
       + Fixes and updates (A. Romedenne, A. Gelmini)
    + Guides
       + Release web version of Impress Guide 7.4


    + Bugzilla Documentation statistics
        237(237) bugs open
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
           created     12(4)    32(2)      80(8)      304(2)
         commented     18(4)    57(-14)   182(6)     1211(-1)
          resolved      3(0)    13(-1)     39(2)      196(0)
    + top 10 contributors:
          Olivier Hallot made 22 changes in 1 month, and 471 changes in 1 year
          Rafael Lima made 21 changes in 1 month, and 229 changes in 1 year
          BogdanB made 12 changes in 1 month, and 13 changes in 1 year
          Telesto made 10 changes in 1 month, and 32 changes in 1 year
          Srebotnjak, Martin made 8 changes in 1 month, and 12 changes in 1 year
          Heiko Tietze made 7 changes in 1 month, and 110 changes in 1 year
          Kaganski, Mike made 6 changes in 1 month, and 120 changes in 1 year
          Dieter made 5 changes in 1 month, and 79 changes in 1 year
          Ilmari Lauhakangas made 5 changes in 1 month, and 89 changes in 1 year
          *UNKNOWN* made 5 changes in 1 month, and 5 changes in 1 year

* UX Update (Heiko)
    + Missing Heiko
    + Bugzilla (topicUI) statistics
        271(271) (topicUI) bugs open, 96(96) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week    1 month    3 months   12 months
             added      9(-10)    46(3)      63(10)      85(10)
         commented     39(-55)   312(-45)   664(5)     2352(21)
           removed      0(0)       1(-1)     10(1)       35(1)
          resolved      3(0)      26(-3)     80(-2)     318(1)
    + top 10 contributors:
          Eyal Rozenberg made 157 changes in 1 month, and 287 changes in 1 year
          Heiko Tietze made 91 changes in 1 month, and 1499 changes in 1 year
          Foote, V Stuart made 72 changes in 1 month, and 289 changes in 1 year
          Rafael Lima made 46 changes in 1 month, and 205 changes in 1 year
          Timur made 46 changes in 1 month, and 153 changes in 1 year
          Telesto made 44 changes in 1 month, and 181 changes in 1 year
          Dieter made 34 changes in 1 month, and 235 changes in 1 year
          V Stuart Foote made 29 changes in 1 month, and 29 changes in 1 year
          Roman Kuznetsov made 25 changes in 1 month, and 188 changes in 1 year
          Kaganski, Mike made 18 changes in 1 month, and 154 changes in 1 year

* Crash Testing (Caolan)
    + 29(-18) import failure, 3(-24) export failures
     -  new results since then has a new known common failure
    + 0 coverity issues
    + 10 ossfuzz issues,  2 crash (1 looks same as new crashtesting one)
    + crashtesting 4 -> 3 days turnaround, nice improvement

* Crash Reporting (Xisco)
   + https://crashreport.libreoffice.org/stats/version/7.3.6.2
         + (+107) 802 695 605 523 391 313 139 0
   + https://crashreport.libreoffice.org/stats/version/7.4.1.2
         + (-388) 1288 1676 1942 1653 1202 783 0
   + https://crashreport.libreoffice.org/stats/version/7.4.2.3
         + (+603) 1253 650 0


    + https://crashreport.libreoffice.org/stats/signature/void%20rtl::str::release%3C_rtl_uString%3E(_rtl_uString*)

    - Most reported crash - regression in 7.4

    - Is it possible to not group unrelated crashes (top frame in string dtor)? (Stephan)

    - Not aware of an easy way (Xisco)

      - last page has the most recent reports


* Easyhack update / mentoring (Hossein)
          committer...   1 week     1 month     3 months   12 months
                  open      65(4)      127(5)      138(7)      142(7)
               reviews     308(-70)   1074(-18)   2988(60)   11832(14)
                merged     270(45)    1000(-68)   3506(48)   14977(-9)
             abandoned      18(4)       50(-6)     171(10)     835(7)
           own commits     230(58)     753(-25)   2684(75)   11606(21)
        review commits      79(3)      245(26)     667(49)    3107(-8)
        contributor...   1 week      1 month     3 months    12 months
                  open      34(-125)    246(1)      268(8)       285(8)
               reviews     802(90)     2536(-98)   7880(164)   32866(44)
                merged      16(-9)       55(-7)     223(7)      1123(-37)
             abandoned      10(5)        26(1)       58(1)       371(7)
           own commits      22(-8)       83(4)      216(15)     1053(-9)
        review commits       0(0)         0(0)        0(0)         0(0)
    + easyHack statistics:
       needsDevEval 9(9)   needsUXEval 1(1)   cleanup_comments 308(308)
       total 368(368)   assigned 17(17)   open 321(321)
    + top 10 contributors:
          Kevin Suo made 6 patches in 1 month, and 23 patches in 1 year
          Armin Le Grand (allotropia) made 6 patches in 1 month, and 18 patches in 1 year
          Omkar Acharekar  made 5 patches in 1 month, and 5 patches in 1 year
          Paris Oplopoios made 4 patches in 1 month, and 79 patches in 1 year
          Calvince Otieno made 3 patches in 1 month, and 3 patches in 1 year
          Paris Oplopoios made 3 patches in 1 month, and 3 patches in 1 year
          Srebotnjak, Martin made 2 patches in 1 month, and 22 patches in 1 year
            made 2 patches in 1 month, and 15 patches in 1 year
          Rachael Odetayo made 2 patches in 1 month, and 2 patches in 1 year
          Fukanchik, Sergey made 1 patches in 1 month, and 1 patches in 1 year
    + top 10 reviewers:
          McNamara, Caolán made 98 review comments in 1 month, and 790 in 1 year
          Michael Stahl made 96 review comments in 1 month, and 1078 in 1 year
          Vajngerl, Tomaž made 94 review comments in 1 month, and 394 in 1 year
          Adolfo Jayme Barrientos made 80 review comments in 1 month, and 1040 in 1 year
          Vajna, Miklos made 72 review comments in 1 month, and 524 in 1 year
          Nabet, Julien made 60 review comments in 1 month, and 766 in 1 year
          Thorsten Behrens made 52 review comments in 1 month, and 870 in 1 year
          Xisco Fauli made 52 review comments in 1 month, and 886 in 1 year
          Hossein made 50 review comments in 1 month, and 264 in 1 year
          Ilmari Lauhakangas made 46 review comments in 1 month, and 236 in 1 year
    + Patches automatically abandoned:
        Support clang plugin build for non-std clang names ( Thorsten Behrens )
            - https://gerrit.libreoffice.org/#/c/115053
        WIP: tdf#124098: sc: new document setting "ForceRowHeightRecalc" ( Vasily Melenchuk ) -> No longer needed. Thorsten said: "Seems opensuse packagers stopped using non-standard setups, works now"
            - https://gerrit.libreoffice.org/#/c/129300
        WIP WindowsKillWrapper ( Noel Grandin )
            - https://gerrit.libreoffice.org/#/c/129675
        tdf#134628 Inverting checkbox in the language settings dialog box. ( Isha Desai ) -> Suggested changes are not addressed by the author
            - https://gerrit.libreoffice.org/#/c/135246

* Mentoring (Hossein)
  + Reviewed Received several submissions from newcomers
    + Simple cleanups
    + Port Java examples -> Python
    + Font tests
  + Finalised and published a blog post on crash fixing (Hossein)
    https://dev.blog.documentfoundation.org/?p=583
  + Drafted another blog post on fixing crashes
    Crash fixes for LibreOffice, part 2: aborts
    https://dev.blog.documentfoundation.org/?p=576&preview=1&_ppp=b4593fd6a0
  + Outreachy status (Ilmari)
    + many of the hacks were done by Outreachy candidates
    + next week will be the application deadline (Fri)
      + more learning oriented than GSoC

* Commit Access
  + None

* Developer Certification (Stephan/Kendy/Thorsten/László)
  + resting since: 6 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
    from:Thu Oct 20 14:00:01 2022
    master linux rel  jobs: 127 ok: 126 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master linux dbg  jobs: 112 ok: 110 ko:   2 fail ratio:  1.79 % break:   2 broken duration: 2.85%
    master mac rel    jobs: 116 ok: 116 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master mac dbg    jobs: 116 ok: 115 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master win rel    jobs: 102 ok: 102 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master win dbg    jobs: 103 ok: 103 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master win64 dbg  jobs: 103 ok: 103 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master gerrit lin jobs: 488 ok: 380 ko:  72 fail ratio: 14.75% time for ok: mean:  22 median:  18
    master gerrit plg jobs: 432 ok: 287 ko:  92 fail ratio: 21.30% time for ok: mean:  44 median:  43
    master gerrit win jobs: 504 ok: 344 ko: 102 fail ratio: 20.24% time for ok: mean:  54 median:  47
    master gerrit mac jobs: 493 ok: 360 ko:  85 fail ratio: 17.24% time for ok: mean:  35 median:  31
    master android    jobs: 427 ok: 354 ko:  29 fail ratio:  6.79% time for ok: mean:  27 median:  14
    master gerrit all jobs: 452 ok: 251 ko: 137 fail ratio: 30.31% time for ok: mean:  71 median:  56
   + https://dev-www.libreoffice.org/tmp/gerrit_221027.html
   + tests that failed more than twice in last seven days
      3 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil_branch
      3 CppunitTest_sw_mailmerge                gerrit_windows
      3 JunitTest_ucb_complex                gerrit_linux_clang_dbgutil
      4 CppunitTest_vcl_png_test                gerrit_windows
      6 CppunitTest_sw_uiwriter6                gerrit_windows
     10 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
    + this week was good, nothing special to report
    + macro failures are gone on Windows (Xisco)
      + uiwriter6 improvements from Stephan

* What’s cooking (Miklos)
    + Writer content controls, PDF export work is still in progress (Miklos)
    + testcase refactors (Xisco)
      + ongoing effort
      + have lots of duplicate code to handle an opened document (component)
        + cleaning that up
        + started because poor cleanup/teardown caused problems on Windows
        + meant to help writing new test suites
        + when starting a new test class, best to inherit from UnoApiTest if you load documents (and/or save)
        + sw/ was already looking good
        + sc/ sd/ are the most problematic
    + looking at dark mode & macOS (Caolan)

* Date handling (Juan)
  + https://lists.freedesktop.org/archives/libreoffice/2022-October/089508.html
  + different places handle it different ways
  + once have a direction, solve some problems

* QA update (Xisco)
    + UNCONFIRMED: 1818 (+15)
        + enhancements: 305  (+8)
        + needsUXEval: 41 (+8)
        + haveBackTrace: 7 (+0)
        + needsDevAdvice: 27 (+0)
        + documentation:  11 (+1)
        + android:  3 (+0)
        + iOS:  0 (+0)
        + Online:  14 (+0)

    + Most pressing bugs:
     New:

    None


    + New high severity bugs of the week:
        + CRASH in SdrLayerIDSet::IsSet(o3tl::strong_int<short,SdrLayerIDTag>)
            + https://bugs.documentfoundation.org/show_bug.cgi?id=151654
            + Mike?
            + found using crashreport -> last few UNO commands hiting how to repro

        + FILESAVE: Exporting documents with embedded SVG to doc or docx converts the image to low-resolution pixel graphics
            + https://bugs.documentfoundation.org/show_bug.cgi?id=51510
            + not a regression?

* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +125  +35 (-100) overall)
      many thanks to the top bug squashers:
       QA Administrators       11
       Buovjaga                9
       Caolán McNamara         7
       Eike Rathke             6
       Rizal Muttaqin          5
       Julien Nabet            4
       Roman Kuznetsov         4
       V Stuart Foote          4
       m.a.riosv               4
       Kevin Suo               3

    + top 10 bugs reporters:
       Eyal Rozenberg          5
       Andrius                 4
       Rizal Muttaqin          4
       NISZ LibreOffice Team   3
       Hossein                 2
       Justin L                2
       Marco Colnaghi          2
       Olivier Hallot          2
       Regina Henschel         2
       Thomas Tempelmann       2

    + top 10 bugs fixers:
       McNamara, Caolán        6
       Rizal Muttaqin          5
       Rathke, Eike            3
       Grandin, Noel           2
       Henschel, Regina        2
       Kevin Suo               2
       Michael Stahl           2
       Németh, László          2
       Olivier Hallot          2
                               1

    + top 10 bugs confirmers:
       Ilmari Lauhakangas      22
       m.a.riosv               14
       Dieter                  12
       Rafael Lima             5
       Roman Kuznetsov         5
       V Stuart Foote          5
       Nabet, Julien           4
       Raal                    4
       Xisco Fauli             3
       خالد حسني               3


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 1/53 -     1 %  (+0)
     5.4 : 0/41 -     0 %  (+0)
     5.3 : 0/54 -     0 %  (+0)
     5.2 : 0/43 -     0 %  (+0)
     5.1 : 0/35 -     0 %  (+0)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 0/76 -     0 %  (+0)
     4.3 : 0/73 -     0 %  (+0)
     4.2 : 2/134 -    1 %  (+0)
     4.1 : 2/85 -     2 %  (-1)
     4.0 : 1/83 -     1 %  (+0)
     old : 1/246 -    0 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Raal                   4
        Aron Budea             3
        Weghorn, Michael       1
        Németh, László         1
        Xisco Fauli            1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Raal                   5
        Aron Budea             4
        Weghorn, Michael       1
        Németh, László         1
        Xisco Fauli            1


* all bugs tagged with 'regression'
   + 1175(+0) bugs open of 12083(+15) total 8(+0) high prio.

     done by:
        Aron Budea             2
        Raal                   2
        Rathke, Eike           1
        Bielefeld, Rainer      1
        Weghorn, Michael       1
        Marco Colnaghi         1
        Németh, László         1
        V Stuart Foote         1
        Xisco Fauli            1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 5(+0)
     Calc          - 1(+0)
     Draw          - 1(+0)
     LibreOffice   - 1(+0)

   by OS:
     All           - 7(+0)
     Linux         - 0(+0)
     Mac OS X      - 0(+0)
     Windows       - 1(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 420(-1)
     Calc                     - 192(+0)
     Impress                  - 118(+3)
     Writer: docx filter      - 57(+0)
     Crashes                  - 52(+0)
     LibreOffice              - 44(+0)
     Draw                     - 41(+0)
     Base                     - 37(+0)
     UI                       - 37(+0)
     Writer: perf             - 36(+0)
     Borders                  - 34(+1)
     Writer: other filter     - 31(+0)
     Chart                    - 24(+0)
     RTL                      - 23(+0)
     Writer: doc filter       - 19(+0)
     BASIC                    - 18(+0)
     Printing and PDF export  - 15(+0)
     filters and storage      - 14(-2)
     graphics stack           - 13(+0)
     Formula Editor           - 3(+0)
     sdk                      - 2(+0)
     framework                - 1(-1)
     Linguistic               - 0(-1)