New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1515521:  Null pointer dereferences  (REVERSE_INULL)
/slideshow/source/engine/shapes/drawshape.cxx: 397 in slideshow::internal::DrawShape::DrawShape(const com::sun::star::uno::Reference<com::sun::star::drawing::XShape> &, const com::sun::star::uno::Reference<com::sun::star::drawing::XDrawPage> &, double, bool, const slideshow::internal::SlideShowContext &)()


________________________________________________________________________________________________________
*** CID 1515521:  Null pointer dereferences  (REVERSE_INULL)
/slideshow/source/engine/shapes/drawshape.cxx: 397 in slideshow::internal::DrawShape::DrawShape(const com::sun::star::uno::Reference<com::sun::star::drawing::XShape> &, const com::sun::star::uno::Reference<com::sun::star::drawing::XDrawPage> &, double, bool, const slideshow::internal::SlideShowContext &)()
391                     mpCurrMtf = std::make_shared<GDIMetaFile>();
392     
393                 maSubsetting.reset( mpCurrMtf );
394     
395                 prepareHyperlinkIndices();
396     
>>>     CID 1515521:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "this->mpCurrMtf" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
397                 if(mbContainsPageField && mpCurrMtf && !maBounds.isEmpty())
398                 {
399                     // tdf#150402 Use mbContainsPageField that gets set in prepareHyperlinkIndices
400                     // which has to be run anyways, so this will cause no harm in execution speed.
401                     // It lets us detect the potential error case that a PageField is contained in
402                     // the Text of the Shape. That is a hint that maBounds contains the wrong Range

** CID 1515520:  Control flow issues  (DEADCODE)
/filter/source/msfilter/svdfppt.cxx: 1860 in SdrPowerPointImport::ImportOLE(unsigned int, const Graphic &, const tools::Rectangle &, const tools::Rectangle &, int) const()


________________________________________________________________________________________________________
*** CID 1515520:  Control flow issues  (DEADCODE)
/filter/source/msfilter/svdfppt.cxx: 1860 in SdrPowerPointImport::ImportOLE(unsigned int, const Graphic &, const tools::Rectangle &, const tools::Rectangle &, int) const()
1854                 {
1855                     bSuccess = SdrPowerPointOLEDecompress( *pDest, rStCtrl, nLen );
1856                 }
1857                 if ( bSuccess )
1858                 {
1859                     pDest->Seek(0);
>>>     CID 1515520:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "NULL" inside this statement: "pObjStor = (pDest ? new Sto...".
1860                     Storage* pObjStor = pDest ? new Storage( *pDest, true ) : nullptr;
1861                     if (pObjStor)
1862                     {
1863                         tools::SvRef<SotStorage> xObjStor( new SotStorage( pObjStor ) );
1864                         if ( xObjStor.is() && !xObjStor->GetError() )
1865                         {

** CID 1515519:  Uninitialized members  (UNINIT_CTOR)
/sc/source/filter/xcl97/xcl97esc.cxx: 73 in XclEscherExGlobal::XclEscherExGlobal(const XclExpRoot &)()


________________________________________________________________________________________________________
*** CID 1515519:  Uninitialized members  (UNINIT_CTOR)
/sc/source/filter/xcl97/xcl97esc.cxx: 73 in XclEscherExGlobal::XclEscherExGlobal(const XclExpRoot &)()
67     using ::com::sun::star::script::XEventAttacherManager;
68     
69     XclEscherExGlobal::XclEscherExGlobal( const XclExpRoot& rRoot ) :
70         XclExpRoot( rRoot )
71     {
72         SetBaseURI( GetMedium().GetBaseURL( true ) );
>>>     CID 1515519:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mpPicStrm" is not initialized in this constructor nor in any functions that it calls.
73     }
74     
75     SvStream* XclEscherExGlobal::ImplQueryPictureStream()
76     {
77         mxPicTempFile.reset( new ::utl::TempFile );
78         mxPicTempFile->EnableKillingFile();

** CID 1515518:  Null pointer dereferences  (REVERSE_INULL)
/filter/source/msfilter/svdfppt.cxx: 1860 in SdrPowerPointImport::ImportOLE(unsigned int, const Graphic &, const tools::Rectangle &, const tools::Rectangle &, int) const()


________________________________________________________________________________________________________
*** CID 1515518:  Null pointer dereferences  (REVERSE_INULL)
/filter/source/msfilter/svdfppt.cxx: 1860 in SdrPowerPointImport::ImportOLE(unsigned int, const Graphic &, const tools::Rectangle &, const tools::Rectangle &, int) const()
1854                 {
1855                     bSuccess = SdrPowerPointOLEDecompress( *pDest, rStCtrl, nLen );
1856                 }
1857                 if ( bSuccess )
1858                 {
1859                     pDest->Seek(0);
>>>     CID 1515518:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "pDest" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
1860                     Storage* pObjStor = pDest ? new Storage( *pDest, true ) : nullptr;
1861                     if (pObjStor)
1862                     {
1863                         tools::SvRef<SotStorage> xObjStor( new SotStorage( pObjStor ) );
1864                         if ( xObjStor.is() && !xObjStor->GetError() )
1865                         {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DOfcq_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiZQhuVLOuklryhLMyTpI6u6-2B9g8RKdZCdhQHZHGuvRR4Ue3SibkBA1Mc3Ik6niVeaHZH4fNMnWuudY-2BALwxXpUvMATWEYBE3cF2pUwmsfIPr2t5rXNzMc-2F6zBUh-2FCP-2B3jdE7TmylRPWmXnpO1cwcc3-2Fg1VfYWjckSw6TUPc-2BfhtE-3D