ESC meeting minutes: 2022-09-15

[Miklos Vajna <vmiklos@xxxxxxxxxxxxx>]

* Present:
    + Ilmari, Michael W, Heiko, Caolan, Hossein, Lubos, Michael S, Cloph, Miklos, Tomaz, Xisco, Olivier, Kendy, Gabriel, Thorsten, Eike

* Completed Action Items:
    + None

* Pending Action Items:
    + None

* Release Engineering update (Cloph)
    + 7.4 status: 7.4.2 rc1 in 1 week
    + 7.3 status: 7.3.7 rc1 in 4 weeks
    + Appstores:
      + another back-and-forth with the fonts in the Windows app store
      + macOS is live now
      + any effect on what we can ship? (Heiko)
        + guess they want to make sure we don't overwrite Windows defaults
        + doesn't block anything, just delay

* Documentation (Olivier)
    + Helpcontents2
       + (WIP)enhacement in conditional format pages (ohallot, kompilannen)
       + new pages on content control dialogs (M. Vajna)
       + Updates and fixes (fitoshido, erack)

    + Guides
       + Calc Guide 7.4 updates
          + conditional format, refactoring chapters - ohallot
          + Sparklines - S. Masonsmith
          + Code coloring - flywire

    + Bugzilla Documentation statistics
        238(238) bugs open
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
           created     10(-4)   27(-7)     89(6)      315(1)
         commented     16(3)    45(1)     187(7)     1356(-13)
          resolved      2(-6)   11(-6)     44(1)      198(-4)
    + top 10 contributors:
          Olivier Hallot made 34 changes in 1 month, and 498 changes in 1 year
          Roman Kuznetsov made 13 changes in 1 month, and 31 changes in 1 year
          Ilmari Lauhakangas made 7 changes in 1 month, and 113 changes in 1 year
          Alain Romedenne made 5 changes in 1 month, and 36 changes in 1 year
          Rafael Lima made 5 changes in 1 month, and 250 changes in 1 year
          Kaganski, Mike made 4 changes in 1 month, and 119 changes in 1 year
          Tuomas Hietala made 4 changes in 1 month, and 4 changes in 1 year
          Aron Budea made 3 changes in 1 month, and 5 changes in 1 year
          Balland-Poirier, Laurent made 3 changes in 1 month, and 6 changes in 1 year
          Seth Chaiklin made 3 changes in 1 month, and 345 changes in 1 year
    + thanks for introducing the new volunteer (Kendy)
      + new people appear & disappear from time to time
      + Skip arrived to doc team via VolunteerMatch (Ilmari)

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        274(274) (topicUI) bugs open, 48(48) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week    1 month   3 months   12 months
             added      2(-12)    12(-5)    15(-5)      38(-6)
         commented     55(-36)   211(19)   446(22)    2164(-7)
           removed      1(-1)      6(0)      8(1)       33(1)
          resolved      7(-2)     29(3)     69(0)      312(-1)
    + top 10 contributors:
          Heiko Tietze made 149 changes in 1 month, and 1529 changes in 1 year
          Foote, V Stuart made 41 changes in 1 month, and 244 changes in 1 year
          Rafael Lima made 26 changes in 1 month, and 117 changes in 1 year
          Roman Kuznetsov made 22 changes in 1 month, and 164 changes in 1 year
          Kaganski, Mike made 22 changes in 1 month, and 147 changes in 1 year
          Eyal Rozenberg made 16 changes in 1 month, and 97 changes in 1 year
          Timur made 16 changes in 1 month, and 84 changes in 1 year
          *UNKNOWN* made 15 changes in 1 month, and 15 changes in 1 year
          Rathke, Eike made 14 changes in 1 month, and 20 changes in 1 year
          Dieter made 11 changes in 1 month, and 202 changes in 1 year
    + [Bug 150957] webp images are saved into odt as png
    + [Bug 150950] line numbering ON/OFF indication in Tools menu
    + [Bug 139617] Optimal height isn't applied when shrinking word-wrapped cell
           (nor after entering the cell), only when content changes
    + [Bug 150953] Row and column headers do not zoom in and out
    + [Bug 145201] UI: Context Menu does not appear if user clicks on the
           top-left sheet corner.
    + [Bug 150949] Format cells is at the bottom of right-click menu
    + [Bug 150910] [EDITING] Protected status only is pasted if the source cells
           belong to one row.
    + [Bug 150889] Insert->Image inconsistent behavior when graphic objects
           are selected

    + first patches for new app icons submitted
      + removal of locolor icons in https://gerrit.libreoffice.org/c/core/+/139553
      + clean-up at hicolor icons https://gerrit.libreoffice.org/c/core/+/139715
      + review appreciated

* Crash Testing (Caolan)
    + 81(-23) import failure, 42(-1) export failures
      - two frequent crashes fixed since this run
    + 8 coverity issues
    + 5 ossfuzz issues, 1 crash, 1 leak, 1 oom, 2 timeouts

* Crash Reporting (Xisco)
   + https://crashreport.libreoffice.org/stats/version/7.3.4.2
         + (+93) 896 803 1102 1248 1498 1695 1672 1581 1128 963 675 0
   + https://crashreport.libreoffice.org/stats/version/7.3.5.2
         + (+170) 1299 1129 1355 1196 866 550 0
   + https://crashreport.libreoffice.org/stats/version/7.3.6.2
         + (+139) 139 0
   + https://crashreport.libreoffice.org/stats/version/7.4.0.3
         + (+250) 1114 864 528 0

    Fixed in 7.3.6.2

    + https://crashreport.libreoffice.org/stats/signature/mdds::flat_segment_tree%3Clong,bool%3E::insert_to_pos(boost::intrusive_ptr%3Cmdds::__st::node%3Cmdds::flat_segment_tree%3Clong,bool%3E%20%3E%20%3E%20&,long,long,bool)


* Mentoring/easyhack update (Hossein)
          committer...   1 week     1 month    3 months    12 months
                  open      96(-2)     153(-2)    159(-2)      166(-1)
               reviews     442(60)    1202(28)   3022(112)   11958(90)
                merged     294(-66)   1332(-1)   3379(-43)   15272(74)
             abandoned      19(-2)      62(4)     162(4)       819(28)
           own commits     207(-77)   1022(-4)   2434(-17)   11791(43)
        review commits      40(-30)    202(-5)    614(-1)     3132(-34)
        contributor...   1 week      1 month    3 months     12 months
                  open      62(9)       137(8)     141(3)        150(3)
               reviews     830(-180)   3242(-2)   7734(-104)   33048(-28)
                merged      14(-8)       90(-4)    239(-7)       996(-95)
             abandoned       6(1)        14(5)      73(-3)       390(-22)
           own commits      10(-12)      70(2)     180(-11)     1054(-81)
        review commits       0(0)         0(0)       0(0)          0(0)
    + easyHack statistics:
       needsDevEval 9(9)   needsUXEval 1(1)   cleanup_comments 308(308)
       total 370(370)   assigned 14(14)   open 326(326)
    + top 10 contributors:
          Paris Oplopoios made 17 patches in 1 month, and 70 patches in 1 year
          Povilas Kanapickas made 9 patches in 1 month, and 9 patches in 1 year
          Hao Liu made 6 patches in 1 month, and 6 patches in 1 year
          Armin Le Grand (allotropia) made 5 patches in 1 month, and 7 patches in 1 year
          Javier Salamanca made 3 patches in 1 month, and 4 patches in 1 year
          Chenxiong Qi made 3 patches in 1 month, and 3 patches in 1 year
            made 3 patches in 1 month, and 3 patches in 1 year
          Wagner, Thorsten made 2 patches in 1 month, and 2 patches in 1 year
          Dante DM made 2 patches in 1 month, and 3 patches in 1 year
          Juan C. Sanz made 2 patches in 1 month, and 3 patches in 1 year
    + top 10 reviewers:
          Vajngerl, Tomaž made 120 review comments in 1 month, and 384 in 1 year
          McNamara, Caolán made 114 review comments in 1 month, and 674 in 1 year
          Xisco Fauli made 94 review comments in 1 month, and 910 in 1 year
          Christian Lohmaier made 88 review comments in 1 month, and 308 in 1 year
          Grandin, Noel made 78 review comments in 1 month, and 392 in 1 year
          Nabet, Julien made 68 review comments in 1 month, and 724 in 1 year
          Adolfo Jayme Barrientos made 60 review comments in 1 month, and 1018 in 1 year
          Michael Stahl made 56 review comments in 1 month, and 1108 in 1 year
          Kaganski, Mike made 52 review comments in 1 month, and 604 in 1 year
          Vajna, Miklos made 52 review comments in 1 month, and 502 in 1 year
    + Patches automatically abandoned:
        tdf#134101: sw_uiwriter3: Add unittest ( Xisco Fauli )
            - https://gerrit.libreoffice.org/#/c/109331
        Introduced the Flush() method for aiding the benchmarks ( Akshit Kushwaha )
            - Restored, needs resolving merge Conflict
            - https://gerrit.libreoffice.org/#/c/130134
        AutoFormat paragraph also after space ( Szymon Kłos )
            - https://gerrit.libreoffice.org/#/c/135059
        tdf#143574: sw: move UItest to CppUnittest ( Attila Bakos )
            - https://gerrit.libreoffice.org/#/c/136809
        tdf#74702: SfxObjectShell::DoDraw{_Impl}() only needs VirtualDevice ( Chris Sherlock )
            - Marked as work-in-progress
            - https://gerrit.libreoffice.org/#/c/136890
        sw: always snap to char in square page mode. ( Mark Hung )
            - https://gerrit.libreoffice.org/#/c/136913
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Satya Kompella (opentext)
          Sam James (gentoo)

* GSoC (Hossein/Ilmari)
  + pending final evaluation

* Commit Access

* Developer Certification (Stephan/Kendy/Thorsten/László)
  + resting since: 1 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
    from:Thu Sep  8 14:04:44 2022
    master linux rel  jobs: 114 ok: 114 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master linux dbg  jobs: 108 ok: 102 ko:   6 fail ratio:  5.56 % break:   6 broken duration: 6.76%
    master mac rel    jobs: 127 ok:  89 ko:  38 fail ratio: 29.92 % break:   6 broken duration:11.48%
    master mac dbg    jobs:  99 ok:  95 ko:   4 fail ratio:  4.04 % break:   1 broken duration: 3.95%
    master win rel    jobs:  61 ok:  61 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master win dbg    jobs:  67 ok:  67 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master win64 dbg  jobs:  68 ok:  68 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master gerrit lin jobs: 629 ok: 509 ko:  79 fail ratio: 12.56% time for ok: mean:  23 median:  19
    master gerrit plg jobs: 578 ok: 407 ko: 119 fail ratio: 20.59% time for ok: mean:  44 median:  42
    master gerrit win jobs: 679 ok: 376 ko: 224 fail ratio: 32.99% time for ok: mean:  65 median:  65
    master gerrit mac jobs: 639 ok: 446 ko: 144 fail ratio: 22.54% time for ok: mean:  36 median:  32
    master android    jobs: 614 ok: 392 ko: 179 fail ratio: 29.15% time for ok: mean:  24 median:  17
    master gerrit all jobs: 670 ok: 238 ko: 349 fail ratio: 52.09% time for ok: mean:  82 median:  83
   + https://dev-www.libreoffice.org/tmp/gerrit_220915.html
   + tests that failed more than twice in last seven days
      5 CppunitTest_sc_macros_test                gerrit_windows
      5 CppunitTest_sw_uiwriter6                gerrit_windows
      7 CppunitTest_sw_uiwriter6                gerrit_mac
        -> I wonder if https://gerrit.libreoffice.org/c/core/+/139927 will help
      8 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
     14 UITest_impress_tests2                gerrit_linux_clang_dbgutil

         -> Should be gone after https://gerrit.libreoffice.org/c/core/+/139851 (Xisco)

     68 CppunitTest_sc_vba_macro_test                gerrit_windows (bot related)

         -> https://gerrit.libreoffice.org/c/core/+/139948 may help (Xisco)

         + in general, if you can test something from cppunit, then prefer that over UITest (Xisco)

    + little rough week: bots with config issues / disk space problems
      + also: patch Tuesday week for Windows

* What’s cooking (Miklos)
  + opencl cleanups: upstreaming the full patch set is still in progress (Lubos)
  + Writer content controls, initial PDF export support is now in master (Miklos)

* QA update (Xisco)
    + UNCONFIRMED: 1723 (-28)
        + enhancements: 277  (+2)
        + needsUXEval: 5 (-2)
        + haveBackTrace: 6 (+0)
        + needsDevAdvice: 25 (-1)
        + documentation:  10 (+2)
        + android:  3 (+0)
        + iOS:  0 (+0)
        + Online:  12 (-1)

    + Most pressing bugs:
     New:

    None


    + New high severity bugs of the week:

        + UI font is not visible in Contextual Groups and Groupedbar Compact UIs when system dark mode is enabled
            + https://bugs.documentfoundation.org/show_bug.cgi?id=137341
            + Thorsten W?

        + FILEOPEN DOCX Table structure destroyed if cell with vertical text direction exists
            + https://bugs.documentfoundation.org/show_bug.cgi?id=150642
            + Mark?

        + Autofilter result is wrong when filtering (empty) records
            + https://bugs.documentfoundation.org/show_bug.cgi?id=150647
            + Lubos?
            - proposal revert: https://gerrit.libreoffice.org/c/core/+/139676

        + have bunch of crashes in Writer tracked changes (Hossein)
          + tried to fix one of them, without success
          + tried to put in more safety checks, but perhaps there is a deeper problem there
          + see e.g.
          https://bugs.documentfoundation.org/show_bug.cgi?id=136904
            + Laszlo?
          https://bugs.documentfoundation.org/show_bug.cgi?id=147507
            + not marked as a regression

* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +103  +22 (-128) overall)
      many thanks to the top bug squashers:
       Timur                   34 <- lots of work, thanks!
       QA Administrators       9
       خالد حسني               7
       Mike Kaganski           6
       Eike Rathke             5
       m.a.riosv               5
       Buovjaga                4
       Heiko Tietze            4
       Justin L                4
       V Stuart Foote          4

    + top 10 bugs reporters:
       Roman Kuznetsov         10 <- lots of work, thanks!
       Mike Kaganski           4
       Regina Henschel         4
       Timur                   3
       Colin                   2
       Justin                  2
       Kurosh Tavassoli        2
       Pierre Fortin           2
       Thomas Maeder           2
       Tuomas Hietala          2

    + top 10 bugs fixers:
       *UNKNOWN*               4
       Kaganski, Mike          3
       Grandin, Noel           2
       Justin Luth             2
       McNamara, Caolán        2
       Németh, László          2
       Rathke, Eike            2
       Samuel Mehrbrodt        2
       Timur                   2
       Vajna, Miklos           2

    + top 10 bugs confirmers:
       Timur                   27
       Raal                    12
       Nabet, Julien           7
       Rafael Lima             7
       Stéphane Guillou        6
       Xisco Fauli             6
       michael.warner.ut+libreoffice@xxxxxxxxx 5
       m.a.riosv               4
       Aron Budea              3
       Dieter                  3


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 1/53 -     1 %  (+0)
     5.4 : 0/41 -     0 %  (+0)
     5.3 : 0/54 -     0 %  (+0)
     5.2 : 0/43 -     0 %  (+0)
     5.1 : 0/35 -     0 %  (+0)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 0/76 -     0 %  (+0)
     4.3 : 0/73 -     0 %  (+0)
     4.2 : 2/134 -    1 %  (+0)
     4.1 : 3/85 -     3 %  (+0)
     4.0 : 2/83 -     2 %  (+0)
     old : 1/246 -    0 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Timur                  9
        Xisco Fauli            5
        Raal                   4
        Aron Budea             3
        Ilmari Lauhakangas     2
        Roman Kuznetsov        1
        Kaganski, Mike         1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Timur                  8
        Raal                   4
        Xisco Fauli            4
        Aron Budea             3
        Ilmari Lauhakangas     2
        Roman Kuznetsov        1
        jeanmarcranger         1
        Kaganski, Mike         1


* all bugs tagged with 'regression'
   + 1206(-4) bugs open of 12006(+19) total 8(-2) high prio.

     done by:
        Timur                  6
        Rafael Lima            2
        Roman Kuznetsov        1
        Aron Budea             1
        Ilmari Lauhakangas     1
        Alex Thurgood          1
        Kaganski, Mike         1
        Raal                   1
        Robert Großkopf        1
        Stéphane Guillou       1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 5(-1)
     Calc          - 1(-1)
     Draw          - 1(+0)
     LibreOffice   - 1(+0)

   by OS:
     All           - 7(-1)
     Linux         - 0(+0)
     Mac OS X      - 0(+0)
     Windows       - 1(-1)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 428(-1)
     Calc                     - 195(-2)
     Impress                  - 120(+1)
     Writer: docx filter      - 59(+1)
     Crashes                  - 51(-1)
     LibreOffice              - 48(+0)
     Draw                     - 44(-1)
     UI                       - 42(+1)
     Base                     - 37(+4)
     Writer: perf             - 37(+1)
     Borders                  - 34(+0)
     Writer: other filter     - 31(-2)
     Chart                    - 23(+0)
     RTL                      - 23(-1)
     Writer: doc filter       - 20(+0)
     BASIC                    - 19(+1)
     Printing and PDF export  - 17(-1)
     filters and storage      - 14(-1)
     graphics stack           - 14(+1)
     Formula Editor           - 3(+0)
     framework                - 2(+0)
     Linguistic               - 1(+0)
     sdk                      - 1(+0)