ESC meeting minutes: 2022-09-08

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Present:
    + Stephan, Michael W, Ilmari, Eike, Cloph, Caolan, Olivier, Heiko, Miklos, Lubos,  Tomaz, Gabriel, Thorsten, Kendy, Hossein, Xisco

* Completed Action Items:
    + None

* Pending Action Items:
    + None

* Release Engineering update (Cloph)
    + 7.4 status: 7.4.1 rc2 this week
    + 7.3 status: 7.3.6 was released as final; 7.3.7 rc1 in 5 weeks
    + Appstores:
      + announcement will follow when ready

* Documentation (Olivier)
    + Helpcontents
       + fixes (libreofficiant, erack, ohallot)
    + Guides
       + work in progress
    + Bugzilla Documentation statistics
        236(236) bugs open
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
           created     14(7)    34(2)      83(1)      314(-5)
         commented     13(3)    44(-3)    180(7)     1369(-44)
          resolved      8(6)    17(6)      43(6)      202(1)
    + top 10 contributors:
          Olivier Hallot made 54 changes in 1 month, and 500 changes in 1 year
          Seth Chaiklin made 15 changes in 1 month, and 345 changes in 1 year
          Roman Kuznetsov made 14 changes in 1 month, and 30 changes in 1 year
          Kaganski, Mike made 12 changes in 1 month, and 117 changes in 1 year
          Ilmari Lauhakangas made 5 changes in 1 month, and 113 changes in 1 year
          Timur made 4 changes in 1 month, and 33 changes in 1 year
          Aron Budea made 3 changes in 1 month, and 5 changes in 1 year
          Dieter made 3 changes in 1 month, and 93 changes in 1 year
          Balland-Poirier, Laurent made 3 changes in 1 month, and 6 changes in 1 year
          Rafael Lima made 3 changes in 1 month, and 252 changes in 1 year

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        274(274) (topicUI) bugs open, 54(54) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
             added     14(11)    17(10)    20(11)      44(11)
         commented     91(64)   192(49)   424(54)    2171(51)
           removed      2(1)      6(2)      7(2)       32(2)
          resolved      9(6)     26(-1)    69(1)      313(-3)
    + top 10 contributors:
          Heiko Tietze made 147 changes in 1 month, and 1525 changes in 1 year
          Rafael Lima made 43 changes in 1 month, and 129 changes in 1 year
          Foote, V Stuart made 41 changes in 1 month, and 256 changes in 1 year
          Eyal Rozenberg made 23 changes in 1 month, and 101 changes in 1 year
          Roman Kuznetsov made 21 changes in 1 month, and 166 changes in 1 year
          Kaganski, Mike made 15 changes in 1 month, and 141 changes in 1 year
          *UNKNOWN* made 15 changes in 1 month, and 15 changes in 1 year
          Telesto made 12 changes in 1 month, and 171 changes in 1 year
          Dieter made 11 changes in 1 month, and 202 changes in 1 year
          Rathke, Eike made 9 changes in 1 month, and 15 changes in 1 year
 -> + [Bug 144428] The keyboard shortcut <RCtrl> + <Menu> opens the context menu.
      + <Menu> as in the key that is on the right of the right ctrl
    + [Bug 144401] Writer: paste of copied text found by style search without CRLF
    + [Bug 150839] View layout has no alternative access method
    + [Bug 150828] Place digital signatures in an existing PDF document with a
           visible stamp
    + [Bug 150799] [UI] Poor space utilization in multi-line cell with filter on
    + [Bug 150804] The strings "Top of baseline" and "Bottom of baseline" should
           be changed
    + [Bug 150807] "2 Content" is not correct English
    + [Bug 150814] Search Commands should also search commands _not_ on the menus
    + [Bug 150811] Support flags in Search Commands: whole-word, case-sensitive, regexp
    + [Bug 150810] Make the Search Commands dialog easier to understand
    + [Bug 150812] Rename the "Search Commands" menu item
    + [Bug 150813] Search Commands should match against more than just command name
    + [Bug 150800] Improve change of vertical scrollbar from left to right,
           if support for asian languages is not enabled
    + [Bug 150739] autofill overwrites existing data without warning
    + [Bug 150751] There should be a way to manually update fixed date / time


* Crash Testing (Caolan)
    + 104(+21) import failure, 43(+1) export failures
      - most common failure is SwXMLExport::ExportTable assert
      presumably since https://gerrit.libreoffice.org/c/core/+/127548 -- Vasily?
      + numbers look bad, but we made progress
    + 22 coverity issues
      + most of the noise is now gone
    + 6 ossfuzz

* Crash Reporting (Xisco)
   + https://crashreport.libreoffice.org/stats/version/7.3.4.2
         + (-299) 803 1102 1248 1498 1695 1672 1581 1128 963 675 0
   + https://crashreport.libreoffice.org/stats/version/7.3.5.2
         + (-226) 1129 1355 1196 866 550 0
   + https://crashreport.libreoffice.org/stats/version/7.4.0.3
         + (+338) 864 528 0


    + Fixes in 7.4

    - https://crashreport.libreoffice.org/stats/signature/SkiaSalGraphicsImpl::applyXor()

    + Thanks to Lubos


    + Regressions in 7.4

    - https://crashreport.libreoffice.org/stats/signature/SwXFrame::getPropertyValue(rtl::OUString%20const%20&)

    - https://crashreport.libreoffice.org/stats/signature/SdrLayerIDSet::IsSet(o3tl::strong_int%3Cshort,SdrLayerIDTag%3E)

    - https://crashreport.libreoffice.org/stats/signature/rtl::str::newFromStr_WithLength%3C_rtl_uString,char%3E(_rtl_uString%20*%20*,char%20const%20*,long,long)


* Mentoring/easyhack update (Hossein)
          committer...   1 week     1 month     3 months    12 months
                  open      98(31)     155(24)     161(24)      167(24)
               reviews     382(168)   1174(42)    2910(162)   11868(-34)
                merged     360(93)    1333(102)   3422(131)   15198(4)
             abandoned      21(13)      58(11)     158(18)      791(5)
           own commits     284(73)    1026(72)    2451(101)   11748(-25)
        review commits      70(33)     207(28)     615(18)     3166(-58)
        contributor...   1 week      1 month     3 months    12 months
                  open       53(-3)     129(-6)     138(-1)      147(-2)
               reviews     1010(270)   3244(204)   7838(320)   33076(-50)
                merged       22(1)       94(9)      246(18)     1091(-51)
             abandoned        5(4)        9(-3)      76(4)       412(-3)
           own commits       22(8)       68(12)     191(12)     1135(-41)
        review commits        0(0)        0(0)        0(0)         0(0)
    + easyHack statistics:
       needsDevEval 9(9)   needsUXEval 1(1)   cleanup_comments 306(306)
       total 368(368)   assigned 14(14)   open 324(324)
    + top 10 contributors:
          Paris Oplopoios made 19 patches in 1 month, and 70 patches in 1 year
          Povilas Kanapickas made 9 patches in 1 month, and 9 patches in 1 year
          Hao Liu made 6 patches in 1 month, and 6 patches in 1 year
          Javier Salamanca made 3 patches in 1 month, and 4 patches in 1 year
          Chenxiong Qi made 3 patches in 1 month, and 3 patches in 1 year
          Wagner, Thorsten made 2 patches in 1 month, and 2 patches in 1 year
          Dante DM made 2 patches in 1 month, and 3 patches in 1 year
          Radhey Parekh made 2 patches in 1 month, and 2 patches in 1 year
          Hannah Meeks made 2 patches in 1 month, and 21 patches in 1 year
          Stanislav Lopatin made 2 patches in 1 month, and 2 patches in 1 year
    + top 10 reviewers:
          McNamara, Caolán made 140 review comments in 1 month, and 666 in 1 year
          Vajngerl, Tomaž made 114 review comments in 1 month, and 388 in 1 year
          Xisco Fauli made 84 review comments in 1 month, and 878 in 1 year
          Grandin, Noel made 80 review comments in 1 month, and 392 in 1 year
          Nabet, Julien made 80 review comments in 1 month, and 712 in 1 year
          Michael Stahl made 78 review comments in 1 month, and 1116 in 1 year
          Thorsten Behrens made 62 review comments in 1 month, and 848 in 1 year
          Kaganski, Mike made 54 review comments in 1 month, and 612 in 1 year
          Hossein made 46 review comments in 1 month, and 240 in 1 year
          Adolfo Jayme Barrientos made 42 review comments in 1 month, and 1014 in 1 year
    + Patches automatically abandoned:
        Dialog: Import CSV: Improve layout ( Pedro Silva )
            - https://gerrit.libreoffice.org/#/c/118169
        tdf#143574: sw: move UItest to CppUnittest ( Xisco Fauli )
            - https://gerrit.libreoffice.org/#/c/125808
        tdf#148109 Paint background color in combobox ( Ilhan Yesil )
            - https://gerrit.libreoffice.org/#/c/131904
        Make LOKClipboard available to other modules ( Szymon Kłos )
            - https://gerrit.libreoffice.org/#/c/135198
        tdf#121367 followup to workaround <switch> behavior ( Seth Chaiklin )
            - https://gerrit.libreoffice.org/#/c/136712
        tdf#149789 a11y: Use whole label as toolbar item text ( Michael Weghorn )
            - https://gerrit.libreoffice.org/#/c/136722
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Aleksa Savic
          Mantke, Andreas
          Chenxiong Qi
          Taichi Haradaguchi
  + new blog post: https://dev.blog.documentfoundation.org/2022/09/06/crash-fixes-for-libreoffice-part-1-segfaults/
    Working on another parts on assertion failures/aborts

* GSoC (Hossein/Ilmari/Tomaz)
  + this week is the last week for gsoc projects
  + Hannah will work more on the VBA bits (Tomaz)
    + virtually spreading the hours for a longer time window (Thorsten)

* Commit Access
  + Tibor Nagy
  + Attila Bakos
  + Attila Szűcs
  => no concerns, Cloph will evanable them
  + AI: enable commit right for them (Cloph)

* Developer Certification (Stephan/Kendy/Thorsten/László)
  + resting since: 0 weeks (limit: 20 weeks)
  + have some candidates, will communicate with them what to do if interested (Kendy)
    + may need not wait for 20 weeks for them to be re-considered

* Jenkins / CI update (Cloph)
    from:Thu Sep  1 13:51:30 2022
    master linux rel  jobs: 139 ok: 136 ko:   3 fail ratio:  2.16 % break:   1 broken duration: 0.91%
    master linux dbg  jobs: 112 ok: 106 ko:   5 fail ratio:  4.46 % break:   5 broken duration:11.06%
    master mac rel    jobs: 142 ok: 119 ko:  23 fail ratio: 16.20 % break:   6 broken duration: 1.15%
    master mac dbg    jobs: 133 ok: 106 ko:  26 fail ratio: 19.55 % break:   4 broken duration: 1.32%
    master win rel    jobs:  91 ok:  88 ko:   2 fail ratio:  2.20 % break:   1 broken duration: 0.98%
    master win dbg    jobs:  96 ok:  93 ko:   1 fail ratio:  1.04 % break:   1 broken duration: 0.97%
    master win64 dbg  jobs:  92 ok:  90 ko:   1 fail ratio:  1.09 % break:   1 broken duration: 0.97%
    master gerrit lin jobs: 652 ok: 479 ko: 142 fail ratio: 21.78% time for ok: mean:  22 median:  18
    master gerrit plg jobs: 584 ok: 385 ko: 143 fail ratio: 24.49% time for ok: mean:  42 median:  40
    master gerrit win jobs: 720 ok: 445 ko: 209 fail ratio: 29.03% time for ok: mean:  58 median:  56
    master gerrit mac jobs: 678 ok: 475 ko: 148 fail ratio: 21.83% time for ok: mean:  34 median:  31
    master android    jobs: 568 ok: 502 ko:  39 fail ratio:  6.87% time for ok: mean:  24 median:  19
    master gerrit all jobs: 677 ok: 306 ko: 301 fail ratio: 44.46% time for ok: mean:  64 median:  58
   + https://dev-www.libreoffice.org/tmp/gerrit_220908.html
   + tests that failed more than twice in last seven days
      3 CppunitTest_sw_uiwriter6                gerrit_mac
      3 UITest_sw_sidebar                gerrit_linux_clang_dbgutil
      3 UITest_writer_tests6                gerrit_linux_clang_dbgutil
      4 CppunitTest_sc_vba_macro_test                gerrit_linux_gcc_release
      6 UITest_calc_tests4                gerrit_linux_clang_dbgutil
      8 CppunitTest_sw_uiwriter6                gerrit_windows
      8 UITest_impress_tests2                gerrit_linux_clang_dbgutil
     11 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
    + this week one macOS bot was bad, 1-2 Windows machine failed due to leftover processes
      + now fixed

* What’s cooking (Miklos)
  + opencl cleanups: 1/3 is in from the full set (Lubos)

* QA update (Xisco)
    + UNCONFIRMED: 1751 (-14)
        + enhancements: 275  (-3)
        + needsUXEval: 7 (+4)
        + haveBackTrace: 6 (+0)
        + needsDevAdvice: 26 (+0)
        + documentation:  8 (-6)
        + android:  3 (+0)
        + iOS:  0 (+0)
        + Online:  13 (+0)

    + Most pressing bugs:
     New:
         None

    + New high severity bugs of the week:
        + Writer crash when I try to open 4-pages DOCX
            + https://bugs.documentfoundation.org/show_bug.cgi?id=119039
            + may need bisecting. Specific to Windows

        + French Langpack invalid causing installation to fail
            + https://bugs.documentfoundation.org/show_bug.cgi?id=143601
            + specific to macOS
            + not clear if it affects current LO versions

        + UI: all drop-down lists from dialogs wrongly positioned
            + https://bugs.documentfoundation.org/show_bug.cgi?id=150718
            + Samuel?

        + Incomplete recalculate
            + https://bugs.documentfoundation.org/show_bug.cgi?id=150766
            + needs bibisecting
        + https://bugs.documentfoundation.org/show_bug.cgi?id=150768 ? (Hossein)
          + will show up in this list if the severity is set to "high" (Xisco)
            + only set severity to "high" if it affects multiple documents

* Front page of bugzilla (Hossein)
  + several years ago: tried to make bug reporting easier
  + avoiding the guided mode sometimes helps people (when they want to upload an attachment)
  + propose to get rid of the guided mode
  + it's true that the guided mode could be tweaked to improve further (Xisco)
    + needs perl development
    + guided mode is for newcomers, users can choose what they want to use
  + have a contractor candidate to implement bugzilla improvements (Ilmari)
  + please discuss this on the QA list (Xisco)

* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +125  +14 (-135) overall)
      many thanks to the top bug squashers:
       QA Administrators       26
       Mike Kaganski           13
       Justin L                11
       Timur                   10
       Heiko Tietze            9
       Eike Rathke             7
       Olivier Hallot          7
       V Stuart Foote          7
       Dieter                  5
       خالد حسني               5

    + top 10 bugs reporters:
       Telesto                 7
       Gabor Kelemen (allotropia) 6
       Regina Henschel         6
       Eyal Rozenberg          5
       Mike Kaganski           4
       Hossein                 3
       NISZ LibreOffice Team   3
       Robert Großkopf         3
       Skip Masonsmith         3
       Tuomas Hietala          3

    + top 10 bugs fixers:
       Rathke, Eike            5
       McNamara, Caolán        4
       Grandin, Noel           2
       Heiko Tietze            2
       Justin Luth             2
       Kaganski, Mike          2
       خالد حسني               2
       Andreas Heinisch        1
       Ilmari Lauhakangas      1
       Kelemen, Gabor          1

    + top 10 bugs confirmers:
       Dieter                  11
       Heiko Tietze            9
       Nabet, Julien           6
       Stéphane Guillou        6
       m.a.riosv               6
       Rafael Lima             5
       Ezinne Nnamani          4
       Raal                    4
       خالد حسني               4
       *UNKNOWN*               3

* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 1/53 -     1 %  (+0)
     5.4 : 0/41 -     0 %  (+0)
     5.3 : 0/54 -     0 %  (+0)
     5.2 : 0/43 -     0 %  (+0)
     5.1 : 0/35 -     0 %  (-2)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 0/76 -     0 %  (+0)
     4.3 : 0/73 -     0 %  (+0)
     4.2 : 2/134 -    1 %  (+0)
     4.1 : 3/85 -     3 %  (+0)
     4.0 : 2/83 -     2 %  (+0)
     old : 1/246 -    0 %  (+0)

* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Aron Budea             2
        Hossein                2
        Timur                  2
        Xisco Fauli            2
        Kaganski, Mike         1
        Raal                   1
        Vajna, Miklos          1

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Aron Budea             2
        Hossein                2
        Timur                  2
        Xisco Fauli            2
        Kaganski, Mike         1
        Raal                   1

* all bugs tagged with 'regression'
   + 1210(+5) bugs open of 11987(+17) total 10(+0) high prio.

     done by:
        Robert Großkopf        3
        Xisco Fauli            2
        Aron Budea             1
        Hossein                1
        خالد حسني              1
        Kaganski, Mike         1
        Raal                   1
        Rafael Lima            1
        Telesto                1
        Timur                  1

* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 6(+0)
     Calc          - 2(+1)
     Draw          - 1(+0)
     LibreOffice   - 1(+0)
     Impress       - 0(-1)

   by OS:
     All           - 8(-1)
     Linux         - 0(+0)
     Mac OS X      - 0(+0)
     Windows       - 2(+1)

* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 429(-3)
     Calc                     - 197(+2)
     Impress                  - 119(+1)
     Writer: docx filter      - 58(+2)
     Crashes                  - 52(+1)
     LibreOffice              - 48(+3)
     Draw                     - 45(+1)
     UI                       - 41(+0)
     Writer: perf             - 36(+0)
     Borders                  - 34(-1)
     Base                     - 33(+0)
     Writer: other filter     - 33(+0)
     RTL                      - 24(+0)
     Chart                    - 23(+0)
     Writer: doc filter       - 20(+0)
     BASIC                    - 18(+0)
     Printing and PDF export  - 18(+0)
     filters and storage      - 15(+0)
     graphics stack           - 13(+0)
     Formula Editor           - 3(+0)
     framework                - 2(+0)
     Linguistic               - 1(+0)
     sdk                      - 1(+0)



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux