New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

4 new defect(s) introduced to LibreOffice found with Coverity Scan.
11 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 4 of 4 defect(s)


** CID 1510132:    (UNINIT)


________________________________________________________________________________________________________
*** CID 1510132:    (UNINIT)
/svx/source/tbxctrls/tbcontrl.cxx: 1303 in <unnamed>::SvxStyleBox_Base::UserDrawEntry(OutputDevice &, const tools::Rectangle &, const tools::Rectangle &, const rtl::OUString &, const std::vector<<unnamed>::ScriptInfo, std::allocator<<unnamed>::ScriptInfo>> &)()
1297                 nStart = nEnd;
1298                 nEnd = rScriptChanges[nIdx].changePos;
1299                 nScript = rScriptChanges[nIdx].scriptType;
1300             }
1301             else
1302                 break;
>>>     CID 1510132:    (UNINIT)
>>>     Using uninitialized value "oFont._M_payload._M_payload" when calling "~optional".
1303         }
1304         while(true);
1305     }
1306     
1307     static bool GetWhich(const SfxItemSet& rSet, sal_uInt16 nSlot, sal_uInt16& rWhich)
1308     {
/svx/source/tbxctrls/tbcontrl.cxx: 1302 in <unnamed>::SvxStyleBox_Base::UserDrawEntry(OutputDevice &, const tools::Rectangle &, const tools::Rectangle &, const rtl::OUString &, const std::vector<<unnamed>::ScriptInfo, std::allocator<<unnamed>::ScriptInfo>> &)()
1296             {
1297                 nStart = nEnd;
1298                 nEnd = rScriptChanges[nIdx].changePos;
1299                 nScript = rScriptChanges[nIdx].scriptType;
1300             }
1301             else
>>>     CID 1510132:    (UNINIT)
>>>     Using uninitialized value "oFont._M_payload._M_payload" when calling "~optional".
1302                 break;
1303         }
1304         while(true);
1305     }
1306     
1307     static bool GetWhich(const SfxItemSet& rSet, sal_uInt16 nSlot, sal_uInt16& rWhich)

** CID 1510131:  Uninitialized members  (UNINIT_CTOR)
/svx/source/styles/CommonStylePreviewRenderer.cxx: 58 in svx::CommonStylePreviewRenderer::CommonStylePreviewRenderer(const SfxObjectShell &, OutputDevice &, SfxStyleSheetBase *, long)()


________________________________________________________________________________________________________
*** CID 1510131:  Uninitialized members  (UNINIT_CTOR)
/svx/source/styles/CommonStylePreviewRenderer.cxx: 58 in svx::CommonStylePreviewRenderer::CommonStylePreviewRenderer(const SfxObjectShell &, OutputDevice &, SfxStyleSheetBase *, long)()
52         : StylePreviewRenderer(rShell, rOutputDev, pStyle, nMaxHeight)
53         , maFontColor(COL_AUTO)
54         , maHighlightColor(COL_AUTO)
55         , maBackgroundColor(COL_AUTO)
56         , maStyleName(mpStyle->GetName())
57     {
>>>     CID 1510131:  Uninitialized members  (UNINIT_CTOR)
>>>     Non-static class member "mnHeight" is not initialized in this constructor nor in any functions that it calls.
58     }
59     
60     CommonStylePreviewRenderer::~CommonStylePreviewRenderer()
61     {}
62     
63     static bool GetWhich(const SfxItemSet& rSet, sal_uInt16 nSlot, sal_uInt16& rWhich)

** CID 1510130:    (UNINIT)


________________________________________________________________________________________________________
*** CID 1510130:    (UNINIT)
/svx/source/styles/CommonStylePreviewRenderer.cxx: 393 in svx::CommonStylePreviewRenderer::render(const tools::Rectangle &, sfx2::StylePreviewRenderer::RenderAlign)()
387                 nStart = nEnd;
388                 nEnd = maScriptChanges[nIdx].changePos;
389                 nScript = maScriptChanges[nIdx].scriptType;
390             }
391             else
392                 break;
>>>     CID 1510130:    (UNINIT)
>>>     Using uninitialized value "oFont._M_payload._M_payload" when calling "~optional".
393         }
394         while(true);
395     
396         mrOutputDev.Pop();
397     
398         return true;
/svx/source/styles/CommonStylePreviewRenderer.cxx: 392 in svx::CommonStylePreviewRenderer::render(const tools::Rectangle &, sfx2::StylePreviewRenderer::RenderAlign)()
386             {
387                 nStart = nEnd;
388                 nEnd = maScriptChanges[nIdx].changePos;
389                 nScript = maScriptChanges[nIdx].scriptType;
390             }
391             else
>>>     CID 1510130:    (UNINIT)
>>>     Using uninitialized value "oFont._M_payload._M_payload" when calling "~optional".
392                 break;
393         }
394         while(true);
395     
396         mrOutputDev.Pop();
397     

** CID 1510129:  Control flow issues  (DEADCODE)
/drawinglayer/source/processor2d/vclprocessor2d.cxx: 524 in drawinglayer::processor2d::VclProcessor2D::RenderFillGraphicPrimitive2DImpl(const drawinglayer::primitive2d::FillGraphicPrimitive2D &)()


________________________________________________________________________________________________________
*** CID 1510129:  Control flow issues  (DEADCODE)
/drawinglayer/source/processor2d/vclprocessor2d.cxx: 524 in drawinglayer::processor2d::VclProcessor2D::RenderFillGraphicPrimitive2DImpl(const drawinglayer::primitive2d::FillGraphicPrimitive2D &)()
518         // caution: when getting to zero, nothing would be painted; thus, do not allow this
519         const sal_Int32 nBWidth(std::max(sal_Int32(1), basegfx::fround(aGraphicRange.getWidth())));
520         const sal_Int32 nBHeight(std::max(sal_Int32(1), basegfx::fround(aGraphicRange.getHeight())));
521     
522         // only do something when bitmap fill has a size in discrete units
523         if (nBWidth <= 0 || nBHeight <= 0)
>>>     CID 1510129:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "return true;".
524             return true;
525     
526         // nBWidth, nBHeight is the pixel size of the needed bitmap. To not need to scale it
527         // in vcl many times, create a size-optimized version
528         const Size aNeededBitmapSizePixel(nBWidth, nBHeight);
529         BitmapEx aBitmapEx(rFillGraphicAttribute.getGraphic().GetBitmapEx());


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3Db84S_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJifYT3tEjq9kRd-2BVqLr-2BUGEfB-2B4dyfLqkzuz8r8i-2BPmSvFF2QNu8xNaR3JtqceDn5ApUSADXTSWJmFSwsIW7uEn5iUcARvzSTnqKNk5xqMhKxMUQ58gOFKlYhnq6fWH6Bs7JJIoEiVBy38GErYNWIyenU8eUuB8c2HrD4nMV71nrQ-3D