Which reviewer should I add to merge this patch?
https://gerrit.libreoffice.org/c/core/+/138256
Attention is currently required from: Hao Liu.
Paris Oplopoios has posted comments on this change. ( https://gerrit.libreoffice.org/c/core/+/138256 )
Change subject: tdf#148251 Use std::swap instead of using temporary values
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
Looks good to me but don't have merge privileges so you're gonna have to find a different reviewer
--
To view, visit https://gerrit.libreoffice.org/c/core/+/138256
To unsubscribe, or for help writing mail filters, visit https://gerrit.libreoffice.org/settings
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Change-Id: Ibbc46bfb17d4d27dc40e63c65190b3f3a5f2d9c4
Gerrit-Change-Number: 138256
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Liu <ianahao331@xxxxxxxxx>
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Paris Oplopoios <parisoplop@xxxxxxxxx>
Gerrit-Attention: Hao Liu <ianahao331@xxxxxxxxx>
Gerrit-Comment-Date: Mon, 22 Aug 2022 16:29:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
---------- Forwarded message ---------
发件人: Paris Oplopoios (via Code Review) <gerrit@xxxxxxxxxxxxxxxxxxxxxx>
Date: 2022年8月23日周二 00:30
Subject: [core] tdf#148251 Use std::swap instead of using temporary values
To: Hao Liu <ianahao331@xxxxxxxxx>
发件人: Paris Oplopoios (via Code Review) <gerrit@xxxxxxxxxxxxxxxxxxxxxx>
Date: 2022年8月23日周二 00:30
Subject: [core] tdf#148251 Use std::swap instead of using temporary values
To: Hao Liu <ianahao331@xxxxxxxxx>
Attention is currently required from: Hao Liu.
Paris Oplopoios has posted comments on this change. ( https://gerrit.libreoffice.org/c/core/+/138256 )
Change subject: tdf#148251 Use std::swap instead of using temporary values
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
Looks good to me but don't have merge privileges so you're gonna have to find a different reviewer
--
To view, visit https://gerrit.libreoffice.org/c/core/+/138256
To unsubscribe, or for help writing mail filters, visit https://gerrit.libreoffice.org/settings
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Change-Id: Ibbc46bfb17d4d27dc40e63c65190b3f3a5f2d9c4
Gerrit-Change-Number: 138256
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Liu <ianahao331@xxxxxxxxx>
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Paris Oplopoios <parisoplop@xxxxxxxxx>
Gerrit-Attention: Hao Liu <ianahao331@xxxxxxxxx>
Gerrit-Comment-Date: Mon, 22 Aug 2022 16:29:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment