New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

2 new defect(s) introduced to LibreOffice found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1507935:  Performance inefficiencies  (PASS_BY_VALUE)
/sw/source/filter/ww8/wrtww8.hxx: 354 in DrawObj::DrawObj(ww8::Frame, int, Point, SvxFrameDirection, unsigned int)()


________________________________________________________________________________________________________
*** CID 1507935:  Performance inefficiencies  (PASS_BY_VALUE)
/sw/source/filter/ww8/wrtww8.hxx: 354 in DrawObj::DrawObj(ww8::Frame, int, Point, SvxFrameDirection, unsigned int)()
348         Point maParentPos;          // Points
349         sal_Int32 mnThick;          // Border Thicknesses
350         SvxFrameDirection mnDirection; // If BiDi or not
351         unsigned int mnHdFtIndex;   // 0 for main text, +1 for each subsequent
352                                     // msword hd/ft
353     
>>>     CID 1507935:  Performance inefficiencies  (PASS_BY_VALUE)
>>>     Passing parameter rContent of type "ww8::Frame" (size 160 bytes) by value.
354         DrawObj(ww8::Frame rContent, WW8_CP nCp, Point aParentPos, SvxFrameDirection nDir,
355                 unsigned int nHdFtIndex)
356             : mnCp(nCp), mnShapeId(0), maContent(std::move(rContent)), maParentPos(aParentPos),
357             mnThick(0), mnDirection(nDir), mnHdFtIndex(nHdFtIndex) {}
358         void SetShapeDetails(sal_uInt32 nId, sal_Int32 nThick);
359     };

** CID 1507934:  Performance inefficiencies  (PASS_BY_VALUE)
/sw/source/filter/ww8/wrtww8.hxx: 1396 in GraphicDetails::GraphicDetails(ww8::Frame, unsigned short, unsigned short)()


________________________________________________________________________________________________________
*** CID 1507934:  Performance inefficiencies  (PASS_BY_VALUE)
/sw/source/filter/ww8/wrtww8.hxx: 1396 in GraphicDetails::GraphicDetails(ww8::Frame, unsigned short, unsigned short)()
1390     public:
1391         ww8::Frame maFly;                // surrounding FlyFrames
1392         sal_uLong mnPos;                // FilePos of the graphics
1393         sal_uInt16 mnWid;               // Width of the graphics
1394         sal_uInt16 mnHei;               // Height of the graphics
1395     
>>>     CID 1507934:  Performance inefficiencies  (PASS_BY_VALUE)
>>>     Passing parameter aFly of type "ww8::Frame" (size 160 bytes) by value.
1396         GraphicDetails(ww8::Frame aFly, sal_uInt16 nWid, sal_uInt16 nHei)
1397             : maFly(std::move(aFly)), mnPos(0), mnWid(nWid), mnHei(nHei)
1398         {}
1399     
1400         bool operator==(const GraphicDetails& rIn) const
1401         {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DG49I_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiw4cMGW0ZhATVN1G5glKj3uh5pVAh0rg7ozflDpmf415ZlWXtpLBLixuS4nbUI01yZA15vC0Riv63SnyjklcW7QCPPWhBNG4JvYQ97109lszByoK6LZHLlKAhuda0cYmZ58j2CqESwyT8nOTbx4EpETuwAsfDhGF3-2BMMM-2FsSMP58-3D