Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 7 new defect(s) introduced to LibreOffice found with Coverity Scan. 5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 7 of 7 defect(s) ** CID 1507361: Null pointer dereferences (FORWARD_NULL) ________________________________________________________________________________________________________ *** CID 1507361: Null pointer dereferences (FORWARD_NULL) /sw/source/core/draw/dcontact.cxx: 1637 in SwDrawContact::SwClientNotify(const SwModify &, const SfxHint &)() 1631 } 1632 } 1633 else if (rHint.GetId() == SfxHintId::SwGetZOrder) 1634 { 1635 auto pGetZOrdnerHint = static_cast<const sw::GetZOrderHint*>(&rHint); 1636 auto pFormat(dynamic_cast<const SwFrameFormat*>(&rMod)); >>> CID 1507361: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pFormat" to "Which", which dereferences it. 1637 if(pFormat->Which() == RES_DRAWFRMFMT) 1638 pGetZOrdnerHint->m_rnZOrder = GetMaster()->GetOrdNum(); 1639 } 1640 else if (rHint.GetId() == SfxHintId::SwGetObjectConnected) 1641 { 1642 auto pConnectedHint = static_cast<const sw::GetObjectConnectedHint*>(&rHint); ** CID 1507360: Uninitialized members (UNINIT_CTOR) /editeng/source/accessibility/AccessibleParaManager.cxx: 52 in accessibility::AccessibleParaManager::AccessibleParaManager()() ________________________________________________________________________________________________________ *** CID 1507360: Uninitialized members (UNINIT_CTOR) /editeng/source/accessibility/AccessibleParaManager.cxx: 52 in accessibility::AccessibleParaManager::AccessibleParaManager()() 46 AccessibleParaManager::AccessibleParaManager() : 47 maChildren(1), 48 maEEOffset( 0, 0 ), 49 mnFocusedChild( -1 ), 50 mbActive( false ) 51 { >>> CID 1507360: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "mnChildStates" is not initialized in this constructor nor in any functions that it calls. 52 } 53 54 AccessibleParaManager::~AccessibleParaManager() 55 { 56 // owner is responsible for possible child death 57 } ** CID 1507359: Performance inefficiencies (PASS_BY_VALUE) /vcl/source/gdi/metaact.cxx: 1292 in MetaWallpaperAction::MetaWallpaperAction(const tools::Rectangle &, Wallpaper)() ________________________________________________________________________________________________________ *** CID 1507359: Performance inefficiencies (PASS_BY_VALUE) /vcl/source/gdi/metaact.cxx: 1292 in MetaWallpaperAction::MetaWallpaperAction(const tools::Rectangle &, Wallpaper)() 1286 {} 1287 1288 MetaWallpaperAction::~MetaWallpaperAction() 1289 {} 1290 1291 MetaWallpaperAction::MetaWallpaperAction( const tools::Rectangle& rRect, >>> CID 1507359: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter aPaper of type "Wallpaper" (size 280 bytes) by value. 1292 Wallpaper aPaper ) : 1293 MetaAction ( MetaActionType::WALLPAPER ), 1294 maRect ( rRect ), 1295 maWallpaper (std::move( aPaper )) 1296 {} 1297 ** CID 1507358: Performance inefficiencies (PASS_BY_VALUE) /vcl/unx/generic/print/prtsetup.cxx: 71 in RTSDialog::RTSDialog(psp::PrinterInfo, weld::Window *)() ________________________________________________________________________________________________________ *** CID 1507358: Performance inefficiencies (PASS_BY_VALUE) /vcl/unx/generic/print/prtsetup.cxx: 71 in RTSDialog::RTSDialog(psp::PrinterInfo, weld::Window *)() 65 } 66 67 /* 68 * RTSDialog 69 */ 70 >>> CID 1507358: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter aJobData of type "psp::PrinterInfo" (size 200 bytes) by value. 71 RTSDialog::RTSDialog(PrinterInfo aJobData, weld::Window* pParent) 72 : GenericDialogController(pParent, "vcl/ui/printerpropertiesdialog.ui", "PrinterPropertiesDialog") 73 , m_aJobData(std::move(aJobData)) 74 , m_bDataModified(false) 75 , m_xTabControl(m_xBuilder->weld_notebook("tabcontrol")) 76 , m_xOKButton(m_xBuilder->weld_button("ok")) ** CID 1507357: Performance inefficiencies (PASS_BY_VALUE) /vcl/source/gdi/pdfwriter_impl.cxx: 1195 in vcl::PDFWriterImpl::PDFWriterImpl(vcl::PDFWriter::PDFWriterContext, const com::sun::star::uno::Reference<com::sun::star::beans::XMaterialHolder> &, vcl::PDFWriter&)() ________________________________________________________________________________________________________ *** CID 1507357: Performance inefficiencies (PASS_BY_VALUE) /vcl/source/gdi/pdfwriter_impl.cxx: 1195 in vcl::PDFWriterImpl::PDFWriterImpl(vcl::PDFWriter::PDFWriterContext, const com::sun::star::uno::Reference<com::sun::star::beans::XMaterialHolder> &, vcl::PDFWriter&)() 1189 fRet /= m_nUserUnit; 1190 } 1191 1192 return fRet; 1193 } 1194 >>> CID 1507357: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter aContext of type "vcl::PDFWriter::PDFWriterContext" (size 336 bytes) by value. 1195 PDFWriterImpl::PDFWriterImpl( PDFWriter::PDFWriterContext aContext, 1196 const css::uno::Reference< css::beans::XMaterialHolder >& xEnc, 1197 PDFWriter& i_rOuterFace) 1198 : VirtualDevice(Application::GetDefaultDevice(), DeviceFormat::DEFAULT, DeviceFormat::NONE, OUTDEV_PDF), 1199 m_aMapMode( MapUnit::MapPoint, Point(), Fraction( 1, pointToPixel(1) ), Fraction( 1, pointToPixel(1) ) ), 1200 m_nCurrentStructElement( 0 ), ** CID 1507356: Control flow issues (DEADCODE) /svtools/source/control/accessibleruler.cxx: 218 in SvtRulerAccessible::getAccessibleStateSet()() ________________________________________________________________________________________________________ *** CID 1507356: Control flow issues (DEADCODE) /svtools/source/control/accessibleruler.cxx: 218 in SvtRulerAccessible::getAccessibleStateSet()() 212 nStateSet |= AccessibleStateType::HORIZONTAL; 213 else 214 nStateSet |= AccessibleStateType::VERTICAL; 215 216 if(nStateSet & AccessibleStateType::FOCUSABLE) 217 { >>> CID 1507356: Control flow issues (DEADCODE) >>> Execution cannot reach this statement: "nStateSet &= 0xffffffffffff...". 218 nStateSet &= ~AccessibleStateType::FOCUSABLE; 219 } 220 221 } 222 223 return nStateSet; ** CID 1507355: Null pointer dereferences (FORWARD_NULL) /sw/source/core/edit/edundo.cxx: 73 in SwEditShell::HandleUndoRedoContext(sw::UndoRedoContext &)() ________________________________________________________________________________________________________ *** CID 1507355: Null pointer dereferences (FORWARD_NULL) /sw/source/core/edit/edundo.cxx: 73 in SwEditShell::HandleUndoRedoContext(sw::UndoRedoContext &)() 67 // Before layout calc, inline anchored textboxes have to be synced unless crash. 68 if (pSelFormat->GetAnchor().GetAnchorId() == RndStdIds::FLY_AS_CHAR 69 && pSelFormat->GetOtherTextBoxFormats() && pSObj) 70 SwTextBoxHelper::synchronizeGroupTextBoxProperty(SwTextBoxHelper::changeAnchor, 71 pSelFormat, pSObj); 72 >>> CID 1507355: Null pointer dereferences (FORWARD_NULL) >>> Passing null pointer "pSObj" to "GetCurrentBoundRect", which dereferences it. (The dereference happens because this is a virtual function call.) 73 static_cast<SwFEShell*>(this)->SelectObj( 74 pSObj->GetCurrentBoundRect().Center() ); 75 } 76 else 77 { 78 Point aPt; ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D3fKT_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJi3Klqv22v71rNUMbzWu2sY1T2hY8MjQiqfXazF9Ftw9HCCJSV4ys6kc7DdljjLn-2BbYrAR8ZYanUDkC61gJjrAFnyt990NeaOLZH-2F-2Bzh-2BOjDwkDnrHTwdiXxyUMXiuGSESHQoE62cexiCTAJpuE11xp78kQpjKCCLzfMAZgM-2B8aQkiGe-2FjGK5VuowioeqItwog