Re: suspicious member 'mnDiagramRotation' in class Shape in oox

[Noel Grandin <noelgrandin@xxxxxxxxx>]

On Sat, 16 Jul 2022 at 16:38, Regina Henschel <rb.henschel@xxxxxxxxxxx> wrote:

The class Shape has a member 'mnDiagramRotation' (#376), which can be
set by setDiagramRotation() (#164)
https://opengrok.libreoffice.org/xref/core/include/oox/drawingml/shape.hxx

For that kind of thing, git blame can be helpful, e.g.

$ git blame -L370,+10 include/oox/drawingml/shape.hxx

a1d9b5efb5df3 include/oox/drawingml/shape.hxx (Miklos Vajna         2015-02-17 11:33:26 +0100 370)     typedef std::shared_ptr< ChartShapeInfo >               ChartShapeInfoRef;
04c272eb8396e oox/inc/oox/drawingml/shape.hxx (Daniel Rentz         2010-08-26 18:37:44 +0200 371)
3f2767ad27171 oox/inc/oox/drawingml/shape.hxx (Miklos Vajna         2013-03-03 19:39:05 +0100 372)     OleObjectInfoRef    mxOleObjectInfo;    ///< Additional data for OLE objects.
3f2767ad27171 oox/inc/oox/drawingml/shape.hxx (Miklos Vajna         2013-03-03 19:39:05 +0100 373)     ChartShapeInfoRef   mxChartShapeInfo;   ///< Additional data for chart shapes.
04c272eb8396e oox/inc/oox/drawingml/shape.hxx (Daniel Rentz         2010-08-26 18:37:44 +0200 374)
3381981e76873 oox/inc/oox/drawingml/shape.hxx (Rüdiger Timm         2008-01-17 07:06:10 +0000 375)     sal_Int32                       mnRotation;
cf53f243d411b include/oox/drawingml/shape.hxx (Grzegorz Araminowicz 2017-08-20 20:40:51 +0200 376)     sal_Int32                       mnDiagramRotation; // rotates shape prior to sizing, does not affect text rotation
8ee4af289f079 include/oox/drawingml/shape.hxx (Noel Grandin         2014-04-01 13:41:19 +0200 377)     bool                            mbFlipH;
8ee4af289f079 include/oox/drawingml/shape.hxx (Noel Grandin         2014-04-01 13:41:19 +0200 378)     bool                            mbFlipV;

8ee4af289f079 include/oox/drawingml/shape.hxx (Noel Grandin         2014-04-01 13:41:19 +0200 379)     bool                            mbHidden;

and then

$ git show cf53f243d411b

    commit cf53f243d411b199ebf06661273c71de3b89753c
    Author: Grzegorz Araminowicz <g.araminowicz@xxxxxxxxx>
    Date:   Sun Aug 20 20:40:51 2017 +0200
    SmartArt: shape rotation support