Hi there,
Despite the pessimism in the code, PPC Skia seems to be ~working[1]for
Firefox on PPC and accepting big-endian patches.
FreeBSD seems to patch the acknowledgement out[2] ;-)
Firefox has:
#define I_ACKNOWLEDGE_SKIA_DOES_NOT_SUPPORT_BIG_ENDIAN
in its SkUserConfig.h[3]
Any objections with following Firefox's approach and going with this ?
I anticipate it works better than advertised.
ATB,
Michael.
On 05/05/2022 17:59, Luboš Luňák wrote:
On Thursday 05 of May 2022, Michael Meeks wrote:
Nothing critical, but perhaps interesting - I assume up-stream Skia
cares nothing for a PPC port =)
https://github.com/google/skia/blob/main/include/core/SkTypes.h#L221 :
#if defined(SK_CPU_BENDIAN)
&& !defined(I_ACKNOWLEDGE_SKIA_DOES_NOT_SUPPORT_BIG_ENDIAN)
#error "The Skia team is not endian-savvy enough to support big-endian
CPUs."
#error "If you still want to use Skia,"
#error "please define I_ACKNOWLEDGE_SKIA_DOES_NOT_SUPPORT_BIG_ENDIAN."
#endif
[1] - https://bugzilla.mozilla.org/show_bug.cgi?id=1503749
[2] -
https://reviews.freebsd.org/file/data/yulperjvlyeswfxkf7fj/PHID-FILE-cdyntuzagpznlxghldcc/D22184.diff
[3] -
https://searchfox.org/mozilla-central/source/gfx/skia/skia/include/config/SkUserConfig.h#127
--
michael.meeks@xxxxxxxxxxxxx <><, GM Collabora Productivity
Hangout: mejmeeks@xxxxxxxxx, Skype: mmeeks
(M) +44 7795 666 147 - timezone usually UK / Europe
