ESC meeting minutes: 2022-01-06

[Miklos Vajna <vmiklos@xxxxxxxxxxxxx>]

* Present:
    + Stephan, Michael W, Michael S, Jan-Marek, Hossein, Heiko, Caolan, Eike, Olivier, Miklos, Thorsten, Kendy

* Completed Action Items:
    + Release note that Calc's quick filter searches now (>=7.3) for values instead of formulas (Heiko)

* Pending Action Items:
    + None

* Release Engineering update (Cloph)
    + 7.2.5 is now out
    + 7.3 status: RC2 next week (+ creating the libreoffice-7-3-0 branch)
      + late feature request: re-enable inline fieldmark support
        (https://gerrit.libreoffice.org/c/core/+/125558) (Thorsten)
        + this is now in, hoping to fix 2 more related bugs (Michael S)
    + Remotes: Android, iOS
    + Android viewer

* Documentation (Olivier)
    + New Help
      + Some refactor/simplification in CSS
    + HelpContent2
      + Many updates and closing bugs (ohallot, R. Lima, S Horacek, A. Barrientos)
         + Typos reported by translators.
      + Refactoring for readability (Johnny_m)
    + Guides
      + Published Writer Guide for macOS
         + based on the content of the shared guide, just custom keyboard, etc.
         + Jean H. Weber
      + Published draw guide 7.2 !
         + Peter Schofield
         + The Guides library is now in synch with the software)
    + Bugzilla Documentation statistics
        243(243) bugs open
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
           created     19(11)    41(6)     90(5)      318(0)
         commented     58(38)   126(32)   353(12)    1644(27)
          resolved      7(2)     20(2)     46(4)      194(1)
    + top 10 contributors:
          Rafael Lima made 44 changes in 1 month, and 290 changes in 1 year
          Olivier Hallot made 28 changes in 1 month, and 502 changes in 1 year
          Ilmari Lauhakangas made 17 changes in 1 month, and 89 changes in 1 year
          Nabet, Julien made 17 changes in 1 month, and 51 changes in 1 year
          Foote, V Stuart made 13 changes in 1 month, and 69 changes in 1 year
          gmarco made 9 changes in 1 month, and 16 changes in 1 year
          Kaganski, Mike made 8 changes in 1 month, and 91 changes in 1 year
          Dieter made 6 changes in 1 month, and 120 changes in 1 year
          Alain Romedenne made 5 changes in 1 month, and 27 changes in 1 year
          Juan made 4 changes in 1 month, and 4 changes in 1 year

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        258(258) (topicUI) bugs open, 156(156) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week   1 month    3 months   12 months
             added      2(-4)     8(-7)     26(-6)      86(-5)
         commented     55(25)   227(-56)   605(-19)   3038(-24)
           removed      0(0)      4(0)       7(0)       36(0)
          resolved      4(3)     26(-5)     75(-3)     414(1)
    + top 10 contributors:
          Heiko Tietze made 125 changes in 1 month, and 2044 changes in 1 year
          Foote, V Stuart made 41 changes in 1 month, and 541 changes in 1 year
          Kaganski, Mike made 28 changes in 1 month, and 179 changes in 1 year
          Dieter made 26 changes in 1 month, and 280 changes in 1 year
          MarjaE made 19 changes in 1 month, and 19 changes in 1 year
          Stéphane Guillou made 19 changes in 1 month, and 72 changes in 1 year
          McNamara, Caolán made 12 changes in 1 month, and 28 changes in 1 year
          Thomas Lendo made 12 changes in 1 month, and 36 changes in 1 year
          jsv made 9 changes in 1 month, and 10 changes in 1 year
          Henschel, Regina made 9 changes in 1 month, and 78 changes in 1 year

    + 14 new tickets with needsUXEval Dec/16-Jan/05
      [Bug 146593] [Discussion] Enforce style details for all styles
      [Bug 146545] [Enhancement] Add "Colibre (dark)" icon style
      [Bug 146552] DRAW: Export Functionality (deprecated efficiency)
      [Bug 146493] "Insert > Special Character" and "Insert > Formatting Mark"
           should be renamed
      [Bug 146409] customize keyboard simpler
   -> [Bug 146386] Drop support for FTP
        + https://bugs.documentfoundation.org/show_bug.cgi?id=146386
        + any objections for the removal? (Heiko)
        + supporting it (Thorsten)
          + browsers already dropped it
          + non-encrypted
          + helps maintenance
        + ftp can be used with tls, but our code doesn't support that (Michael S)
          + not much value
        + fine with the removal (Stephan)
AI: update the bug (Heiko)
      [Bug 146380] (Enhancement) More View Options
      [Bug 105985] Make Template Manager's directory scanning smarter
      [Bug 146369] An extra word in the tooltip when hovering over a footnote
      [Bug 146097] RED CROSS -- search toolbar close button's RED color is ambiguous
      [Bug 146356] ODT: No easy way to create an empty paragraph before Table of
           Content if document starts with table of content
      [Bug 146033] Output to HTML: Field shadings shouldn't be part of Html-export
      [Bug 140820] Should there be a "Default Frame Style", which each builtin
           Frame Style "Inherits from"?
   -> [Bug 146261] Bookmark... dialog should hold its resize from defaults for
           current session
        - if the size is to persistent across sessions, then it should consider what happens if new widgets are added to the dialog in new versions, or the layout is changed. What if the ui font size is changed, and so on.
        - minimum size always counts

* Crash Testing (Caolan)
    + 14(+0) import failure, 3(+0) export failures
    + 0 coverity issues
    + 8 ossfuzz issues

* Crash Reporting (Xisco)
    + 7.2.2.2    34768(+1527)
    + 7.2.3.2    4162(+300)
    + 7.2.4.1    10239(+3373)
    + 7.2.5.1    17(+5)

* Mentoring/EasyHack update (Hossein)
          committer...   1 week     1 month      3 months    12 months
                  open      56(-8)     108(-6)      150(0)       216(1)
               reviews     326(-66)   1230(-32)    3170(-54)   10528(200)
                merged     261(-47)   1298(-112)   4037(4)     12904(257)
             abandoned      15(-4)      66(0)       167(10)      597(14)
           own commits     226(14)     930(-49)    3134(9)     12802(77)
        review commits      82(12)     271(11)     1013(-6)     4243(28)
        contributor...   1 week     1 month      3 months    12 months
                  open      23(-20)     58(-21)      93(-19)     183(-18)
               reviews     762(-52)   2998(-208)   8798(-6)    28874(572)
                merged      33(6)       86(10)      368(-12)    1526(33)
             abandoned       9(-2)      21(8)        50(-7)      403(9)
           own commits      48(7)      124(12)      489(8)      1927(25)
        review commits       0(0)        0(0)         0(0)         0(0)
    + easyHack statistics:
       needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 285(285)
       total 338(338)   assigned 27(27)   open 282(282)
    + top 10 contributors:
          Johnny_M made 84 patches in 1 month, and 921 patches in 1 year
          Kevin Suo made 6 patches in 1 month, and 31 patches in 1 year
          Attila Bakos made 4 patches in 1 month, and 30 patches in 1 year
          Vaibhav Malik made 4 patches in 1 month, and 4 patches in 1 year
          Ismael Luceno made 3 patches in 1 month, and 5 patches in 1 year
          Ramreiso Kashung made 3 patches in 1 month, and 3 patches in 1 year
          Po-Yen Huang made 2 patches in 1 month, and 7 patches in 1 year
          Dhiraj Holden made 2 patches in 1 month, and 2 patches in 1 year
          Pesi Taototo made 2 patches in 1 month, and 2 patches in 1 year
          Olivier R made 2 patches in 1 month, and 2 patches in 1 year
    + top 10 reviewers:
          Thorsten Behrens made 168 review comments in 1 month, and 568 in 1 year
          Olivier Hallot made 144 review comments in 1 month, and 1170 in 1 year
          Xisco Fauli made 96 review comments in 1 month, and 758 in 1 year
          Adolfo Jayme Barrientos made 88 review comments in 1 month, and 740 in 1 year
          Kaganski, Mike made 72 review comments in 1 month, and 716 in 1 year
          Rathke, Eike made 48 review comments in 1 month, and 262 in 1 year
          Nabet, Julien made 46 review comments in 1 month, and 396 in 1 year
          McNamara, Caolán made 44 review comments in 1 month, and 446 in 1 year
          Grandin, Noel made 44 review comments in 1 month, and 578 in 1 year
          Hossein made 40 review comments in 1 month, and 148 in 1 year
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Ramreiso Kashung
This week we have got more commits from the contributors.
We had ~35 merged commits from the contributors, in which half of of them was coding related
Contributors: 13 people (those without commit access)
New contributor: 1 person
New EasyHack:
https://bugs.documentfoundation.org/show_bug.cgi?id=146619 Removed unused #includes from C/C++ files
  + did we have a bug like that already? (Miklos)
  + https://bugs.documentfoundation.org/show_bug.cgi?id=42949 is the old one (Michael W)
  + GSoC for this year, new rules (Hossein)
    + you must be an "open source newbie" to be selected
    + Ilmari has some ideas about this
    + it might be a zero-sum game (Thorsten)
      + good side: no "officially a student" rule anymore
      + bad side: but has to be really new to open-source

* Commit Access
  + None

* Developer Certification (Stephan/Kendy/Thorsten/László)
  + resting since: 1 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
  + works in general, broken bots are taken offline (Miklos)

* l10n (Sophie)
  + no updates

* More variance in the Gerrit CI runs (Jan-Marek)
    + CI infra change: switch a Gerrit build to --enable-mergelibs
    + was suggested by cloph to bring to ESC (see patch comments):
        p1 https://gerrit.libreoffice.org/c/core/+/127426
           Switches Linux release 64 to --enable-mergelibs
    + We had a build-breaking patch for mergelibs / callgrind TB:
        p2 https://gerrit.libreoffice.org/c/core/+/127394
        p3 https://gerrit.libreoffice.org/c/core/+/127429
        Not detectable by current Gerrit CI setup.
    + I tested p3 by pushing the patchset of p1 + p3.
        - p1 broke the release build like the callgrind TB
        - p3 fixed the broken mergelibs build
    + I suggest to switch a Gerrit build to mergelibs permanently
        - = merge p1
        - Will already fail in Gerrit, not later in Callgrind.
        - I selected the Linux 64bit release, because it's the fastest
          x86, but I really have no preference.
    + what is the cost of turning mergelibs on? (Miklos)
      + confident that the Linux build is still faster than the Windows one, even with mergelibs on
    + like the idea (Thorsten)
      + because releases use it (Linux, Windows)
    + Xisco says this won't affect bibisect
AI: submit the change after rebase (Jan-Marek)

* What’s cooking (Miklos)
  + finally got around to update the GPG stack to latest versions (Thorsten)
    + perhaps backport to libreoffice-7-3?
    + small new feature: gpgmepp: key export one option: lightweight (just the key, not all the signatures), now this is passed through -> less patches
  + little bit imported Word-style table border merging (Miklos)
    + less inner border rendering
  + Writer textboxes are now working even inside group shapes (NISZ)

        +  tdf#66039 (Thorsten)


* QA update (Xisco)
    + Please help flesh out the monthly reports:
          https://nextcloud.documentfoundation.org/s/2qbepFYXXan4ief

    + UNCONFIRMED: 1622 (+9)
        + enhancements: 250  (+5)
        + needsUXEval: 7 (-1)
        + haveBackTrace: 4 (+0)
        + needsDevAdvice: 28 (+0)
        + documentation:  11 (-3)
        + android:  1 (+0)
        + iOS:  0 (+0)
        + Online:  10 (+0)



    + Most pressing bugs:
     New:
     Old:
     Fixed:


    + New high severity bugs of the week:
        + Icons blurry with visible artifacts in various cases like with increased font scaling (gen/gtk3/macOS/Win with SVG icons)
            + https://bugs.documentfoundation.org/show_bug.cgi?id=122113
            + Tomaz?

        + SUM() does not use approx summation anymore since Kahan summation is used
            + https://bugs.documentfoundation.org/show_bug.cgi?id=146367
            + already assigned to Eike

        + Unable to print using LO  7.3.0.1 on macOS
            + https://bugs.documentfoundation.org/show_bug.cgi?id=146465
            + Lubos?

* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +116  -21 (-104) overall)
      many thanks to the top bug squashers:
       QA Administrators       14
       Heiko Tietze            7
       Julien Nabet            7
       Buovjaga                5
       Olivier Hallot          5
       Telesto                 5
       Armin Le Grand          4
       Michael Warner          4
       stragu                  4
       zcrhonek                4

    + top 10 bugs reporters:
       Telesto                 9
       Hossein                 4
       Gabor Kelemen (allotropia) 3
       golemus                 3
       jsv                     3
       Aron Budea              2
       Dinky                   2
       Heiko Tietze            2
       Jan Vlug                2
       NarayanAras             2

    + top 10 bugs fixers:
       Olivier Hallot          4
       Nabet, Julien           3
       Stéphane Guillou        3
       Kaganski, Mike          2
       Le Grand, Armin         2
       Marco Pinto             2
       Rafael Lima             2
       Tünde Tóth              2
       libre officer           2
       *UNKNOWN*               1

    + top 10 bugs confirmers:
       Crhonek, Zdeněk         14
       Dieter                  9
       Nabet, Julien           8
       m.a.riosv               8
       Alex Thurgood           5
       Stéphane Guillou        4
       Thomas Lendo            4
       Hossein                 3
       Bielefeld, Rainer       2
       Heiko Tietze            2

* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 1/53 -     1 %  (+0)
     5.4 : 0/41 -     0 %  (+0)
     5.3 : 0/54 -     0 %  (+0)
     5.2 : 0/43 -     0 %  (+0)
     5.1 : 1/36 -     2 %  (+0)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 0/76 -     0 %  (+0)
     4.3 : 0/73 -     0 %  (+0)
     4.2 : 2/134 -    1 %  (+0)
     4.1 : 3/85 -     3 %  (+0)
     4.0 : 2/83 -     2 %  (+0)
     old : 2/247 -    0 %  (+0)

* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Crhonek, Zdeněk        6
        Raal                   3
        deepoose2011           1
        Kevin Suo              1
        Xisco Fauli            1

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Crhonek, Zdeněk        7
        Raal                   3
        Kevin Suo              3
        deepoose2011           1
        Xisco Fauli            1

* all bugs tagged with 'regression'
   + 1282(+6) bugs open of 11450(+11) total 12(+0) high prio.

     done by:
        Crhonek, Zdeněk        5
        Kevin Suo              3
        Telesto                2
        Dieter                 1
        Alex Thurgood          1
        Raal                   1

* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 9(+0)
     Calc          - 1(+0)
     Draw          - 1(+0)
     LibreOffice   - 1(+0)

   by OS:
     All           - 11(+0)
     Linux         - 0(+0)
     Mac OS X      - 0(+0)
     Windows       - 1(+0)

* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 438(+5)
     Calc                     - 214(+4)
     Impress                  - 131(+0)
     Writer: docx filter      - 54(+0)
     LibreOffice              - 50(+2)
     Draw                     - 48(+0)
     UI                       - 48(-2)
     Crashes                  - 46(+1)
     Borders                  - 40(+0)
     Writer: perf             - 37(+0)
     Writer: other filter     - 35(+0)
     Base                     - 34(+0)
     Chart                    - 30(+0)
     RTL                      - 27(+0)
     Printing and PDF export  - 22(+0)
     Writer: doc filter       - 22(+0)
     graphics stack           - 21(+0)
     BASIC                    - 18(+0)
     filters and storage      - 17(+0)
     Formula Editor           - 2(+0)
     framework                - 1(+0)
     sdk                      - 1(+0)