ESC meeting minutes: 2021-10-21

Miklos Vajna <vmiklos@xxxxxxxxxxxxx> · Thu, 21 Oct 2021 16:34:51 +0200



* Present:
    + Heiko, Caolan, Eike, Gabriel, Hossein, Michael W, Michael S, Stephan, Xisco, Miklos, Cloph, Kendy

* Completed Action Items:
    + Create https://wiki.documentfoundation.org/ReleasePlan/7.3 (Cloph)

* Pending Action Items:
    + None

* Release Engineering update (Cloph)
    + 7.2 status: 7.2.3 rc1 in 2 weeks
    + 7.1 status: 7.1.7 rc2 next week
    + 7.3 alpha1: next week, rc1 around Christmas
    + Remotes: Android (has new translations, though), iOS
    + Android viewer

* Documentation (Olivier)
  + Missing Olivier

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        256(256) (topicUI) bugs open, 155(155) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week    1 month    3 months   12 months
             added      4(-7)     15(-5)     35(-8)      90(-5)
         commented     43(-28)   202(-17)   646(-90)   3216(-58)
           removed      2(2)       2(1)       6(0)       37(1)
          resolved      8(1)      26(1)      87(-3)     468(-3)
    + top 10 contributors:
          Heiko Tietze made 140 changes in 1 month, and 2254 changes in 1 year
          Foote, V Stuart made 56 changes in 1 month, and 587 changes in 1 year
          Telesto made 36 changes in 1 month, and 651 changes in 1 year
          Dieter made 20 changes in 1 month, and 287 changes in 1 year
          Ross Johnson made 17 changes in 1 month, and 25 changes in 1 year
          Kaganski, Mike made 16 changes in 1 month, and 171 changes in 1 year
          Roman Kuznetsov made 14 changes in 1 month, and 222 changes in 1 year
          Xisco Fauli made 14 changes in 1 month, and 181 changes in 1 year
          Ilmari Lauhakangas made 11 changes in 1 month, and 381 changes in 1 year
          Timur made 9 changes in 1 month, and 124 changes in 1 year

   + Zarro new boogs with needUXEval Oct/15-21
     + discussion is ongoing, though

* Crash Testing (Caolan)
    + 7(+0) import failure, 3(+0) export failures
    + 0 coverity issues (up and down a bit)
    + 4 ossfuzz issues (all timeouts)
     + turning msan into non-experimental, in progress

* Crash Reporting (Xisco)
   + https://crashreport.libreoffice.org/stats/version/7.1.6.2
         + (+86) 1016 930 906 650 210 0
   + https://crashreport.libreoffice.org/stats/version/7.2.1.2
         + (+141) 2068 2209 2042 1450 0
   + https://crashreport.libreoffice.org/stats/version/7.2.2.2
         + (+752) 752 0

   + Fixes in 7.2.2.2
	- SvTreeListEntry::NextSibling()
		- Thanks to Caolán
      - lcl_appendLineData
		- Thanks to Stephan B.
	- sw::GetZOrderLayer::operator()(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const &)
		- Thanks to Michael S.
    + which mean half of the crashes

* Mentoring/EasyHack update (Hossein)
          committer...   1 week     1 month     3 months    12 months
                  open      53(-82)    171(6)      223(6)       270(7)
               reviews     382(-54)   1304(64)    3632(-80)    8276(264)
                merged     279(-6)    1196(29)    3632(-46)    9730(275)
             abandoned      11(-4)      40(-1)     177(-5)      499(11)
           own commits     218(-39)    987(-6)    3034(-43)   12685(30)
        review commits      49(-13)    247(-20)    891(-52)    4302(7)
        contributor...   1 week     1 month     3 months     12 months
                  open      35(-7)      72(9)      135(3)        172(12)
               reviews     758(-18)   2864(96)    8318(-116)   21524(630)
                merged      30(2)      132(8)      344(-1)       882(30)
             abandoned       4(-1)      50(-10)    131(1)        321(4)
           own commits      14(2)       84(-6)     305(-30)     1956(-2)
    + easyHack statistics:
       needsDevEval 8(8)   needsUXEval 1(1)
       total 326(326)   assigned 26(26)   open 273(273)
    + top 10 contributors:
          Johnny_M made 30 patches in 1 month, and 763 patches in 1 year
          Ross Johnson made 18 patches in 1 month, and 24 patches in 1 year
          Kevin Suo made 4 patches in 1 month, and 25 patches in 1 year
          Nagy Tibor made 3 patches in 1 month, and 38 patches in 1 year
          Dániel Arató made 3 patches in 1 month, and 20 patches in 1 year
          Steve Fanning made 2 patches in 1 month, and 60 patches in 1 year
          Tomoyuki Kubota made 2 patches in 1 month, and 7 patches in 1 year
          Aleś Bułojčyk made 2 patches in 1 month, and 2 patches in 1 year
          Natalia Gavrilova made 2 patches in 1 month, and 2 patches in 1 year
          Ismael Luceno made 2 patches in 1 month, and 2 patches in 1 year
    + top 10 reviewers:
          Kaganski, Mike made 140 review comments in 1 month, and 570 in 1 year
          Michael Stahl made 140 review comments in 1 month, and 702 in 1 year
          Castagno, Giuseppe made 98 review comments in 1 month, and 98 in 1 year
          Adolfo Jayme Barrientos made 80 review comments in 1 month, and 566 in 1 year
          Marco Marinello made 80 review comments in 1 month, and 80 in 1 year
          Xisco Fauli made 74 review comments in 1 month, and 570 in 1 year
          Vajngerl, Tomaž made 72 review comments in 1 month, and 430 in 1 year
          Olivier Hallot made 70 review comments in 1 month, and 754 in 1 year
          Vajna, Miklos made 60 review comments in 1 month, and 446 in 1 year
          Németh, László made 58 review comments in 1 month, and 384 in 1 year
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Emanuel Schorsch (Google)
          Henrik Palomäki
  + normal week
  + suggestion: Separate translation bugs, to see the real value from the big noise
    + AI: give code pointers to Hossein to filter this out on the scripting side (Xisco)
    + things like help.git bookmark ids, variable names in code
    + fear that something like “left align” vs “align left” will have less attention this way (Heiko)
      + just stats, don’t worry (Hossein)
  + thanks to all the reviewers!


* privacy policy URL required by the configure (Michael S)
  + --with-privacy-url=…, why don’t give a dummy value by default?
  + would rather prefer: flip the default of the online update (Cloph)
AI: flip the Online update default on macOS and Windows (Cloph)

* Commit Access
  + None

* Developer Certification (Stephan/Kendy/Thorsten/László)
  + resting since: 16 weeks (limit: 20 weeks)

* Jenkins / CI update (Cloph)
    from:Thu Oct 14 14:05:34 2021
    master linux rel  jobs: 140 ok: 140 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master linux dbg  jobs: 122 ok: 114 ko:   8 fail ratio:  6.56 % break:   8 broken duration: 4.44%
    master mac rel    jobs: 116 ok: 116 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master mac dbg    jobs: 127 ok: 127 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master win rel    jobs: 109 ok:  82 ko:  26 fail ratio: 23.85 % break:  19 broken duration:22.30%
    master win dbg    jobs: 112 ok:  92 ko:  20 fail ratio: 17.86 % break:  15 broken duration:19.76%
    master win64 dbg  jobs: 113 ok:  88 ko:  25 fail ratio: 22.12 % break:  17 broken duration:23.55%
    master gerrit lin jobs: 472 ok: 389 ko:  58 fail ratio: 12.29% time for ok: mean:  19 median:  15
    master gerrit plg jobs: 434 ok: 285 ko: 115 fail ratio: 26.50% time for ok: mean:  38 median:  36
    master gerrit win jobs: 505 ok: 344 ko: 115 fail ratio: 22.77% time for ok: mean:  67 median:  63
    master gerrit mac jobs: 469 ok: 376 ko:  59 fail ratio: 12.58% time for ok: mean:  28 median:  24
    master android    jobs: 413 ok: 364 ko:  24 fail ratio:  5.81% time for ok: mean:  19 median:  12
    master gerrit all jobs: 466 ok: 248 ko: 170 fail ratio: 36.48% time for ok: mean:  70 median:  66
   + https://dev-www.libreoffice.org/tmp/gerrit_211021.html
   + tests that failed more than twice in last seven days
      3 CppunitTest_sc_dataprovider		gerrit_linux_gcc_release
      3 UITest_writer_tests7		gerrit_linux_clang_dbgutil
      4 CppunitTest_sc_ucalc_condformat		gerrit_windows
      4 CppunitTest_sc_ucalc_sharedformula		gerrit_windows
      4 CppunitTest_sc_ucalc_sort		gerrit_windows
      4 UITest_writer_tests3		gerrit_linux_clang_dbgutil
     11 JunitTest_toolkit_unoapi_4		gerrit_linux_clang_dbgutil
     15 Killed by the kill-wrapper		gerrit_linux_clang_dbgutil
  + this week: normal week
    + vcl_filters and toolkit_unoapi test failures were specific to a single bot

* l10n (Sophie)
  + work is going on

* What’s cooking (Miklos)
  + "svx: Don't end text edit mode for all views" from Tomaz
    + i.e. editeng-level undo managers are now specific to the view
  + updating lots of old externals (Caolan)
    + download.lst is the primary source
    + then the flatpak json
    + no need to worry about the versions in the oss-fuzz script

* FYI: board election nomination phase started (Cloph)
  + https://blog.documentfoundation.org/blog/2021/10/19/announcing-the-election-for-the-next-tdf-board-of-directors/
  + nomination deadline: 25th Nov

* Budget 2022 (Xisco)
  + https://wiki.documentfoundation.org/Development/Budget2022
  + ideas are still welcome, probably till Dec (Cloph)

* QA update (Xisco)

    + UNCONFIRMED: 1511 (+17)
        + enhancements: 233  (-5)
        + needsUXEval: 4 (-4)
        + haveBackTrace: 3 (+0)
        + needsDevAdvice: 27 (+0)
        + documentation:  8 (+1)
        + android:  1 (+0)
        + iOS:  0 (+0)
        + Online:  17 (+0)

    + Most pressing bugs:
     New:
                None
     Old:
        + Calc disables header/footer or looses footer content when saves a spreadsheet ( part 2 )
            + https://bugs.documentfoundation.org/show_bug.cgi?id=144940
            + Already assigned, thanks to Daniel

        + Writer document with tables lost data in cells (apparently) replacing with 0
            + https://bugs.documentfoundation.org/show_bug.cgi?id=131025
            + Eike is asking for Writer advice
            + there are some code pointers from Mike K there
		+ Justin’s proposal to fix it: https://gerrit.libreoffice.org/c/core/+/123904

        + macOS: Can't save or open files using Finder dialog on Standard accounts on macOS 10.15 Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=128233

        + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from
          imported PDF are reversed, PDFIProcessor::mirrorString not behaving
            + https://bugs.documentfoundation.org/show_bug.cgi?id=104597

            + Thorsten looking at it Needs someone to volunteer to fix.
            + already listed here for 2 years, and many duplicates

     Fixed:
        + LO crashes after opening of read-only file
            + https://bugs.documentfoundation.org/show_bug.cgi?id=144650
            + Thanks to Noel G.


    + New high severity bugs of the week:
        + form exported as pdf does not embed all required fonts (fix per Comment 43)
            + https://bugs.documentfoundation.org/show_bug.cgi?id=50879
            + not a regression?
            + Miklos to close the bug again, the remaining problem is a separate bug

* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +127  +18 (-136) overall)
      many thanks to the top bug squashers:
       QA Administrators       19
       Heiko Tietze            11
       Justin L                9
       m.a.riosv               8
       Julien Nabet            6
       Mike Kaganski           6
       Buovjaga                5
       Michael Warner          5
       Regina Henschel         5
       Caolán McNamara         4

    + top 10 bugs reporters:
       Justin L                5
       Eyal Rozenberg          4
       Jon R Kibler            3
       Rafael Lima             3
       Telesto                 3
       goodguy00&#64;zoho.com  3
       intmail01               3
       Espirit                 2
       Gabor Kelemen (allotropia) 2
       Jérôme                  2

    + top 10 bugs fixers:
       Justin Luth             5
       McNamara, Caolán        4
       Heiko Tietze            3
       Henschel, Regina        3
       Rathke, Eike            3
                               2
       Hung, Mark              2
       Mrunali Nanaware        2
       Németh, László          2
       Ross Johnson            2

    + top 10 bugs confirmers:
       Robert Großkopf         11
       m.a.riosv               11
       Heiko Tietze            9
       Dieter                  7
       Roman Kuznetsov         6
       Ilmari Lauhakangas      5
       Nabet, Julien           4
       *UNKNOWN*               3
       Henschel, Regina        3
       McNamara, Caolán        2


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 2/53 -     3 %  (+0)
     5.4 : 0/41 -     0 %  (+0)
     5.3 : 0/54 -     0 %  (+0)
     5.2 : 0/43 -     0 %  (+0)
     5.1 : 1/36 -     2 %  (+0)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 0/76 -     0 %  (+0)
     4.3 : 0/73 -     0 %  (+0)
     4.2 : 2/134 -    1 %  (+0)
     4.1 : 3/85 -     3 %  (+0)
     4.0 : 2/83 -     2 %  (+0)
     old : 3/248 -    1 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Budea, Áron            3
        Justin Luth            2
        Ilmari Lauhakangas     1
        Kelemen, Gabor         1
        lbrmk.510              1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Budea, Áron            3
        Justin Luth            2
        Ilmari Lauhakangas     1
        Kelemen, Gabor         1
        lbrmk.510              1


* all bugs tagged with 'regression'
   + 1350(+2) bugs open of 11313(+14) total 17(+0) high prio.

     done by:
        Robert Großkopf        6
        Stéphane Guillou       2
        Telesto                2
        Gerald Pfeifer         1
        Justin Luth            1
        lbrmk.510              1
        Nabet, Julien          1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 11(+0)
     Calc          - 4(+0)
     Draw          - 1(+0)
     LibreOffice   - 1(+0)

   by OS:
     All           - 17(+0)
     Linux         - 0(+0)
     Mac OS X      - 0(+0)
     Windows       - 0(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 452(-3)
     Calc                     - 238(-2)
     Impress                  - 142(+1)
     Crashes                  - 58(+0)
     Writer: docx filter      - 56(+0)
     LibreOffice              - 53(+0)
     Draw                     - 50(+0)
     UI                       - 50(+1)
     Borders                  - 45(-1)
     Writer: perf             - 41(+0)
     Base                     - 38(+2)
     Writer: other filter     - 35(+0)
     Chart                    - 29(-1)
     RTL                      - 27(+0)
     Writer: doc filter       - 24(+0)
     Printing and PDF export  - 23(+0)
     graphics stack           - 23(+0)
     filters and storage      - 19(+0)
     BASIC                    - 17(+0)
     Formula Editor           - 2(+0)
     framework                - 1(+0)
     sdk                      - 1(+0)