ESC meeting minutes: 2021-10-07

[Miklos Vajna <vmiklos@xxxxxxxxxxxxx>]

* Present:
    + Caolan, Cloph, Gabriel, Heiko, Hossein, Michael S, Michael M, Olivier, Xisco, Miklos, Eike, Kendy

* Completed Action Items:
    + send a short mail about the openssh update to the dev list (Heiko)

* Pending Action Items:
    + None

* Release Engineering update (Cloph)
    + 7.2 status: 7.2.2 rc2 is tagged, builds are done, currently uploading
    + 7.1 status: 7.1.7 rc1 next week
    + Remotes: Android, iOS
    + Android viewer
    + 7.3 release plan will be at https://wiki.documentfoundation.org/ReleasePlan/7.3, expect it to be similar to 7.1
    + what happened to the rolling release discussion? (Heiko)
      + depends on the autoupdater work first (Michael M)

* Documentation (Olivier)
    + New Help
       + Fix index search (Ross Johnson)
    + Helpcontents2
       + Updates and fixes (ohallot, R. Lima, S. Fanning, R. Johnson, A.
          Gelmini)
       + Refactors (ohallot, Johnny_M)
       + Bugs:  248 open, 30 partially addressed, 1 open, 4 closed
       + Update dialogs with extended tips (ohallot)
    + Guides
       + Work in progress


* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        257(257) (topicUI) bugs open, 157(157) (needsUXEval) needs to be evaluated by the UXteam
    + Updates:
        BZ changes   1 week   1 month   3 months   12 months
             added     10(1)     17(-1)    42(-1)      92(-1)
         commented     90(40)   224(10)   751(9)     3302(-43)
           removed      0(0)      2(-1)     6(-3)      36(-1)
          resolved      9(7)     27(-2)    95(1)      472(-13)
    + top 10 contributors:
          Heiko Tietze made 131 changes in 1 month, and 2258 changes in 1 year
          Foote, V Stuart made 42 changes in 1 month, and 588 changes in 1 year
          Dieter made 35 changes in 1 month, and 314 changes in 1 year
          Ross Johnson made 23 changes in 1 month, and 23 changes in 1 year
          Roman Kuznetsov made 16 changes in 1 month, and 214 changes in 1 year
          Telesto made 16 changes in 1 month, and 643 changes in 1 year
          Xisco Fauli made 13 changes in 1 month, and 186 changes in 1 year
          Nabet, Julien made 11 changes in 1 month, and 51 changes in 1 year
          Kaganski, Mike made 10 changes in 1 month, and 184 changes in 1 year
          Adolfo Jayme Barrientos made 9 changes in 1 month, and 52 changes in 1 year

      + New tickets with needsUXEval Sep/30-Oct/07

        [Bug 113310] Special characters: A favorite character is only added to
             recent, if you insert it from the special characters dialog
        [Bug 144977] Please apply the "tip of the day" to the opened
             applications [wish]
        [Bug 144121] Writer: Table can be moved to new page, but not back
        [Bug 144946] Base: Tabbed Application UI
   ->   [Bug 144938] Writer table border styles offered are different in the
             toolbar button vs. Table Properties dialog
             + trying to improve consistency here
        [Bug 141335] Tabbed Notebookbar: Style preview should not move the
             selected style to the first one
        [Bug 144920] Selecting text BOLD makes bold numbering as well
        [Bug 140561] wrong term for gutter position in mirrored page layout
        [Bug 144611] Image position off when changing 'to paragraph' to
             'to character' back 'to paragraph' and drag the anchor
        [Bug 144879] Minor wording corrections
        [Bug 144839] Cannot access certain options in Tabbed interface
        [Bug 144853] Sentence case not undone when cycling case

   ->   [Bug 48622] Line thickness specification - too many choices,
             nonintuitive
         + suggest 0.05 (very thin), 0.5 (thin), 1.5 (medium), 2.25 (thick),
            4.5pt (extra thick), and custom
         + preliminary patch at https://gerrit.libreoffice.org/c/core/+/122683

* Crash Testing (Caolan)
    + 6(-1) import failure, 4(+0) export failures
    + 0 coverity issues
    + 3 ossfuzz issues (all Timeouts)
    + how many of the formats are missing fuzzing? (Michael M)
      + dbf is the most recent one (Caolan)
      + 3 Word fuzzers, 1 Excel one, no 1:1 file format ↔ fuzzer mapping

* Crash Reporting (Xisco)
   + https://crashreport.libreoffice.org/stats/version/7.1.6.2
         + (+256) 906 650 210 0
   + https://crashreport.libreoffice.org/stats/version/7.2.0.4
         + (-181) 1842 2023 2483 2159 1768 1068 0
   + https://crashreport.libreoffice.org/stats/version/7.2.1.2
         + (+592) 2042 1450 0
   + https://crashreport.libreoffice.org/stats/signature/ScDBData::UpdateReference(ScDocument%20const%20*,UpdateRefMode,short,long,short,short,long,short,short,long,short)
	+ Since 7.2.1.2
	+ Likely introduced in 0c0444c44107f1a18f23dd0833d462d8dbf56569. Tünde Tóth ?
	+ regression from https://bugs.documentfoundation.org/show_bug.cgi?id=126926
      + no repro steps yet

* Mentoring/EasyHack update (Hossein)
          committer...   1 week     1 month      3 months    12 months
                  open      72(5)      107(-3)      170(-6)      195(0)
               reviews     386(84)    1236(-42)    3766(8)      7690(262)
                merged     260(-47)   1157(-137)   3687(-83)    9174(256)
             abandoned       7(0)       39(-9)      174(-7)      473(7)
           own commits     194(-64)    967(-124)   3028(-16)   12547(-80)
        review commits      71(26)     310(-28)    1019(9)      4271(12)
        contributor...   1 week     1 month      3 months    12 months
                  open      49(13)      78(2)       138(13)      161(14)
               reviews     766(-38)   2812(-232)   8560(-94)   20298(588)
                merged      41(15)     143(6)       363(15)      825(40)
             abandoned      12(-12)     57(7)       131(0)       312(12)
           own commits      40(31)     135(8)       383(9)      1965(13)

    + easyHack statistics:
       needsDevEval 8(8)   needsUXEval 1(1)
       total 328(328)   assigned 27(27)   open 274(274)
    + top 10 contributors:
          Johnny_M made 80 patches in 1 month, and 759 patches in 1 year
          Ross Johnson made 20 patches in 1 month, and 20 patches in 1 year
          Steve Fanning made 4 patches in 1 month, and 60 patches in 1 year
          Baran Aytas made 4 patches in 1 month, and 5 patches in 1 year
          Nagy Tibor made 3 patches in 1 month, and 40 patches in 1 year
          Dániel Arató made 3 patches in 1 month, and 22 patches in 1 year
          Attila Bakos made 2 patches in 1 month, and 35 patches in 1 year
          Marco Pinto made 2 patches in 1 month, and 11 patches in 1 year
          Aleś Bułojčyk made 2 patches in 1 month, and 2 patches in 1 year
          Ismael Luceno made 2 patches in 1 month, and 2 patches in 1 year
    + top 10 reviewers:
          Michael Stahl made 136 review comments in 1 month, and 656 in 1 year
          Kaganski, Mike made 132 review comments in 1 month, and 512 in 1 year
          Olivier Hallot made 112 review comments in 1 month, and 736 in 1 year
          Adolfo Jayme Barrientos made 100 review comments in 1 month, and 554 in 1 year
          Xisco Fauli made 78 review comments in 1 month, and 540 in 1 year
          Thorsten Behrens made 62 review comments in 1 month, and 342 in 1 year
          Németh, László made 56 review comments in 1 month, and 362 in 1 year
          Vajna, Miklos made 56 review comments in 1 month, and 418 in 1 year
          Marco Marinello made 46 review comments in 1 month, and 46 in 1 year
          Grandin, Noel made 42 review comments in 1 month, and 450 in 1 year
    + Patches automatically abandoned:
        call xDesktop->terminate() when catching SIGTERM/SIGINT ( Platon Pronko )
            - https://gerrit.libreoffice.org/#/c/102024
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Verne-Lai (ossii.com.tw)
          Ismael Luceno (iodev.co.uk)

+ Normal week: ~40 merged commits from contributors, 2 new contributors
+ New blog dedicated to LibreOffice development is started:
https://dev.blog.documentfoundation.org/
  + Trying to attract new contributors there, with tutorials, how-tos, articles
  + “Getting started” video is posted for the start
  + Suggestions are welcome for the topics to be covered, videos, etc.

* Commit Access
  + None

* Calc auto-complete behavior changes (Kendy)
    + https://bugs.documentfoundation.org/show_bug.cgi?id=142214
    + Kendy suggested Dennis to do this
    + it turned out to be not appreciated by some users
    + we were not aware that it causes trouble
    + what happened: in Online, did some changes regarding the Calc auto-complete suggestions
    + in many cases, the suggestions are not the best ones
    + long sentence → wrong suggestion if only the end differs for two candidates
    + tried to make it behave closer to what Excel does
    + biggest problem is reverted by Ilmari
    + question is: if we should revert even the rest of the changes or we can try a last idea: different to what Calc used to do
    + last remaining problem: you have to type until you have a single candidate
      + try: bash-like autocompletion: when there are multiple candidates, but all of them have a common prefix, show this common string as the suggestion
      + would that be acceptable?
      + problem is in 7.2 and master, revert only in 7.2? (Xisco)
        + then this would be finished in 7.3
        + would work for us (Kendy)
      + see also https://bugs.documentfoundation.org/show_bug.cgi?id=133494 (Heiko)
        + more or less what Kendy proposed, from Samuel
        + not suggesting the dropdown (Kendy)
          + currently how it appears: pre-selected text
          + used to be: if multiple candidates, then one appeared, but selected
            + enter confirmed it
          + suggestion to try: don’t show the complete sentence, just the common prefix of all candidates
        + let’s not have one more option for this (Heiko)
          + would like code completion-like dropdown
          + alt-down already does this, have the functionality (Kendy)
          + complete re-work would be more like a GSoC project
          + would like to try just the tweaked highlight for the short term
  + not really happy with just seeing the common prefix (Cloph)
  + agree that one more option is not ideal (Kendy)
  + for now, in 7.2, just revert, and try out Kendy’s idea on master

* Developer Certification (Stephan/Kendy/Thorsten/László)
  + resting since: 14 weeks

* Jenkins / CI update (Cloph)
    from:Thu Sep 30 13:55:03 2021
    master linux rel  jobs: 133 ok: 132 ko:   1 fail ratio:  0.75 % break:   1 broken duration: 0.79%
    master linux dbg  jobs: 115 ok: 101 ko:  14 fail ratio: 12.17 % break:  11 broken duration: 9.91%
    master mac rel    jobs:  96 ok:  96 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master mac dbg    jobs:  91 ok:  91 ko:   0 fail ratio:  0.00 % break:   0 broken duration: 0.00%
    master win rel    jobs: 125 ok:  93 ko:  31 fail ratio: 24.80 % break:   1 broken duration:14.08%
    master win dbg    jobs: 123 ok:  90 ko:  32 fail ratio: 26.02 % break:   1 broken duration:14.15%
    master win64 dbg  jobs: 124 ok:  91 ko:  31 fail ratio: 25.00 % break:   1 broken duration:13.98%
    master gerrit lin jobs: 459 ok: 376 ko:  55 fail ratio: 11.98% time for ok: mean:  20 median:  16
    master gerrit plg jobs: 468 ok: 260 ko: 174 fail ratio: 37.18% time for ok: mean:  42 median:  38
    master gerrit win jobs: 502 ok: 300 ko: 161 fail ratio: 32.07% time for ok: mean:  62 median:  58
    master gerrit mac jobs: 474 ok: 358 ko:  70 fail ratio: 14.77% time for ok: mean:  30 median:  26
    master android    jobs: 454 ok: 343 ko:  86 fail ratio: 18.94% time for ok: mean:  19 median:  13
    master gerrit all jobs: 490 ok: 206 ko: 222 fail ratio: 45.31% time for ok: mean:  77 median:  67
   + https://dev-www.libreoffice.org/tmp/gerrit_211007.html
   + tests that failed more than twice in last seven days
      3 CppunitTest_sc_ucalc_copypaste		gerrit_windows
      3 CppunitTest_vcl_backend_test		gerrit_windows
      3 UITest_sw_options		gerrit_linux_clang_dbgutil
      4 CppunitTest_sc_ucalc		gerrit_windows
      6 CppunitTest_sc_ucalc_condformat		gerrit_windows
      7 Killed by the kill-wrapper		gerrit_linux_clang_dbgutil
  + not too many false failures last week
    + let’s encrypt cert changes affected the macOS / Windows bots, now fixed
  + 1 bot with full disk: now fixed (large core files)
    + other machines have a separate /tmp dir to avoid this problem (to host the cleanup script)
    + already re-scheduled the affected 30 builds

* l10n (Sophie)
  + work is going on

* What’s cooking (Miklos)
  + working on a curl-based http UCP (Michael S)
    + works with GET requests, but saving not yet working

* Budget planning upcoming (Cloph)
  + https://wiki.documentfoundation.org/Development/Budget2022
  + if you have good ideas, please add them to this wiki page
  + idea is to collect ideas later this year

* QA update (Xisco)

    + UNCONFIRMED: 1450 (+28)
        + enhancements: 233  (+7)
        + needsUXEval: 7 (+1)
        + haveBackTrace: 3 (+0)
        + needsDevAdvice: 26 (+1)
        + documentation:  7 (+1)
        + android:  1 (+0)
        + iOS:  0 (+0)
        + Online:  17 (+0)


    + Most pressing bugs:
     New:
        + LO crashes after opening of read-only file
            + https://bugs.documentfoundation.org/show_bug.cgi?id=144650
            + Matt?
            + Notify button → crash after clicking too slowly

        + Calc disables header/footer or looses footer content when saves a spreadsheet ( part 2 )
            + https://bugs.documentfoundation.org/show_bug.cgi?id=144940
            + Daniel?
     Old:
        + Writer document with tables lost data in cells (apparently) replacing with 0
            + https://bugs.documentfoundation.org/show_bug.cgi?id=131025
            + Eike is asking for Writer advice
            + there are some code pointers from Mike K there

        + macOS: Can't save or open files using Finder dialog on Standard accounts on macOS 10.15 Catalina
           + https://bugs.documentfoundation.org/show_bug.cgi?id=128233


        + Text runs of RTL scripts (e.g. Arabic, Hebrew, Persian) from
imported
          PDF are reversed, PDFIProcessor::mirrorString not behaving
eikeeikee            + https://bugs.documentfoundation.org/show_bug.cgi?id=104597

            + Thorsten looking at it
            + old problem, but many duplicates



    + New high severity bugs of the week:
        + Insert Cross-reference points to wrong footnote/endnote entry
            + https://bugs.documentfoundation.org/show_bug.cgi?id=101263
            + not a regression?
        + Calc: shrink to fit makes font size unnecessary small compared to cell width
            + https://bugs.documentfoundation.org/show_bug.cgi?id=143978
            + Lubos?

* QA stats
    + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +179  -50 (-141) overall)
      many thanks to the top bug squashers:
       Xisco Faulí             14
       QA Administrators       11
       Heiko Tietze            9
       Mike Kaganski           9
       Caolán McNamara         8
       Timur                   8
       Buovjaga                6
       Dieter                  4
       Roman Kuznetsov         4
       Telesto                 4

    + top 10 bugs reporters:
       NISZ LibreOffice Team   23
       Telesto                 15
       John                    3
       Brian Gifford           2
       CSLam                   2
       David                   2
       Heiko Tietze            2
       Michael Kůr             2
       Michael Warner          2
       Ming Hua                2

    + top 10 bugs fixers:
       McNamara, Caolán        7
       Jim Raykowski           4
       Melenchuk, Vasily       4
       Samuel Mehrbrodt        3
                               2
       *UNKNOWN*               2
       Andreas Heinisch        2
       Heiko Tietze            2
       Olivier Hallot          2
       Andras Timar            1

    + top 10 bugs confirmers:
       Xisco Fauli             26
       Dieter                  11
       Heiko Tietze            10
       *UNKNOWN*               8
       Nabet, Julien           6
       Ezinne Nnamani          5
       Foote, V Stuart         4
       Raal                    4
       Nagy Tibor              3
       Roman Kuznetsov         3


* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 2/53 -     3 %  (+0)
     5.4 : 0/41 -     0 %  (+0)
     5.3 : 0/54 -     0 %  (+0)
     5.2 : 0/43 -     0 %  (+0)
     5.1 : 1/36 -     2 %  (+0)
     5.0 : 0/64 -     0 %  (+0)
     4.4 : 0/76 -     0 %  (+0)
     4.3 : 0/73 -     0 %  (+0)
     4.2 : 2/134 -    1 %  (+0)
     4.1 : 3/85 -     3 %  (+0)
     4.0 : 2/83 -     2 %  (+0)
     old : 3/248 -    1 %  (+0)


* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   +

     done by:
        Raal                   9
        Budea, Áron            3
        Xisco Fauli            3
        Telesto                2
        Ilmari Lauhakangas     1
        lbrmk.510              1
        Michael Warner         1
        Kevin Suo              1


* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   +

     done by:
        Raal                   9
        Budea, Áron            4
        Xisco Fauli            3
        Telesto                2
        Timur                  1
        Ilmari Lauhakangas     1
        Kevin Suo              1


* all bugs tagged with 'regression'
   + 1346(-7) bugs open of 11288(+12) total 18(+2) high prio.

     done by:
        Roman Kuznetsov        2
        Raal                   2
        Telesto                2
        Xisco Fauli            2
        Eleonora Govallo       1
        Ilmari Lauhakangas     1
        Ezinne Nnamani         1
        Kevin Suo              1
        Foote, V Stuart        1


* ~Component   count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer        - 11(+0)
     Calc          - 5(+2)
     Draw          - 1(+0)
     LibreOffice   - 1(+0)

   by OS:
     All           - 18(+2)
     Linux         - 0(+0)
     Mac OS X      - 0(+0)
     Windows       - 0(+0)


* ~Component   count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other            - 456(+3)
     Calc                     - 242(+1)
     Impress                  - 141(-2)
     Crashes                  - 61(-1)
     Writer: docx filter      - 56(-1)
     LibreOffice              - 54(+0)
     Draw                     - 50(+0)
     UI                       - 48(+0)
     Borders                  - 46(+0)
     Writer: perf             - 41(+0)
     Base                     - 36(-4)
     Writer: other filter     - 34(+0)
     Chart                    - 30(+1)
     RTL                      - 27(+0)
     Writer: doc filter       - 24(+0)
     Printing and PDF export  - 22(+1)
     graphics stack           - 22(+0)
     filters and storage      - 19(+0)
     BASIC                    - 17(-1)
     Formula Editor           - 2(+0)
     framework                - 1(+0)
     sdk                      - 1(+0)