Hey,
On Fri, Oct 1, 2021 at 4:02 AM Florian Becker <fb@xxxxxxxxxx> wrote:
Hi Markus,thanks a lot.Is there a list of compiler, which are supported? Also, is there any reason, why cppunit cannot upgrade to c++17?
This would force all dependent projects to use C++17 as well. Already the move to C++11 caused some issues for some older projects using cppunit. Currently I don't see a compelling reason to update for cppunit. The decision to move to C++11 was easier and provided a clear benefit.
I would like to create a cmake definition - do we handle that the same way?
Have you had a look at the feature/cmake branch?
Cheers,
Markus
Regards,FlorianAm 30.09.2021 um 21:56 schrieb Markus Mohrhard <markus.mohrhard@xxxxxxxxxxxxxx>:Hey Florian,On Fri, Oct 1, 2021 at 1:52 AM Markus Mohrhard <markus.mohrhard@xxxxxxxxxxxxxx> wrote:Hey Florian,On Tue, Sep 28, 2021 at 5:59 PM Florian Becker <fb@xxxxxxxxxx> wrote:Hello,
i have patched the libcppunit 1.15.1 to modernize and use clang flags
with highest flag settings. Hopefully you can integrate this patch
inside master. https://github.com/VXAPPS/cppunit/tree/feature-modernize
If you have suggestions, please let me know.I'll have a look during the next few days and will let you know if I have any questions or commentsThanks for your patches. The summary is:* first patch was used without modifications* second patch was split up into smaller commits:* add [[noreturn]]* add override annotations* switch from throw to noexcept* remove semicolons* a complete removal of the old casting macros by me instead of your addition to the portability header* replace 0 with nullptr* disable a few simple compiler warningsI have not yet taken the size_t changes as that part contains some bugs. I have already fixed one but want to have a second look and think about whether this is how we want to solve this problem.I also had to remove all references to [[deprecated]] in this change as [[deprecated]] is only C++14 and at least for now cppunit is still at C++11.* I'll have to think a bit about the third and fourth patch. If I merge them I'll let you know.You can find the full code that I have pushed at:Cheers,MarkusCheers,Markus
Regards,
Florian
