New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

3 new defect(s) introduced to LibreOffice found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1490900:  Error handling issues  (CHECKED_RETURN)
/lotuswordpro/source/filter/lwp9reader.cxx: 114 in Lwp9Reader::ReadFileHeader()()


________________________________________________________________________________________________________
*** CID 1490900:  Error handling issues  (CHECKED_RETURN)
/lotuswordpro/source/filter/lwp9reader.cxx: 114 in Lwp9Reader::ReadFileHeader()()
108             return false;
109     
110         //Remember to initialize the LwpFileHeader::m_nFileRevision first.
111         LwpFileHeader::m_nFileRevision = 0;
112     
113         LwpObjectHeader objHdr;
>>>     CID 1490900:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "Read" without checking return value (as is done elsewhere 4 out of 5 times).
114         objHdr.Read(*m_pDocStream);
115         sal_Int64 pos = m_pDocStream->Tell();
116         m_LwpFileHdr.Read(m_pDocStream);
117         return m_pDocStream->CheckSeek(pos + objHdr.GetSize());
118     }
119     

** CID 1490899:  Error handling issues  (CHECKED_RETURN)
/ucb/source/ucp/file/filtask.cxx: 2000 in fileaccess::TaskManager::copy_recursive(const rtl::OUString &, const rtl::OUString &, fileaccess::TaskManager::FileUrlType, bool)()


________________________________________________________________________________________________________
*** CID 1490899:  Error handling issues  (CHECKED_RETURN)
/ucb/source/ucp/file/filtask.cxx: 2000 in fileaccess::TaskManager::copy_recursive(const rtl::OUString &, const rtl::OUString &, fileaccess::TaskManager::FileUrlType, bool)()
1994         {
1995             err = osl_File_copy( srcUnqPath,dstUnqPath,testExistBeforeCopy );
1996         }
1997         else if( TypeToCopy == FileUrlType::Folder )
1998         {
1999             osl::Directory aDir( srcUnqPath );
>>>     CID 1490899:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "open" without checking return value (as is done elsewhere 33 out of 41 times).
2000             aDir.open();
2001     
2002             err = osl::Directory::create( dstUnqPath );
2003             osl::FileBase::RC next = err;
2004             if( err == osl::FileBase::E_None )
2005             {

** CID 1490898:    (CHECKED_RETURN)
/hwpfilter/source/hwpread.cxx: 73 in FieldCode::Read(HWPFile &)()
/hwpfilter/source/hwpread.cxx: 76 in FieldCode::Read(HWPFile &)()


________________________________________________________________________________________________________
*** CID 1490898:    (CHECKED_RETURN)
/hwpfilter/source/hwpread.cxx: 73 in FieldCode::Read(HWPFile &)()
67         uint len1;       /* Length of hchar type string DATA #1 */
68         uint len2;       /* Length of hchar type string DATA #2 */
69         uint len3;       /* Length of hchar type string DATA #3 */
70         uint binlen;     /* Length of any binary data format */
71     
72         hwpf.Read4b(size);
>>>     CID 1490898:    (CHECKED_RETURN)
>>>     Calling "Read2b" without checking return value (as is done elsewhere 45 out of 47 times).
73         hwpf.Read2b(dummy);
74         hwpf.ReadBlock(&type, 2);
75         hwpf.Read4b(reserved1.data(), 1);
76         hwpf.Read2b(location_info);
77         hwpf.ReadBlock(reserved2.data(), 22);
78         hwpf.Read4b(len1);
/hwpfilter/source/hwpread.cxx: 76 in FieldCode::Read(HWPFile &)()
70         uint binlen;     /* Length of any binary data format */
71     
72         hwpf.Read4b(size);
73         hwpf.Read2b(dummy);
74         hwpf.ReadBlock(&type, 2);
75         hwpf.Read4b(reserved1.data(), 1);
>>>     CID 1490898:    (CHECKED_RETURN)
>>>     Calling "Read2b" without checking return value (as is done elsewhere 45 out of 47 times).
76         hwpf.Read2b(location_info);
77         hwpf.ReadBlock(reserved2.data(), 22);
78         hwpf.Read4b(len1);
79         hwpf.Read4b(len2);
80         hwpf.Read4b(len3);
81         bool bSuccess = hwpf.Read4b(binlen);


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DSGf8_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiWVgLSSLavBQzbdOP3tHoT1YMNjwUkJhKZvAbMXByubX22kJ35kSU6HTOsLxQvaetDHFID4RtezkzgoFcDiT0JSnYRytoPbSfMae4kHlSDnTNPxgFAZkUwx7g1IEb8-2FK90qxGXXiYLZe-2BxUhTF4rGxFQuDD2LUgn-2FtMZtxIWravU-3D