Hi, Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan. 124 new defect(s) introduced to LibreOffice found with Coverity Scan. 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 20 of 124 defect(s) ** CID 1489541: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 754 in XSecParser::XadesCertificateValuesContext::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() ________________________________________________________________________________________________________ *** CID 1489541: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 754 in XSecParser::XadesCertificateValuesContext::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() 748 css::uno::Reference<css::xml::sax::XAttributeList> const& xAttrs) override 749 { 750 m_rParser.HandleIdAttr(xAttrs); 751 } 752 753 virtual std::unique_ptr<Context> CreateChildContext( >>> CID 1489541: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 754 std::optional<SvXMLNamespaceMap> pOldNamespaceMap, 755 sal_uInt16 const nNamespace, OUString const& rName) override 756 { 757 if (nNamespace == XML_NAMESPACE_XADES132 && rName == "EncapsulatedX509Certificate") 758 { 759 return std::make_unique<XadesEncapsulatedX509CertificateContext>(m_rParser, std::move(pOldNamespaceMap)); ** CID 1489540: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 1339 in XSecParser::DsObjectContext::DsObjectContext(XSecParser&, std::optional<SvXMLNamespaceMap>)() ________________________________________________________________________________________________________ *** CID 1489540: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 1339 in XSecParser::DsObjectContext::DsObjectContext(XSecParser&, std::optional<SvXMLNamespaceMap>)() 1333 1334 class XSecParser::DsObjectContext 1335 : public XSecParser::ReferencedContextImpl 1336 { 1337 public: 1338 DsObjectContext(XSecParser & rParser, >>> CID 1489540: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 1339 std::optional<SvXMLNamespaceMap> pOldNamespaceMap) 1340 // init with "false" here - the Signature element can't be referenced by its child 1341 : XSecParser::ReferencedContextImpl(rParser, std::move(pOldNamespaceMap), false) 1342 { 1343 } 1344 ** CID 1489539: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 675 in OOXMLSecParser::XadesSigningCertificateContext::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() ________________________________________________________________________________________________________ *** CID 1489539: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 675 in OOXMLSecParser::XadesSigningCertificateContext::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() 669 bool const isReferenced) 670 : ReferencedContextImpl(rParser, std::move(pOldNamespaceMap), isReferenced) 671 { 672 } 673 674 virtual std::unique_ptr<Context> CreateChildContext( >>> CID 1489539: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 675 std::optional<SvXMLNamespaceMap> pOldNamespaceMap, 676 sal_uInt16 const nNamespace, OUString const& rName) override 677 { 678 if (nNamespace == XML_NAMESPACE_XADES132 && rName == "Cert") 679 { 680 return std::make_unique<XadesCertContext>(m_rParser, std::move(pOldNamespaceMap), m_isReferenced); ** CID 1489538: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 846 in XSecParser::LoSignatureLineIdContext::LoSignatureLineIdContext(XSecParser&, std::optional<SvXMLNamespaceMap>, bool)() ________________________________________________________________________________________________________ *** CID 1489538: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 846 in XSecParser::LoSignatureLineIdContext::LoSignatureLineIdContext(XSecParser&, std::optional<SvXMLNamespaceMap>, bool)() 840 { 841 private: 842 OUString m_Value; 843 844 public: 845 LoSignatureLineIdContext(XSecParser & rParser, >>> CID 1489538: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 846 std::optional<SvXMLNamespaceMap> pOldNamespaceMap, 847 bool const isReferenced) 848 : ReferencedContextImpl(rParser, std::move(pOldNamespaceMap), isReferenced) 849 { 850 } 851 ** CID 1489537: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 191 in XSecParser::DsPGPKeyIDContext::DsPGPKeyIDContext(XSecParser&, std::optional<SvXMLNamespaceMap>)() ________________________________________________________________________________________________________ *** CID 1489537: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 191 in XSecParser::DsPGPKeyIDContext::DsPGPKeyIDContext(XSecParser&, std::optional<SvXMLNamespaceMap>)() 185 { 186 private: 187 OUString m_Value; 188 189 public: 190 DsPGPKeyIDContext(XSecParser & rParser, >>> CID 1489537: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 191 std::optional<SvXMLNamespaceMap> pOldNamespaceMap) 192 : XSecParser::Context(rParser, std::move(pOldNamespaceMap)) 193 { 194 } 195 196 virtual void EndElement() override ** CID 1489536: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 306 in OOXMLSecParser::DsSignatureValueContext::DsSignatureValueContext(OOXMLSecParser&, std::optional<SvXMLNamespaceMap>)() ________________________________________________________________________________________________________ *** CID 1489536: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 306 in OOXMLSecParser::DsSignatureValueContext::DsSignatureValueContext(OOXMLSecParser&, std::optional<SvXMLNamespaceMap>)() 300 { 301 private: 302 OUString m_Value; 303 304 public: 305 DsSignatureValueContext(OOXMLSecParser & rParser, >>> CID 1489536: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 306 std::optional<SvXMLNamespaceMap> pOldNamespaceMap) 307 : OOXMLSecParser::Context(rParser, std::move(pOldNamespaceMap)) 308 { 309 } 310 311 virtual void StartElement( ** CID 1489535: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 1323 in XSecParser::DsSignaturePropertiesContext::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() ________________________________________________________________________________________________________ *** CID 1489535: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 1323 in XSecParser::DsSignaturePropertiesContext::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() 1317 css::uno::Reference<css::xml::sax::XAttributeList> const& xAttrs) override 1318 { 1319 CheckIdAttrReferenced(xAttrs); 1320 } 1321 1322 virtual std::unique_ptr<Context> CreateChildContext( >>> CID 1489535: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 1323 std::optional<SvXMLNamespaceMap> pOldNamespaceMap, 1324 sal_uInt16 const nNamespace, OUString const& rName) override 1325 { 1326 if (nNamespace == XML_NAMESPACE_DS && rName == "SignatureProperty") 1327 { 1328 return std::make_unique<DsSignaturePropertyContext>(m_rParser, std::move(pOldNamespaceMap), m_isReferenced); ** CID 1489534: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 1009 in XSecParser::XadesCertContext::XadesCertContext(XSecParser&, std::optional<SvXMLNamespaceMap>, bool)() ________________________________________________________________________________________________________ *** CID 1489534: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 1009 in XSecParser::XadesCertContext::XadesCertContext(XSecParser&, std::optional<SvXMLNamespaceMap>, bool)() 1003 OUString m_CertDigest; 1004 OUString m_X509IssuerName; 1005 OUString m_X509SerialNumber; 1006 1007 public: 1008 XadesCertContext(XSecParser & rParser, >>> CID 1489534: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 1009 std::optional<SvXMLNamespaceMap> pOldNamespaceMap, 1010 bool const isReferenced) 1011 : ReferencedContextImpl(rParser, std::move(pOldNamespaceMap), isReferenced) 1012 { 1013 } 1014 ** CID 1489533: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 455 in XSecParser::DsDigestValueContext::DsDigestValueContext(XSecParser&, std::optional<SvXMLNamespaceMap>, rtl::OUString &)() ________________________________________________________________________________________________________ *** CID 1489533: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 455 in XSecParser::DsDigestValueContext::DsDigestValueContext(XSecParser&, std::optional<SvXMLNamespaceMap>, rtl::OUString &)() 449 { 450 private: 451 OUString & m_rValue; 452 453 public: 454 DsDigestValueContext(XSecParser & rParser, >>> CID 1489533: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 455 std::optional<SvXMLNamespaceMap> pOldNamespaceMap, 456 OUString & rValue) 457 : XSecParser::Context(rParser, std::move(pOldNamespaceMap)) 458 , m_rValue(rValue) 459 { 460 } ** CID 1489532: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 1077 in OOXMLSecParser::DsManifestContext::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() ________________________________________________________________________________________________________ *** CID 1489532: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 1077 in OOXMLSecParser::DsManifestContext::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() 1071 { 1072 m_rParser.m_pXSecController->setReferenceCount(); 1073 } 1074 #endif 1075 1076 virtual std::unique_ptr<Context> CreateChildContext( >>> CID 1489532: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 1077 std::optional<SvXMLNamespaceMap> pOldNamespaceMap, 1078 sal_uInt16 const nNamespace, OUString const& rName) override 1079 { 1080 if (nNamespace == XML_NAMESPACE_DS && rName == "Reference") 1081 { 1082 return std::make_unique<DsReferenceContext>(m_rParser, std::move(pOldNamespaceMap)); ** CID 1489531: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 109 in OOXMLSecParser::ReferencedContextImpl::ReferencedContextImpl(OOXMLSecParser&, std::optional<SvXMLNamespaceMap>, bool)() ________________________________________________________________________________________________________ *** CID 1489531: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 109 in OOXMLSecParser::ReferencedContextImpl::ReferencedContextImpl(OOXMLSecParser&, std::optional<SvXMLNamespaceMap>, bool)() 103 { 104 protected: 105 bool m_isReferenced; 106 107 public: 108 ReferencedContextImpl(OOXMLSecParser & rParser, >>> CID 1489531: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 109 std::optional<SvXMLNamespaceMap> pOldNamespaceMap, 110 bool const isReferenced) 111 : OOXMLSecParser::Context(rParser, std::move(pOldNamespaceMap)) 112 , m_isReferenced(isReferenced) 113 { 114 } ** CID 1489530: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 594 in OOXMLSecParser::XadesCertDigestContext::XadesCertDigestContext(OOXMLSecParser&, std::optional<SvXMLNamespaceMap>, rtl::OUString &, int &)() ________________________________________________________________________________________________________ *** CID 1489530: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 594 in OOXMLSecParser::XadesCertDigestContext::XadesCertDigestContext(OOXMLSecParser&, std::optional<SvXMLNamespaceMap>, rtl::OUString &, int &)() 588 private: 589 OUString & m_rDigestValue; 590 sal_Int32 & m_rReferenceDigestID; 591 592 public: 593 XadesCertDigestContext(OOXMLSecParser & rParser, >>> CID 1489530: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 594 std::optional<SvXMLNamespaceMap> pOldNamespaceMap, 595 OUString & rDigestValue, sal_Int32 & rReferenceDigestID) 596 : OOXMLSecParser::Context(rParser, std::move(pOldNamespaceMap)) 597 , m_rDigestValue(rDigestValue) 598 , m_rReferenceDigestID(rReferenceDigestID) 599 { ** CID 1489529: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 83 in OOXMLSecParser::Context::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() ________________________________________________________________________________________________________ *** CID 1489529: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 83 in OOXMLSecParser::Context::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() 77 { 78 m_rParser.HandleIdAttr(xAttrs); 79 } 80 }; 81 82 auto OOXMLSecParser::Context::CreateChildContext( >>> CID 1489529: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 83 std::optional<SvXMLNamespaceMap> pOldNamespaceMap, 84 sal_uInt16 const /*nNamespace*/, OUString const& /*rName*/) 85 -> std::unique_ptr<Context> 86 { 87 // default: create new base context 88 return std::make_unique<UnknownContext>(m_rParser, std::move(pOldNamespaceMap)); ** CID 1489528: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 723 in OOXMLSecParser::XadesSignedSignaturePropertiesContext::XadesSignedSignaturePropertiesContext(OOXMLSecParser&, std::optional<SvXMLNamespaceMap>, bool)() ________________________________________________________________________________________________________ *** CID 1489528: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 723 in OOXMLSecParser::XadesSignedSignaturePropertiesContext::XadesSignedSignaturePropertiesContext(OOXMLSecParser&, std::optional<SvXMLNamespaceMap>, bool)() 717 718 class OOXMLSecParser::XadesSignedSignaturePropertiesContext 719 : public OOXMLSecParser::ReferencedContextImpl 720 { 721 public: 722 XadesSignedSignaturePropertiesContext(OOXMLSecParser & rParser, >>> CID 1489528: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 723 std::optional<SvXMLNamespaceMap> pOldNamespaceMap, 724 bool const isReferenced) 725 : ReferencedContextImpl(rParser, std::move(pOldNamespaceMap), isReferenced) 726 { 727 } 728 ** CID 1489527: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 1055 in XSecParser::XadesSigningCertificateContext::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() ________________________________________________________________________________________________________ *** CID 1489527: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 1055 in XSecParser::XadesSigningCertificateContext::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() 1049 bool const isReferenced) 1050 : ReferencedContextImpl(rParser, std::move(pOldNamespaceMap), isReferenced) 1051 { 1052 } 1053 1054 virtual std::unique_ptr<Context> CreateChildContext( >>> CID 1489527: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 1055 std::optional<SvXMLNamespaceMap> pOldNamespaceMap, 1056 sal_uInt16 const nNamespace, OUString const& rName) override 1057 { 1058 if (nNamespace == XML_NAMESPACE_XADES132 && rName == "Cert") 1059 { 1060 return std::make_unique<XadesCertContext>(m_rParser, std::move(pOldNamespaceMap), m_isReferenced); ** CID 1489526: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 783 in XSecParser::XadesUnsignedSignaturePropertiesContext::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() ________________________________________________________________________________________________________ *** CID 1489526: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 783 in XSecParser::XadesUnsignedSignaturePropertiesContext::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() 777 css::uno::Reference<css::xml::sax::XAttributeList> const& xAttrs) override 778 { 779 m_rParser.HandleIdAttr(xAttrs); 780 } 781 782 virtual std::unique_ptr<Context> CreateChildContext( >>> CID 1489526: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 783 std::optional<SvXMLNamespaceMap> pOldNamespaceMap, 784 sal_uInt16 const nNamespace, OUString const& rName) override 785 { 786 if (nNamespace == XML_NAMESPACE_XADES132 && rName == "CertificateValues") 787 { 788 return std::make_unique<XadesCertificateValuesContext>(m_rParser, std::move(pOldNamespaceMap)); ** CID 1489525: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 983 in XSecParser::XadesCertDigestContext::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() ________________________________________________________________________________________________________ *** CID 1489525: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 983 in XSecParser::XadesCertDigestContext::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() 977 , m_rDigestValue(rDigestValue) 978 , m_rReferenceDigestID(rReferenceDigestID) 979 { 980 } 981 982 virtual std::unique_ptr<Context> CreateChildContext( >>> CID 1489525: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 983 std::optional<SvXMLNamespaceMap> pOldNamespaceMap, 984 sal_uInt16 const nNamespace, OUString const& rName) override 985 { 986 if (nNamespace == XML_NAMESPACE_DS && rName == "DigestMethod") 987 { 988 return std::make_unique<DsDigestMethodContext>(m_rParser, std::move(pOldNamespaceMap), m_rReferenceDigestID); ** CID 1489524: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 841 in OOXMLSecParser::MsodigsigSignatureCommentsContext::MsodigsigSignatureCommentsContext(OOXMLSecParser&, std::optional<SvXMLNamespaceMap>, rtl::OUString &)() ________________________________________________________________________________________________________ *** CID 1489524: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/ooxmlsecparser.cxx: 841 in OOXMLSecParser::MsodigsigSignatureCommentsContext::MsodigsigSignatureCommentsContext(OOXMLSecParser&, std::optional<SvXMLNamespaceMap>, rtl::OUString &)() 835 { 836 private: 837 OUString & m_rValue; 838 839 public: 840 MsodigsigSignatureCommentsContext(OOXMLSecParser & rParser, >>> CID 1489524: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 841 std::optional<SvXMLNamespaceMap> pOldNamespaceMap, 842 OUString & rValue) 843 : OOXMLSecParser::Context(rParser, std::move(pOldNamespaceMap)) 844 , m_rValue(rValue) 845 { 846 } ** CID 1489523: Memory - corruptions (OVERRUN) ________________________________________________________________________________________________________ *** CID 1489523: Memory - corruptions (OVERRUN) /vcl/unx/generic/app/saldisp.cxx: 1899 in SalX11Display::Yield()() 1893 DBG_ASSERT( GetSalData()->m_pInstance->GetYieldMutex()->IsCurrentThread(), 1894 "will crash soon since solar mutex not locked in SalDisplay::Yield" ); 1895 1896 XNextEvent( pDisp_, &aEvent ); 1897 1898 // FIXME: under-convinced by Dispatch boolean return value vs. salframe. >>> CID 1489523: Memory - corruptions (OVERRUN) >>> Overrunning struct type XEvent of 192 bytes by passing it to a function which accesses it at byte offset 1535. 1899 Dispatch( &aEvent ); 1900 1901 #ifdef DBG_UTIL 1902 if( GetX11SalData()->HasXErrorOccurred() ) 1903 { 1904 XFlush( pDisp_ ); ** CID 1489522: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 324 in XSecParser::DsX509IssuerSerialContext::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() ________________________________________________________________________________________________________ *** CID 1489522: Performance inefficiencies (PASS_BY_VALUE) /xmlsecurity/source/helper/xsecparser.cxx: 324 in XSecParser::DsX509IssuerSerialContext::CreateChildContext(std::optional<SvXMLNamespaceMap>, unsigned short, const rtl::OUString &)() 318 , m_rX509IssuerName(rIssuerName) 319 , m_rX509SerialNumber(rSerialNumber) 320 { 321 } 322 323 virtual std::unique_ptr<Context> CreateChildContext( >>> CID 1489522: Performance inefficiencies (PASS_BY_VALUE) >>> Passing parameter pOldNamespaceMap of type "std::optional<SvXMLNamespaceMap>" (size 240 bytes) by value. 324 std::optional<SvXMLNamespaceMap> pOldNamespaceMap, 325 sal_uInt16 const nNamespace, OUString const& rName) override 326 { 327 if (nNamespace == XML_NAMESPACE_DS && rName == "X509IssuerName") 328 { 329 return std::make_unique<DsX509IssuerNameContext>(m_rParser, std::move(pOldNamespaceMap), m_rX509IssuerName); ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DXkje_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiCgccWvRZoaf7kBlhYtkl0CS0o-2Bc5lt7mZ6v7jkjkUbQZH-2Bdu1ieDv9qXzkUJfXaSt3xiBD3bdXqIGGEiAD3-2BOJZxZz1KwfCzIXf7N5Pt48iM0GJ5IJpDzv5LNz8rRzDxBHaX2S0H6exIWaEWG1LbP8YGPJqbOuB0Mi5L34eEdjo-3D _______________________________________________ LibreOffice mailing list LibreOffice@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/libreoffice