I need a code reviewer for a patch I submitted to gerrit for bug tdf#104169.
The bug is a difficultyInteresting EasyHack and involves Calc and mouse cursors. It is actually an enhancement to calc and aims at introducing a new cross cursor to replace the current Arrow pointer while hovering over the spreadsheet in calc.
This patch is in continuation to an unfinished patch submitted by Mesut Cifci an year ago (https://gerrit.libreoffice.org/c/core/+/89744). At the time Mesut was working on this bug, a cross cursor was already present in calc but it was the thin, black-coloured cross used for auto-fill. Mesut added another thicker, white cross to use in this bug, which goes by the name FatCross in code.
I adjusted cursor hotspot and fixed some cursor calls on mouse clicks in code and have (apparently not) completed the enhancement. I successfully tested the new cursor on my Linux system. It looks like this: https://bugs.documentfoundation.org/attachment.cgi?id=171459. But Heiko soon reported an issue with the appearance of the cursor on his configuration (another flavour of Linux): https://bugs.documentfoundation.org/attachment.cgi?id=171447. I have, so far, failed to replicate the problem on my system. (More details on gerrit)
So I need someone to review my code (and perhaps help a bit if needed).
An opinion or suggestion on the cursor's appearance would also be appreciated.
Thanks
Sarabjot Singh
_______________________________________________ LibreOffice mailing list LibreOffice@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/libreoffice
