Fwd: [core] tdf#138122 Add window scaling for retina displays on macOS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Does anybody have an idea how to get the below issue (<https://gerrit.libreoffice.org/c/core/+/109072/7#message-5887f8c25bb72394085acbdb6be4c998ef7abf58>) fixed?


-------- Forwarded Message --------
Subject: [core] tdf#138122 Add window scaling for retina displays on macOS
Date: Wed, 14 Apr 2021 20:09:48 +0200
From: Stephan Bergmann (via Code Review) <gerrit@xxxxxxxxxxxxxxxxxxxxxx>
Reply-To: sbergman@xxxxxxxxxx, lohmaier+LibreOffice@xxxxxxxxxxxxxx, sbergman@xxxxxxxxxx, nadavvin@xxxxxxxxx, rb.henschel@xxxxxxxxxxx, thorsten.wagner.4@xxxxxxxxx, tml@xxxxxxxxxxxxx, matteo.casalin@xxxxxxxxxxxxxxx To: Thorsten Wagner <thorsten.wagner.4@xxxxxxxxx>, Tor Lillqvist <tml@xxxxxxxxxxxxx> CC: Stephan Bergmann <sbergman@xxxxxxxxxx>, Christian Lohmaier <lohmaier+LibreOffice@xxxxxxxxxxxxxx>

Stephan Bergmann has posted comments on this change. ( https://gerrit.libreoffice.org/c/core/+/109072 )

Change subject: tdf#138122 Add window scaling for retina displays on macOS
......................................................................


Patch Set 7:

Since <https://git.libreoffice.org/core/+/6b8c157a0b4f37a09fdbf656919b2df06a3abc3e%5E!> "make RenderMaskPrimitive2DPixel() clip using clipping (tdf#140797)", opening on macOS sw/qa/extras/ooxmlexport/data/tdf136841.docx (which was later added by <https://git.libreoffice.org/core/+/076da4cd9d61adf15942a7bfc350bd0d268f64f1%5E!> "tdf#136841: sw_ooxmlexport16: Add unittest") no longer shows a black or red arrow, but instead a square with green-tinted diagonal stripes, offset far to the right. But that commit, changing VclProcessor2D::RenderMaskPrimitive2DPixel in drawinglayer/source/processor2d/vclprocessor2d.cxx, is not the actual culprit, but only started to execute code paths that had been broken earlier. So bisecting older commits with that commit locally cherry-picked, it turns out that this change here is what started to cause the issue.


--
To view, visit https://gerrit.libreoffice.org/c/core/+/109072
To unsubscribe, or for help writing mail filters, visit https://gerrit.libreoffice.org/settings

Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Change-Id: I99877cd62a98cb91bcbf27af62b043c31c5f5fc9
Gerrit-Change-Number: 109072
Gerrit-PatchSet: 7
Gerrit-Owner: Thorsten Wagner <thorsten.wagner.4@xxxxxxxxx>
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Tor Lillqvist <tml@xxxxxxxxxxxxx>
Gerrit-CC: Christian Lohmaier <lohmaier+LibreOffice@xxxxxxxxxxxxxx>
Gerrit-CC: Stephan Bergmann <sbergman@xxxxxxxxxx>
Gerrit-Comment-Date: Wed, 14 Apr 2021 18:09:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux