Re: proposition for patch in CommonSalLayout.cxx

[Miklos Vajna <vmiklos@xxxxxxxxxxxxx>]

Hi Stan,

On Mon, Mar 08, 2021 at 03:50:21PM +0100, Stanisław Jeśmanowicz <stan@xxxxxxxxxxxxxxxxxxxxx> wrote:
> Dear all,
> 
> I noticed that LibreOffice is using the hard coded harfbuzz shapers list in
> CommonSalLayout.cxx file (line 470).
> I recommend the patch attached to be more flexible.
> This take all possible shapers in a given HarfBuzz implementation.
> This also allows the use of newly created shapers.
> 
> Just repleces line:
> -  const char*const pHbShapers[] = { "dt", "graphite2", "coretext_aat", "ot", "fallback", nullptr };
> 
> with:
> +  const char **pHbShapers = hb_shape_list_shapers();

Are you more or less reverting 7854d35cd8172b201f1f3ad247860f242e5cb06b?
Can you describe what is the practical benefit of doing so?

Regards,

Miklos
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice