Re: Cherry pick for 7.1.1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 19.02.21 um 17:25 schrieb Dante Doménech:
I won't next time.
I've set them as WIP so they can be ignored until then.

El vie, 19 feb 2021 a las 13:52, Eike Rathke (<erack@xxxxxxxxxx <mailto:erack@xxxxxxxxxx>>) escribió:

    On Thursday, 2021-02-18 18:02:25 +0100, Dante Doménech wrote:

     > I did cherry pick a patch for 7.1.1

    As a side note, please don't create cherry-picks to release branches
    before the original change wasn't even merged to master, here
    https://gerrit.libreoffice.org/c/core/+/111155

FYI: this is not about ignorance in Gerrit. For release branches you need reviews, which get added to the commit message automatically on submit from Gerrit, if someone sets a +1 / +2. And Gerrit also adds the "cherry picked from" line as a reference to the origin, like:

Change-Id: Ia639ee3e5fc0e47f7017896b34730bbda7f06a16
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110945
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@xxxxxxxxxx>
(cherry picked from commit 41cffc379259fec626a282ca243a9750d96d1c63)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110915
Reviewed-by: Michael Weghorn <m.weghorn@xxxxxxxxx>
(cherry picked from commit 61bf6b4d90aa1d37009b397e44fe39c9c5b06afd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110920
Reviewed-by: Michael Stahl <michael.stahl@xxxxxxxxxxxxx>

So the cherry-pick gets more "history" and "trust".
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice




[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux