New Defects reported by Coverity Scan for LibreOffice

[scan-admin@xxxxxxxxxxxx]

Hi,

Please find the latest report on new defect(s) introduced to LibreOffice found with Coverity Scan.

5 new defect(s) introduced to LibreOffice found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 5 of 5 defect(s)


** CID 1472785:  Null pointer dereferences  (REVERSE_INULL)
/sc/source/ui/view/cellsh1.cxx: 2790 in ScCellShell::ExecuteEdit(SfxRequest &)()


________________________________________________________________________________________________________
*** CID 1472785:  Null pointer dereferences  (REVERSE_INULL)
/sc/source/ui/view/cellsh1.cxx: 2790 in ScCellShell::ExecuteEdit(SfxRequest &)()
2784     
2785                     const SfxInt32Item* param5 = rReq.GetArg<SfxInt32Item>(FN_PARAM_5);
2786                     SCROW table = param5 ? param5->GetValue() : 0;
2787     
2788                     ScInputHandler* pInputHdl = SC_MOD()->GetInputHdl();
2789     
>>>     CID 1472785:  Null pointer dereferences  (REVERSE_INULL)
>>>     Null-checking "pTabViewShell" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
2790                     if(param3 && param4 && pInputHdl && pTabViewShell)
2791                     {
2792                         ScViewData& rData = pTabViewShell->GetViewData();
2793                         ScTabView* pTabView = rData.GetView();
2794     
2795                         if (param1 && param2)

** CID 1472784:  Null pointer dereferences  (NULL_RETURNS)
/sw/source/filter/ww8/docxsdrexport.cxx: 804 in DocxSdrExport::startDMLAnchorInline(const SwFrameFormat *, const Size &)()


________________________________________________________________________________________________________
*** CID 1472784:  Null pointer dereferences  (NULL_RETURNS)
/sw/source/filter/ww8/docxsdrexport.cxx: 804 in DocxSdrExport::startDMLAnchorInline(const SwFrameFormat *, const Size &)()
798             else
799             {
800                 // In this case we likely had an odt document to be exported to docx.
801                 // There is no grab-bag or something else so for a workaround,
802                 // let's export the geometry of the shape...
803                 // First get the UNO-shape
>>>     CID 1472784:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a pointer that might be "nullptr" "const_cast<SdrObject *>(pFrameFormat->FindRealSdrObject())" when calling "getUnoShape". (The dereference happens because this is a virtual function call.)
804                 uno::Reference<drawing::XShape> xShape(
805                     const_cast<SdrObject*>(pFrameFormat->FindRealSdrObject())->getUnoShape(),
806                     uno::UNO_QUERY);
807     
808                 if (xShape && xShape->getShapeType() == u"com.sun.star.drawing.CustomShape")
809                 {

** CID 1472783:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1472783:  Null pointer dereferences  (FORWARD_NULL)
/sc/source/core/data/drwlayer.cxx: 2031 in ScDrawLayer::MirrorRTL(SdrObject *)()
2025                 // save and reload.
2026                 const tools::Long nInverseShift = aOldSnapRect.Left() + aOldSnapRect.Right();
2027                 const Point aLogicLT = pObj->GetLogicRect().TopLeft();
2028                 const Point aMirroredLogicLT = aLogicLT + Point(nInverseShift, 0);
2029                 const Point aOffsetDiff = aMirroredLogicLT - aOldLogicRect.TopLeft();
2030                 // new Offsets
>>>     CID 1472783:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "pNoRotatedAnchor->maStartOffset" to "operator +=", which dereferences it.
2031                 pNoRotatedAnchor->maStartOffset += aOffsetDiff;
2032                 pNoRotatedAnchor->maEndOffset += aOffsetDiff;
2033             }
2034             else // page anchored
2035             {
2036                 Point aRef1( 0, 0 );

** CID 1472782:  Null pointer dereferences  (FORWARD_NULL)


________________________________________________________________________________________________________
*** CID 1472782:  Null pointer dereferences  (FORWARD_NULL)
/sw/source/core/layout/fly.cxx: 681 in SwFlyFrame::SwClientNotify(const SwModify &, const SfxHint &)()
675                     pOItem = aOIter.NextItem();
676                 } while(pNItem);
677                 if(aOldSet.Count() || aNewSet.Count())
678                     SwLayoutFrame::SwClientNotify(rMod, sw::LegacyModifyHint(&aOldSet, &aNewSet));
679             }
680             else
>>>     CID 1472782:  Null pointer dereferences  (FORWARD_NULL)
>>>     Passing null pointer "pLegacy->m_pNew" to "UpdateAttr_", which dereferences it.
681                 UpdateAttr_(pLegacy->m_pOld, pLegacy->m_pNew, nInvFlags);
682     
683             if(nInvFlags == 0)
684                 return;
685     
686             Invalidate_();

** CID 1472781:  Error handling issues  (UNCAUGHT_EXCEPT)
/sw/source/core/ole/ndole.cxx: 992 in PurgeGuard::~PurgeGuard()()


________________________________________________________________________________________________________
*** CID 1472781:  Error handling issues  (UNCAUGHT_EXCEPT)
/sw/source/core/ole/ndole.cxx: 992 in PurgeGuard::~PurgeGuard()()
986         : m_rManager(const_cast<SwDoc&>(rDoc).GetDocumentSettingManager())
987         , m_bOrigPurgeOle(m_rManager.get(DocumentSettingId::PURGE_OLE))
988     {
989         m_rManager.set(DocumentSettingId::PURGE_OLE, false);
990     }
991     
>>>     CID 1472781:  Error handling issues  (UNCAUGHT_EXCEPT)
>>>     An exception of type "com::sun::star::uno::RuntimeException" is thrown but the throw list "noexcept" doesn't allow it to be thrown. This will cause a call to unexpected() which usually calls terminate().
992     PurgeGuard::~PurgeGuard()
993     {
994         m_rManager.set(DocumentSettingId::PURGE_OLE, m_bOrigPurgeOle);
995     }
996     
997     bool SwOLEObj::UnloadObject( uno::Reference< embed::XEmbeddedObject > const & xObj, const SwDoc* pDoc, sal_Int64 nAspect )


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3DHmom_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiwmjTNmVhM0F2565FWKp1c2B2Aa5q45MY8LubjERjOCgSeL8lRV9TCNxtiXnOZPNDvmifTShr6FpKKh0Eh57Hebm7ywmJkRqiQuA-2Fua1OdVFXDsigcazUS3yJwKTJqskFfrwnkzYux2RXSCKQH3p2FOnHe4HDhKqa77xIwiEUDtA5BtZ7NGU53wQjQwCnHR25

_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice