Re: Building LO on Raspberry pi 4b, error: unknown attribute 'externally_visible' on jni part

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



It seems "externally_visible" is a specific attribute of gcc (so not known by
clang).
See
https://gcc.gnu.org/onlinedocs/gcc-10.2.0/gcc/Common-Function-Attributes.html#Common-Function-Attributes
Reading the link, it seems we can ignore this error since it's only useful
if we use "-fwhole-program" and "git grep" in LO code shows it's not the
case.

So this patch removes the error:
diff --git a/bean/native/unix/com_sun_star_comp_beans_LocalOfficeWindow.c
b/bean/native/unix/com_sun_star_comp_beans_LocalOfficeWindow.c
index 069bb1ee050e..95b1434dd9c1 100644
--- a/bean/native/unix/com_sun_star_comp_beans_LocalOfficeWindow.c
+++ b/bean/native/unix/com_sun_star_comp_beans_LocalOfficeWindow.c
@@ -23,7 +23,17 @@
 #include <X11/Xutil.h>
 #include <X11/Intrinsic.h>
 
+// to deal with gcc specific attribute "externally_visible" used in
+// /usr/lib/jvm/java-11-openjdk-armhf/include/linux/jni_md.h:35
+// via /usr/lib/jvm/java-11-openjdk-armhf/include/jni.h
+#if defined __clang__
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wunknown-attributes"
+#endif
 #include <jni.h>
+#if defined __clang__
+#pragma clang diagnostic pop
+#endif

but "jni.h" is used in about 40 files (if we remove comments with jni.h or
odk examples).

I suppose a better solution exists than copy pasting this  workaround 40
times or perhaps should I avoid clang here and use gcc?

Julien



--
Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux