Re: Patch review

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



anshu khare kirjoitti 10.11.2020 klo 16.27:
Hi

Please review my patch

https://gerrit.libreoffice.org/c/core/+/105501

I have tested it. It's working fine.
Please merge it.

You did not address Jim's comment:
"Please see https://stackoverflow.com/questions/1967370/git-replacing-lf-with-crlf#1967986
I think this is the reason for diff showing all lines have been changed."

You have to fix this problem and amend your patch: https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch#Submitting_a_new_version

Ilmari
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux