Re: About removing long time deprecated types from public API

[julien2412 <serval2412@xxxxxxxx>]

sberg wrote
>> ...
> So if you see a benefit in doing this particular change:  I'd say, mark 
> the change as "[API CHANGE]" in the commit message, get it in, and 
> document the backwards incompatible change at 
> <https://wiki.documentfoundation.org/ReleaseNotes/7.1#API_Changes>.

Great!!!

I added [API CHANGE] to the change
https://gerrit.libreoffice.org/c/core/+/102436

Here the next commits I thought:
- a commit to replace sal_uChar from all locations except
include/sal/types.h
 (only 5 locations)
- a commit to replace sal_Char from all locations except include/sal/types.h
(202 locations so we'll use some automatic tool)
For these, I'll build locally + use "make check" before submitting.
then:
- a commit to remove sal_uChar + sal_Char from include/sal/types.h including
[API CHANGE]

Once all is pushed, I'll add the information in release notes.

Does it sound ok for you or do you want I merge/split some of the commits?

Julien



--
Sent from: http://document-foundation-mail-archive.969070.n3.nabble.com/Dev-f1639786.html
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice