Re: ppt import(?) bug hunting

["Dr. David Alan Gilbert" <dave@xxxxxxxxxxx>]

* Caol?n McNamara (caolanm@xxxxxxxxxx) wrote:
> On Sun, 2020-09-06 at 16:30 +0100, Dr. David Alan Gilbert wrote:
> > So I'm now even more convinced that the right thing to do is just
> > nuke these two lines
> 
> That does look convincing, that it was left over and accidentally not
> updated at 8a64144fddde61dd050da4cb93b4a7242a495bb2 to the new reality

OK great, I'll look at sending a fix over the weekend.

> > suggest how else I should test it?
> 
> Along with your change to fix this, the ideal thing is to also add a
> test to (probably) sd/qa/unit/import-tests.cxx to assert the desired
> value for the numbering level 

I guess the fun is trying to find the right data - maybe like testTdf90626?

Dave

> 
> _______________________________________________
> LibreOffice mailing list
> LibreOffice@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/libreoffice
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice