Re: [core] tdf#87963: Add percentage value to new calculated compressed image size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I have the following code compressgraphicdialog.ui

 <child>
                          <object class="GtkLabel" id="label10">
                            <property name="visible">True</property>
                            <property name="can_focus">False</property>
                            <property name="label" translatable="yes" context="compressgraphicdialog|label10">Percentage Change :</property>
                            <property name="xalign">0</property>
                            <accessibility>
                                <relation type="label-for" target="label-percent-change"/>
                            </accessibility>
                          </object>
                          <packing>
                            <property name="left_attach">0</property>
                            <property name="top_attach">5</property>
                          </packing>
                        </child>
                        <child>
                          <object class="GtkLabel" id="label-percent-change">
                            <property name="visible">True</property>
                            <property name="can_focus">False</property>
                            <property name="hexpand">True</property>
                            <property name="label">???</property>
                            <property name="xalign">0</property>
                            <accessibility>
                                <relation type="labelled-by" target="label10"/>
                            </accessibility>
                          </object>
                          <packing>
                            <property name="left_attach">1</property>
                            <property name="top_attach">5</property>
                          </packing>
                        </child>

Also, I have added this code in compressgraphicdialog.hxx

std::unique_ptr<weld::Label>    m_xFixedText7;


and this line of code in compressgraphicdialog.cxx

void CompressGraphicsDialog::Initialize()
{
.
.
.

 m_xFixedText7 = m_xBuilder->weld_label("label-percent-change");

.
.
.
}

There are no building errors here.

But when I add the following code in compressgraphicdialog.cxx

void CompressGraphicsDialog::Update()
{
.
.
.
m_xFixedText7->set_label("working");
.
.
.
}

It gives the following exception:

Exception thrown at 0x00007FF99AEF0EA6 (svxlo.dll) in soffice.bin: 0xC0000005: Access violation reading location 0x0000000000000000. occurred.

Could you please tell me what is going wrong here?

Regards
Anshu

On Mon, 24 Aug, 2020, 9:39 PM anshu khare, <anshukhare50@xxxxxxxxx> wrote:
  Hi,

I have the following code compressgraphicdialog.ui

 <child>
                          <object class="GtkLabel" id="label10">
                            <property name="visible">True</property>
                            <property name="can_focus">False</property>
                            <property name="label" translatable="yes" context="compressgraphicdialog|label10">Percentage Change :</property>
                            <property name="xalign">0</property>
                            <accessibility>
                                <relation type="label-for" target="label-percent-change"/>
                            </accessibility>
                          </object>
                          <packing>
                            <property name="left_attach">0</property>
                            <property name="top_attach">5</property>
                          </packing>
                        </child>
                        <child>
                          <object class="GtkLabel" id="label-percent-change">
                            <property name="visible">True</property>
                            <property name="can_focus">False</property>
                            <property name="hexpand">True</property>
                            <property name="label">???</property>
                            <property name="xalign">0</property>
                            <accessibility>
                                <relation type="labelled-by" target="label10"/>
                            </accessibility>
                          </object>
                          <packing>
                            <property name="left_attach">1</property>
                            <property name="top_attach">5</property>
                          </packing>
                        </child>

Also, I have added this code in compressgraphicdialog.hxx

std::unique_ptr<weld::Label>    m_xFixedText7;


and this line of code in compressgraphicdialog.cxx

void CompressGraphicsDialog::Initialize()
{
.
.
.

 m_xFixedText7 = m_xBuilder->weld_label("label-percent-change");

.
.
.
}

There are no building errors here.

But when I add the following code in compressgraphicdialog.cxx

void CompressGraphicsDialog::Update()
{
.
.
.
m_xFixedText7->set_label("working");
.
.
.
}

It gives the following exception:

Exception thrown at 0x00007FF99AEF0EA6 (svxlo.dll) in soffice.bin: 0xC0000005: Access violation reading location 0x0000000000000000. occurred.

Could you please tell me what is going wrong here?

Regards
Anshu

On Mon, Aug 24, 2020 at 2:26 AM Jim Raykowski (via Code Review) <gerrit@xxxxxxxxxxxxxxxxxxxxxx> wrote:
Jim Raykowski has posted comments on this change. ( https://gerrit.libreoffice.org/c/core/+/101242 )

Change subject: tdf#87963: Add percentage value to new calculated compressed image size
......................................................................


Patch Set 2:

You could make necessary changes by directly editing core/svx/uiconfig/ui/compressgraphicdialog.ui or use Glade https://glade.gnome.org/


--
To view, visit https://gerrit.libreoffice.org/c/core/+/101242
To unsubscribe, or for help writing mail filters, visit https://gerrit.libreoffice.org/settings

Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Change-Id: I5fb87fd4d8cceb38775cb98520c0c7ba1d49bc93
Gerrit-Change-Number: 101242
Gerrit-PatchSet: 2
Gerrit-Owner: Anshu <anshukhare50@xxxxxxxxx>
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Julien Nabet <serval2412@xxxxxxxx>
Gerrit-CC: Jim Raykowski <raykowj@xxxxxxxxx>
Gerrit-CC: Shivam Kumar Singh <shivamhere247@xxxxxxxxx>
Gerrit-CC: Tomaž Vajngerl <quikee@xxxxxxxxx>
Gerrit-Comment-Date: Sun, 23 Aug 2020 20:56:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice

[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux