Re: LO building fails with non debug mode on slideshow/source/engine/box2dtools.cxx (loplugin:staticmethods)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for the heads up Julien,

On Sun, 16 Aug 2020 at 22:18, Stephan Bergmann <sbergman@xxxxxxxxxx> wrote:
> (In the given cases, though, it seems more plausible to get rid of the
> asserts, which appear to not state something of relevance for those

Removed the asserts, if there's a valid box2DBody that means
box2DWorld is already initiated and assert is irrelevant.

> functions, and indeed make them static member functions or even
> non-member functions.)

and went with making them non-member functions.
The patch is up for review at https://gerrit.libreoffice.org/c/core/+/100856
_______________________________________________
LibreOffice mailing list
LibreOffice@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/libreoffice



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux